From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by sourceware.org (Postfix) with ESMTPS id EE9C2385EC55 for ; Fri, 4 Dec 2020 13:50:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org EE9C2385EC55 Received: by mail-ed1-x544.google.com with SMTP id r5so5849612eda.12 for ; Fri, 04 Dec 2020 05:50:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=5KfWBN9MdU3WcnQ8e8ddEWmTaUzRhM7f2ccOwQonFLY=; b=DqpsVAw8xSXIJ2t+VOVLvpfuh8H0qebAIgnc8H80jiB2Ssjz1tl7Rwr1e3RloqKGPy 5e4neMFwR4loOrzuyXBeAPFn5WZo+SFx7xUD+LSHREUnbSjw+zz36g37WmCvIT0KdtTT BnSc6BQWz+VLWMxnwsxVZ/oTpBih32yY8tdYft1Shixm8ZHZmDNJJb1L9X9nhOqsa50V Y42/X9SlmChKFBwwkRtRZpzsoYFyMNwWRKUFbwelmdJnexEVyUSJdDsLFzeIM997TPhZ exXJgBBuGQy9WASiZAui4UxpZQAawB2DgiW8JTfz6S5X6FdQhNprHKiKhwrqcGjHS31/ kvug== X-Gm-Message-State: AOAM530iBAsd5QluON9okMtNDUvh7e/POh056To+FNxJA2U72FdVDRpN owM+G7MP4dG/gL2w/4AQnVUo1GT2GzvqwFtHxr8= X-Google-Smtp-Source: ABdhPJyEm7klNtg0PTQeiD7atahtlfKI1FyFWnNiaXSJRvOr995B9ZGuMz7JYkFth2gwasRYy2Qg3JXhk72DXmKQ6yU= X-Received: by 2002:aa7:ce94:: with SMTP id y20mr7510465edv.361.1607089842084; Fri, 04 Dec 2020 05:50:42 -0800 (PST) MIME-Version: 1.0 References: <19efbc7c-f38b-2689-7b6a-27175ca7bb0f@suse.cz> <9159005a-ff96-3db2-65eb-7d5be3faf6f2@suse.cz> <20201204133449.GK3788@tucnak> In-Reply-To: <20201204133449.GK3788@tucnak> From: Richard Biener Date: Fri, 4 Dec 2020 14:50:31 +0100 Message-ID: Subject: Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format. To: Jakub Jelinek Cc: =?UTF-8?Q?Martin_Li=C5=A1ka?= , "Joseph S. Myers" , Qing Zhao , GCC Patches , Nick Clifton Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Dec 2020 13:50:44 -0000 On Fri, Dec 4, 2020 at 2:35 PM Jakub Jelinek wrote: > > On Fri, Dec 04, 2020 at 02:30:45PM +0100, Martin Li=C5=A1ka wrote: > > On 12/4/20 10:03 AM, Richard Biener wrote: > > > Otherwise 0001- looks good to me. > > > > Pushed that to master. > > > > > As said I'd like to see opinions > > > from others on the > > > driver / backend communication for 0002. > > > > To be honest, we moved back to the original implementation which used > > a temporary file. There hasn't been any opinion for last 8 months :( > > Using environment variable rather than a temporary file must be faster. But it's difficult to preserve behavior with -save-temps and execing cc1 as printed which is why I don't like it too much, even if it is "faster". The environment might also be of limited size and with including everything (-I... -L...) and always (a defect of the patch) I fear we might run over its size limits on some host OSs at least. Richard. > Jakub >