From: Richard Biener <richard.guenther@gmail.com>
To: Eugene Rozenfeld <Eugene.Rozenfeld@microsoft.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Jan Hubicka <hubicka@ucw.cz>
Subject: Re: [PATCH] Don't set full_profile in auto-profile [PR113765]
Date: Wed, 3 Apr 2024 13:56:17 +0200 [thread overview]
Message-ID: <CAFiYyc318BetgNRzSw74QwGfKEwU0-eoVOM-HTJm-d-GZMKeRA@mail.gmail.com> (raw)
In-Reply-To: <CO1PR21MB1331A639DA11EBFE8BEAB45D913B2@CO1PR21MB1331.namprd21.prod.outlook.com>
On Thu, Mar 28, 2024 at 4:03 AM Eugene Rozenfeld
<Eugene.Rozenfeld@microsoft.com> wrote:
>
> auto-profile currently doesn't guarantee that it will set probabilities
> on all edges because of zero basic block counts. Normally those edges
> just have probabilities set by the preceding profile_estimate pass but
> under -O0 profile_estimate pass doesn't run. The patch removes setting
> of full_profile to true in auto-profile.
OK.
Thanks,
Richard.
> Tested on x86_64-pc-linux-gnu.
>
> gcc/ChangeLog:
> * auto-profile.cc (afdo_annotate_cfg): Don't set full_profile to true
> ---
> gcc/auto-profile.cc | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/gcc/auto-profile.cc b/gcc/auto-profile.cc
> index e5407d32fbb..de59b94bcb3 100644
> --- a/gcc/auto-profile.cc
> +++ b/gcc/auto-profile.cc
> @@ -1580,7 +1580,6 @@ afdo_annotate_cfg (const stmt_set &promoted_stmts)
> }
> update_max_bb_count ();
> profile_status_for_fn (cfun) = PROFILE_READ;
> - cfun->cfg->full_profile = true;
> if (flag_value_profile_transformations)
> {
> gimple_value_profile_transformations ();
> --
> 2.25.1
>
prev parent reply other threads:[~2024-04-03 11:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 3:02 Eugene Rozenfeld
2024-04-03 11:56 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc318BetgNRzSw74QwGfKEwU0-eoVOM-HTJm-d-GZMKeRA@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=Eugene.Rozenfeld@microsoft.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).