From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by sourceware.org (Postfix) with ESMTPS id 90A9B3847718 for ; Wed, 3 Apr 2024 11:56:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 90A9B3847718 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 90A9B3847718 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::22f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712145393; cv=none; b=J09Exyx9VzupaSnK4Ek4mcHF0gBgCK3cFzyvU4RSAszd66ZvzCyE5douU13PSxeM7EbVOvWWZzPlNgnoZy4JaH+IR4sZ95rUs5YJWs0YOq2XH26H6BeAaKibUeVWwNHAq550T9vjesQcSOea2vChCTjMTmJe46CPDfowjYu8/sM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712145393; c=relaxed/simple; bh=6iOrX6Q/bVREn8VYFiNJWmPfUS7wo0PtpXwcILbREwE=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=w7QvoqgTpu8cGjJvKeU5cka8+bSEbvgPiNkeB9cwdssQYFIcU4RhKHBsk1SR2usLMhwoATOoufjSAALdYRxbVXj5Et2Cdmt0N28BU17LYoUXygtz9n+hV+AbyUL0jHgseSBjJSMBRJNY8Udm5U+rtZ3c82t3XLupX944uo8jFRU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2d29aad15a5so72399401fa.3 for ; Wed, 03 Apr 2024 04:56:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712145389; x=1712750189; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Y/1IrExfmqeKj1PJDWVm3QNAFoWKAcj7EukSOsUEJo8=; b=CSzx3BFLp9IxAgkFOEU73P/zun9esCcJQGO18GkLmpbetF68B6QqXB0wmIj/Iy/LVA DqObjQIePoQZS9DE95LXhuX1eaHOapxdzQPe4xajkfdn926ijboCwiS/iyEqx6Q1Y8Qv 79XmuMhZ3Ai6bfg3BkmWLt0hBanvG+S7STgYZvMi0t6D48kGj8IC1ynrtu7FpsJD2VEL BA+w7qVObJNlmNKy/WOgu8bI3o8kH/uwT9lnTAicz//0C22BnU3WCEnNywutXq2EpZXw +rTBrlJC65w8VDoXadOpOCgHooIC2Rqiue7/qSvYlM7SbmIr4zC1z3BFGz04zmyGMWpi 468g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712145389; x=1712750189; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y/1IrExfmqeKj1PJDWVm3QNAFoWKAcj7EukSOsUEJo8=; b=PvZPy8u73iAoZKkFJb6VnmKVxbVlDnzrWgqzwr+Acj137EQ/3Q5JXO3egAaQ/cAV6a hNq8I2OD70wShQkEmGP9+fZXIhDaJXYeL8mN8P7Bq6jabq1bsCTxestaYMzsapD1+E3L MCwVEWnHD3kb+m65rf6We53IV0FTUxJnVaBTQVHFWopuwpFkvQ553YvpPym7DncxtFDb kGRaFHWZdDT32iLPCDqURL9w2O6E14J8fjDlYHuPJZd6e85zGLYK4xbXGdCM2Wu6RPsc 477lKvgVORmBTOPyEwsv97Wr/Yhy1kw6iGED47DUUQy+oXofcjp5x+9jJBpXd7+28gq/ kkOA== X-Gm-Message-State: AOJu0YxVmwKhrdSrdo9Iq+8WpY+B/vqRy5JltRtrnjKM/VnELB2p9fok lixTSfVH0iCLeWGz+2+cP64Am+pH3HFoXxlA+UDePbCv3ywwNSB7y12UPEvyqv3H8MVlyufB+IY l8s8IZBAyJYQnh59SfIHshHH2UW8= X-Google-Smtp-Source: AGHT+IGp3kYtfOZ36thK5zObk7Ea54qGdHY8WrrqxG6i1H7tIYWDXw0YKvj+ktJYefVP30HClSNQDhJC5WT8vJ4RM7U= X-Received: by 2002:a2e:7a14:0:b0:2d8:1259:6792 with SMTP id v20-20020a2e7a14000000b002d812596792mr6214503ljc.8.1712145388532; Wed, 03 Apr 2024 04:56:28 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Richard Biener Date: Wed, 3 Apr 2024 13:56:17 +0200 Message-ID: Subject: Re: [PATCH] Don't set full_profile in auto-profile [PR113765] To: Eugene Rozenfeld Cc: "gcc-patches@gcc.gnu.org" , Jan Hubicka Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Mar 28, 2024 at 4:03=E2=80=AFAM Eugene Rozenfeld wrote: > > auto-profile currently doesn't guarantee that it will set probabilities > on all edges because of zero basic block counts. Normally those edges > just have probabilities set by the preceding profile_estimate pass but > under -O0 profile_estimate pass doesn't run. The patch removes setting > of full_profile to true in auto-profile. OK. Thanks, Richard. > Tested on x86_64-pc-linux-gnu. > > gcc/ChangeLog: > * auto-profile.cc (afdo_annotate_cfg): Don't set full_profile to = true > --- > gcc/auto-profile.cc | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/gcc/auto-profile.cc b/gcc/auto-profile.cc > index e5407d32fbb..de59b94bcb3 100644 > --- a/gcc/auto-profile.cc > +++ b/gcc/auto-profile.cc > @@ -1580,7 +1580,6 @@ afdo_annotate_cfg (const stmt_set &promoted_stmts) > } > update_max_bb_count (); > profile_status_for_fn (cfun) =3D PROFILE_READ; > - cfun->cfg->full_profile =3D true; > if (flag_value_profile_transformations) > { > gimple_value_profile_transformations (); > -- > 2.25.1 >