From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19480 invoked by alias); 15 Mar 2012 15:57:29 -0000 Received: (qmail 19326 invoked by uid 22791); 15 Mar 2012 15:57:26 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-iy0-f175.google.com (HELO mail-iy0-f175.google.com) (209.85.210.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 15 Mar 2012 15:57:12 +0000 Received: by iaag37 with SMTP id g37so4401625iaa.20 for ; Thu, 15 Mar 2012 08:57:12 -0700 (PDT) MIME-Version: 1.0 Received: by 10.42.131.73 with SMTP id y9mr7933339ics.42.1331827032193; Thu, 15 Mar 2012 08:57:12 -0700 (PDT) Received: by 10.42.222.194 with HTTP; Thu, 15 Mar 2012 08:57:12 -0700 (PDT) In-Reply-To: <20120315123954.GA27018@mx.loc> References: <20070327170903.GA11737@aon.at> <1330636193-25099-1-git-send-email-rep.dot.nop@gmail.com> <4F594879.7080203@sfr.fr> <20120313163858.GB29875@mx.loc> <3D0569AE-048B-40F9-B916-523B32670B6B@comcast.net> <20120315123954.GA27018@mx.loc> Date: Thu, 15 Mar 2012 15:57:00 -0000 Message-ID: Subject: Re: [PATCH] gfortran testsuite: implicitly cleanup-modules From: Richard Guenther To: Bernhard Reutner-Fischer Cc: Mike Stump , Mikael Morin , fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org, ro@cebitec.uni-bielefeld.de Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-03/txt/msg01080.txt.bz2 On Thu, Mar 15, 2012 at 1:39 PM, Bernhard Reutner-Fischer wrote: > On Tue, Mar 13, 2012 at 01:30:29PM -0700, Mike Stump wrote: >>On Mar 13, 2012, at 9:38 AM, Bernhard Reutner-Fischer wrote: >>> Could some of the testsuite maintainers please eyeball? >> >>I've eyed it, the only thing that stood out was: >> >>-foreach testcase [lsort [glob -nocomplain $srcdir/$subdir/*.F]] { >>- =A0 =A0if ![runtest_file_p $runtests $testcase] then { >>- =A0 =A0 =A0continue >>- =A0 =A0} >>- =A0 =A0fortran-torture $testcase >>-} >>- >>-foreach testcase [lsort [glob -nocomplain $srcdir/$subdir/*.f90]] { >>- =A0 =A0if ![runtest_file_p $runtests $testcase] then { >>- =A0 =A0 =A0continue >>- =A0 =A0} >>- =A0 =A0fortran-torture $testcase >>-} >> >>which, I hope does what you want. > > It replaces a manually unrolled loop with a loop over the > testcase-extensions and works as expected. Or did you mean something > else? >> >>Assuming you like those parts, Ok. > > committed as r185430. You forgot to add fortran-modules.exp :( That breaks final testing result it seems (at least). Richard. >> >>Since it touches non-fortran, please watch for and respond to any problem= s it might cause. > > Of course, as always. > > PS: I saw that the cleanup-tree-dump is also a bit redundant. > When looking at e.g. gcc/testsuite/gcc.dg/pr52578.c one would think that > scan-tree-dump-times might be able to automagically collect which > dumpfiles to cleanup as last step in dg-final. > > One could go one step further and even implicitly add the corresponding > dg-options according to the expected scan-tree-dump files although this > might not be worth it iff there are passes that may produce dump-files > different to their pass name (did not look if this is possible). One > would have to strip the pass-number off the dump-file for passes that > are run more than once, too. Just a thought.. > > Thanks and cheers,