From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by sourceware.org (Postfix) with ESMTPS id 400DE385B50C for ; Tue, 25 Jun 2024 10:31:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 400DE385B50C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 400DE385B50C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::12d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719311493; cv=none; b=suH2iSAr/cIG4bXl5BSEFrh/TqeT09TtPM96iZRMoOirwH/7ntYoNhhCW/M6pynVSCyrDrpAAk0yfd/pZOrtblt47l7B/uB3WiPZBeTP0wWfn3fo6INgBD8msLmOeugpkOu/sxX6pBSou0Apa2RpUf9WgZxH8ZWoJCkGPCltW6M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719311493; c=relaxed/simple; bh=ncpnFnqI/nfLx/LWIXBXzYhAl9aV4ve/m8fKRCNnTJE=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=S7kU+EEI6cEjie3lMuLy0/Yo51yFfJArRLMPj4D04DeNLwD5zppTmnj9ZClWscpmbLzBEM7uXTuG6jaJkWhcpFwyGKmEWfoBB4rBxVbpGdlcuYUzvnC1JLCFtckvocnWMcX/kI79soJwy8oHatTBrR3okd/zCNyoWWPMe/bMfvY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-52cd628f21cso4482884e87.3 for ; Tue, 25 Jun 2024 03:31:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719311490; x=1719916290; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=d5KHTVwkgzhfuFqNGeM9x0k0hS6NDIPV5z+pglyX9LY=; b=gx6C1oVul2f60f3b+hNRWSoTg9lNZa6JaIJ9U3hIvw9pf+cm6Wr69Zs7ufIcbJAAQK gdf+F8iu5GXNtHb1XPLcHBRAYcXJYLQAk5vkKnudbosiXjVf0oqg8WUdg7WA35a4PTH1 AZ7rrhLOIifUhjAScmDOaMmro6IGdDX51tggeWa/b3ZH90KChzIGbNpwg/+S4aaJw8NH PRurq4w+nSy9qiVoZea9tOxuxziEL0kblAy4FF6jQhL6Hs8aXLZ2rSkO+29sejtyGwaL mCukmJZuXAGpVvGCOOC31pjxyZaIElofeDeAsAWCDNTVCm9yGvdfv4fUHkfp5H9jUWHt Zx2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719311490; x=1719916290; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d5KHTVwkgzhfuFqNGeM9x0k0hS6NDIPV5z+pglyX9LY=; b=tykZ2GfXYf9SiLdudDBRA5zoAlJSqUZWDnFzTo/l+mrV7JawNx9MCfIb42S2DelmYP 2oB7gfE1mR2cEk1YX03sUjlYeiUwyIxYeD81Mj3Ey3PaovTd9DF3ACGwXaBJGOyl4xlP bU9LbbmobrV2im4q7zei0Cbon7Kx50aOYxxY1pZLTX0PgOnGj5fI6aQMEZVC3fErG6Bf BrAUtshLjCPn3o6MRfOnQGhiUAN4VJy0SfpBfA033vbwbf+oD5t2FnaN1Pjiq2RQDAFC r4dijEcL0AClTvFInNvNCNAnOUJyhs0qi6eypIBsDAiDojcndEGo8gg6OHlORHg+dQl5 8kFA== X-Gm-Message-State: AOJu0YwRItSWIn6P7RY14dQDzS85lJx9AlF3qJqbrAaOE6Wss+2MprAl xs3JdYsuS90oT6kDBu91dZZoUIbKUTBJ/TsZREUXpd4fzbdWTMG+Z/HlbqYdt6bZ3vWinVW/MTp PCn/A3AJ3Br2l2dc+jcb6erlqJiQ= X-Google-Smtp-Source: AGHT+IHEyVVs+FZiSWVsoAj/nZ+Yqnul7b6v/PS7ayf+Iz5N2ML0LdUcRZ4Bmx+w1jFlJFmJlssYJXGv7h0PYlfj7zo= X-Received: by 2002:a05:6512:3e1c:b0:52b:c0cd:7312 with SMTP id 2adb3069b0e04-52ce185dbb4mr5361064e87.49.1719311489350; Tue, 25 Jun 2024 03:31:29 -0700 (PDT) MIME-Version: 1.0 References: <20231230181328.GX19790@gate.crashing.org> <20240624193711.GY19790@gate.crashing.org> In-Reply-To: <20240624193711.GY19790@gate.crashing.org> From: Richard Biener Date: Tue, 25 Jun 2024 12:31:17 +0200 Message-ID: Subject: Re: [PATCH] Add a late-combine pass [PR106594] To: Segher Boessenkool Cc: gcc-patches@gcc.gnu.org, jlaw@ventanamicro.com, rdapp.gcc@gmail.com, richard.sandiford@arm.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Jun 24, 2024 at 9:38=E2=80=AFPM Segher Boessenkool wrote: > > I didn't see this before. Sigh. > > On Tue, Jan 02, 2024 at 09:47:11AM +0000, Richard Sandiford wrote: > > Segher Boessenkool writes: > > > On Tue, Oct 24, 2023 at 07:49:10PM +0100, Richard Sandiford wrote: > > >> This patch adds a combine pass that runs late in the pipeline. > > > > > > But it is not. It is a completely new thing, and much closer to > > > fwprop than to combine, too. > > > > Well, it is a combine pass. > > No, it is not. In the context of GCC combine is the instruction > combiner. Which does something else than this does. > > So use a different name. Please. It will be NAKked by the combine > maintainer otherwise. > > > It's not a new instance of the pass in > > combine.cc, but I don't think that's the implication. We already have > > two combine passes: the combine.cc one and the postreload one. > > There is no postreload-combine pass. There is a postreload pass that > does various trivial things. One of those is reload_combine, which is > nothing like combine. It is a kind of limited fwprop for memory > addressing. > > > > Could you rename it to something else, please? Something less confus= ing > > > to both users and maintainers :-) > > > > Do you have any suggestions? > > Since it is something like fwprop, maybe something like that? Or maybe > put "addressing" in the name, if that is the point here. > > > >> The pass currently has a single objective: remove definitions by > > >> substituting into all uses. > > > > > > The easy case ;-) > > > > And the yet a case that no existing pass handles. :) That's why I'm > > trying to add something that does. > > So, fwprop. fullprop Richard. > > Segher