From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 42495 invoked by alias); 10 Jun 2015 13:26:05 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 42485 invoked by uid 89); 10 Jun 2015 13:26:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ob0-f177.google.com Received: from mail-ob0-f177.google.com (HELO mail-ob0-f177.google.com) (209.85.214.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 10 Jun 2015 13:26:02 +0000 Received: by obbgp2 with SMTP id gp2so34748705obb.2 for ; Wed, 10 Jun 2015 06:26:01 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.60.92.131 with SMTP id cm3mr2825317oeb.23.1433942760936; Wed, 10 Jun 2015 06:26:00 -0700 (PDT) Received: by 10.76.115.167 with HTTP; Wed, 10 Jun 2015 06:26:00 -0700 (PDT) In-Reply-To: References: <551A2C7C.8060005@redhat.com> <5522AF73.5000706@redhat.com> Date: Wed, 10 Jun 2015 13:36:00 -0000 Message-ID: Subject: Re: [PR64164] drop copyrename, integrate into expand From: Richard Biener To: Alexandre Oliva Cc: Jeff Law , GCC Patches , Christophe Lyon , David Edelsohn , Eric Botcazou Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00755.txt.bz2 On Wed, Jun 10, 2015 at 2:24 AM, Alexandre Oliva wrote: > On Jun 5, 2015, Alexandre Oliva wrote: > >> On Apr 27, 2015, Richard Biener wrote: > >>>> +/* Return the promoted mode for name. If it is a named SSA_NAME, it >>>> + is the same as promote_decl_mode. Otherwise, it is the promoted >>>> + mode of a temp decl of same type as the SSA_NAME, if we had created >>>> + one. */ >>>> + >>>> +machine_mode >>>> +promote_ssa_mode (const_tree name, int *punsignedp) >>>> +{ >>>> + gcc_assert (TREE_CODE (name) == SSA_NAME); >>>> + >>>> + if (SSA_NAME_VAR (name)) >>>> + return promote_decl_mode (SSA_NAME_VAR (name), punsignedp); > >>> As above I'd rather not have different paths for anonymous vs. non-anonymous >>> vars (so just delete the above two lines). > >> Check > > This caused the sparc regression reported by Eric in > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64164#c37 > > We need to match the mode of the rtl created for the partition and the > promoted mode expected for the parm. I recall working to make parm and > result decls the partition leaders, so that promote_ssa_mode would DTRT, > but this escaped my mind when revisiting the patch after some time on > another project. > > So we either restore promote_ssa_mode's check for an underlying decl, at > least for PARM_ and RESULT_DECLs, or further massage function.c to deal > with the mode difference. Any preference? Alternatively not coalesce SSA names when promote_decl_mode gives different answers (for their underlying decl)? It sounds wrong to do that (if that is really what happens). Richard. > I'm reverting the patch for now, so that we don't have to rush to a fix > on this, and I can have more time to test and fix other arches. It was > a terrible mistake to not do so before submitting the final version of > the patch, or at least before installing it. I apologize for that. > > -- > Alexandre Oliva, freedom fighter http://FSFLA.org/~lxoliva/ > You must be the change you wish to see in the world. -- Gandhi > Be Free! -- http://FSFLA.org/ FSF Latin America board member > Free Software Evangelist|Red Hat Brasil GNU Toolchain Engineer