From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by sourceware.org (Postfix) with ESMTPS id 2EEC13858C60 for ; Fri, 2 Dec 2022 07:50:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2EEC13858C60 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-x132.google.com with SMTP id c1so6199257lfi.7 for ; Thu, 01 Dec 2022 23:50:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=mHUINpKm8D9GtNME/Jt0jSsPjGzgm1uibV6oHDSkCrE=; b=MhVEepRLOz37x8txGy5OXPjCodmCqKMhJfiRZdomn+HnwOOUYcfqjxo5noZWpPvRb4 vvsSJ4+96dkCjW8/aFzk/s10ogCZDYJrbS1vSAZ2Rkjw8qIEVhKkgtyEKZyCQlKc/MLc Q0fivUDsGeGHg+08b8hhoDYzxHWZWo15M5Fm08wz7BsjzAo2MVqgBjR3INN+jbKGf9DD AwP8i7lv6r4R5XLATBBnZZ5zC8oBHJ8yksAdiI/3M5VUZaVKGdTvp/ZMkR+UlcSA0/lJ CZWfK2A6vf3WyTjifIv4vwQ1db/S31qw72pMlaV0HrfIwZuOCCg+6FO3dHeZVdxvCyMa jrbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mHUINpKm8D9GtNME/Jt0jSsPjGzgm1uibV6oHDSkCrE=; b=R8oAiabaAGwv56v/L8zFpsHADVXN5OVSKwb9EtwTJ3h5LTeL8I+KWtE3Er0W/2S2jQ qf9ihpMjWUVD49nZwfCgHY9rmER9rFa8eWKEwO0IiACmOSrsGcMEdBqOY25yROqeeS22 R3Qjjn4kuGbMwZgtrmUxNbyifgMnB1ESc1mCQLPeL1nuaqFYZY/gvnYTnGTEKiMV94nL MLg91L0EAqXd3xWlPgTTEo2bxILgFWWBae+d5YLVGx24DGzTJjhXHCiHlcx2M9cAMHh4 rQcgUtDjhjcwwK/0J9+vkMaOd96CXHcIfpBIBGmEGrq3paH96bwnP2i4G3UOh/mNz4qR 3DKQ== X-Gm-Message-State: ANoB5pnmROkBx2+zY1WDpkTLyTcjgrIluc8V48yl0Ixc6rlziLtCXoiK bTiIcDatVKHq5zyiCl0k1OTNrF/ddmWliBiBcFU= X-Google-Smtp-Source: AA0mqf56hzphLoTdNNSpWoNqctIPyUBgci6BWH8DW/s2NNkVpHTkhQ/qNqsWvV15gDBwlrdMhB5O+iJXrjrWaL1Vg6U= X-Received: by 2002:a05:6512:3a96:b0:4b4:f5da:fb28 with SMTP id q22-20020a0565123a9600b004b4f5dafb28mr12984525lfu.169.1669967451520; Thu, 01 Dec 2022 23:50:51 -0800 (PST) MIME-Version: 1.0 References: <20221201165051.51853-1-jason@redhat.com> In-Reply-To: From: Richard Biener Date: Fri, 2 Dec 2022 08:50:38 +0100 Message-ID: Subject: Re: [PATCH RFA] driver: fix validate_switches logic To: Alexandre Oliva Cc: Jason Merrill , gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Dec 2, 2022 at 7:37 AM Alexandre Oliva via Gcc-patches wrote: > > On Dec 1, 2022, Jason Merrill wrote: > > > Once we see g*, starred is set. Then we see %:, and it sees that as a > > zero-length switch, which because starred is still set, matches any and all > > command-line options. So targets that use such a spec accept all options in > > the driver, while ones that don't reject some, such as the recent > > -nostdlib++. > > Woo, nice catch, thanks! > > I don't have authority to approve the patch, > but it's ok as far as I'm concerned. OK. > -- > Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ > Free Software Activist GNU Toolchain Engineer > Disinformation flourishes because many people care deeply about injustice > but very few check the facts. Ask me about