public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] Fix memory leak in inline_merge_summary
@ 2012-05-23 11:02 Martin Jambor
  2012-05-23 11:05 ` Richard Guenther
  0 siblings, 1 reply; 2+ messages in thread
From: Martin Jambor @ 2012-05-23 11:02 UTC (permalink / raw)
  To: GCC Patches; +Cc: Jan Hubicka

Hi,

the vector operand_map is not freed in inline_merge_summary, this
patch fixes it.  It looks fairly obvious and I also have talked about
the problem on IRC with Honza yesterday so I will commit it after
bootstrap and testing on x86_64-linux.

I suppose I should then test and commit it to the 4.7 branch...?

Thanks,

Martin


2012-05-23  Martin Jambor  <mjambor@suse.cz>

	* ipa-inline-analysis.c (inline_merge_summary): Free operand_map.

Index: src/gcc/ipa-inline-analysis.c
===================================================================
--- src.orig/gcc/ipa-inline-analysis.c
+++ src/gcc/ipa-inline-analysis.c
@@ -2696,6 +2696,7 @@ inline_merge_summary (struct cgraph_edge
   edge_set_predicate (edge, &true_p);
   /* Similarly remove param summaries.  */
   VEC_free (inline_param_summary_t, heap, es->param);
+  VEC_free (int, heap, operand_map);
 
   info->time = (info->time + INLINE_TIME_SCALE / 2) / INLINE_TIME_SCALE;
   info->size = (info->size + INLINE_SIZE_SCALE / 2) / INLINE_SIZE_SCALE;

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fix memory leak in inline_merge_summary
  2012-05-23 11:02 [PATCH] Fix memory leak in inline_merge_summary Martin Jambor
@ 2012-05-23 11:05 ` Richard Guenther
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Guenther @ 2012-05-23 11:05 UTC (permalink / raw)
  To: GCC Patches, Jan Hubicka

On Wed, May 23, 2012 at 1:02 PM, Martin Jambor <mjambor@suse.cz> wrote:
> Hi,
>
> the vector operand_map is not freed in inline_merge_summary, this
> patch fixes it.  It looks fairly obvious and I also have talked about
> the problem on IRC with Honza yesterday so I will commit it after
> bootstrap and testing on x86_64-linux.
>
> I suppose I should then test and commit it to the 4.7 branch...?

Yes.

Thanks,
Richard.

> Thanks,
>
> Martin
>
>
> 2012-05-23  Martin Jambor  <mjambor@suse.cz>
>
>        * ipa-inline-analysis.c (inline_merge_summary): Free operand_map.
>
> Index: src/gcc/ipa-inline-analysis.c
> ===================================================================
> --- src.orig/gcc/ipa-inline-analysis.c
> +++ src/gcc/ipa-inline-analysis.c
> @@ -2696,6 +2696,7 @@ inline_merge_summary (struct cgraph_edge
>   edge_set_predicate (edge, &true_p);
>   /* Similarly remove param summaries.  */
>   VEC_free (inline_param_summary_t, heap, es->param);
> +  VEC_free (int, heap, operand_map);
>
>   info->time = (info->time + INLINE_TIME_SCALE / 2) / INLINE_TIME_SCALE;
>   info->size = (info->size + INLINE_SIZE_SCALE / 2) / INLINE_SIZE_SCALE;

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-05-23 11:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-23 11:02 [PATCH] Fix memory leak in inline_merge_summary Martin Jambor
2012-05-23 11:05 ` Richard Guenther

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).