public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Biener <richard.guenther@gmail.com>
To: Richard Biener <richard.guenther@gmail.com>,
	GCC Patches <gcc-patches@gcc.gnu.org>,
		richard.sandiford@arm.com
Subject: Re: Fix nb_iterations calculation in tree-vect-loop-manip.c
Date: Wed, 16 Nov 2016 13:02:00 -0000	[thread overview]
Message-ID: <CAFiYyc3=-5xFO8uX8doUo+GSxBO=k-WwphLsEb4Lv9UR_JLX+g@mail.gmail.com> (raw)
In-Reply-To: <87r36c3fi2.fsf@e105548-lin.cambridge.arm.com>

On Tue, Nov 15, 2016 at 4:54 PM, Richard Sandiford
<richard.sandiford@arm.com> wrote:
> Richard Biener <richard.guenther@gmail.com> writes:
>> On Tue, Nov 15, 2016 at 1:44 PM, Richard Sandiford
>> <richard.sandiford@arm.com> wrote:
>>> We previously stored the number of loop iterations rather
>>> than the number of latch iterations.
>>
>> So ->nb_iterations was unused without SVE?  Otherwise can you please
>> add a testcase?
>
> TBH I can't remember whether we noticed this by inspection or whether
> it did manifest in the output somehow.  If it did, it would have been
> an extra unnecessary iteration after complete unrolling, but usually
> a later patch would remove the iteration as dead.

Ok then.

Thanks,
Richard.

> Thanks,
> Richard

      reply	other threads:[~2016-11-16 13:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-15 12:45 Richard Sandiford
2016-11-15 15:20 ` Richard Biener
2016-11-15 15:55   ` Richard Sandiford
2016-11-16 13:02     ` Richard Biener [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFiYyc3=-5xFO8uX8doUo+GSxBO=k-WwphLsEb4Lv9UR_JLX+g@mail.gmail.com' \
    --to=richard.guenther@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=richard.sandiford@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).