From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) by sourceware.org (Postfix) with ESMTPS id 9EDC23856DC8 for ; Tue, 28 Jun 2022 10:16:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9EDC23856DC8 Received: by mail-qk1-x72f.google.com with SMTP id b24so8457033qkn.4 for ; Tue, 28 Jun 2022 03:16:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zlzSZ7Kg9vbnjb8EQT10O3KRjwpJjgrJ+bQUxBHthIo=; b=mRGF8Mb8bByc1E9NjjFJ4frdT0hb3TeTavHT6oneRTw2RM/HLWghUYWwTqAKK69ikg ZJdAyldE/sMkiu/yEpRkCm5jhf7xM7Qx9LwPUa10AP1Oy8GkfmBqH2BrDEWW1y/ZrSSq eWFz+lmRv6ne4B07Rz/VYLaijvmeLVkYqQDHGxnJvJpJWieWOjRFRZZz7eDW8oR0viGS /3iuTkLh9H6PFqgWQzZxo3aLlxZfOEx1VdukQz29R6r+Zpp75MjH4tsDgdgSmYqOSPMw wG29JIdXlsejBFmROV9iXDyQoYyIFmSXnI7LwKIC21M5rydi5aP4l4kTBXBWl9/oqgA8 22OQ== X-Gm-Message-State: AJIora9Me8hcsDefasz58i0ANp65sFliTdh1LLHk2UxxPOeMfG7/ZLa5 YkRBqYIvq4R+YXcRoaCckUoJq6IH7srysGxP0t+aa0yWSAs= X-Google-Smtp-Source: AGRyM1tpv30t5dL6kq8tm78b/sGWINrQMnWO9CLYt+5bQBLQSkcExVAXcohbkqNWETluI8RlCh8/GpvpQwiZnQdcvS8= X-Received: by 2002:a05:620a:2903:b0:6af:41a4:3f71 with SMTP id m3-20020a05620a290300b006af41a43f71mr3909295qkp.350.1656411363999; Tue, 28 Jun 2022 03:16:03 -0700 (PDT) MIME-Version: 1.0 References: <20220603073056.2683008-1-aldyh@redhat.com> In-Reply-To: From: Richard Biener Date: Tue, 28 Jun 2022 12:15:52 +0200 Message-ID: Subject: Re: [COMMITTED] Implement vrange::supports_type_p. To: Aldy Hernandez Cc: GCC patches , Martin Liska , Andrew MacLeod Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2022 10:16:06 -0000 On Tue, Jun 28, 2022 at 11:33 AM Aldy Hernandez wrote: > > On Tue, Jun 28, 2022 at 9:36 AM Richard Biener > wrote: > > > > On Mon, Jun 27, 2022 at 9:00 PM Aldy Hernandez wrote: > > > > > > The conversion for loop-ch is trivial, since the range of a > > > GIMPLE_COND is always an integer. > > > > Yes - but doesn't this hint at the fact that the irange::supports_p is > > useless because it checks on the type of the comparison operand > > rather than the type of the comparison (boolean_type_node)? > > > > So .. instead of replacing it, remove it? > > You're absolutely right. > > OK pending tests? Yes. > Aldy