From: Richard Biener <richard.guenther@gmail.com>
To: Roger Sayle <roger@nextmovesoftware.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] x86: Provide expanders for truncdisi2 and friends.
Date: Fri, 17 Jul 2020 09:27:53 +0200 [thread overview]
Message-ID: <CAFiYyc3=ECPz=cSiGBnVgGmEyJ3BjuM7CCdVCkffiqkLtXJJTg@mail.gmail.com> (raw)
In-Reply-To: <001c01d65b61$5937e900$0ba7bb00$@nextmovesoftware.com>
On Thu, Jul 16, 2020 at 1:07 PM Roger Sayle <roger@nextmovesoftware.com> wrote:
>
>
> Hi Richard,
>
> Many thanks. As promised, here's a clean-up patch that removes the last direct
> call to targetm.truly_noop_truncation from the middle-end, allowing this hook
> at some point in the future to take modes instead of sizes.
>
> middle-end: Prefer TRULY_NOOP_TRUNCATION_MODES_P over raw target hook.
>
> This patch has been tested with "make bootstrap" and "make -k check" on
> x86_64-pc-linux-gnu with no regressions.
OK.
Richard.
> 2020-07-16 Roger Sayle <roger@nextmovesoftware.com>
>
> gcc/ChangeLog
> * function.c (assign_parm_setup_block): Use the macro
> TRULY_NOOP_TRUNCATION_MODES_P instead of calling
> targetm.truly_noop_truncation directly.
>
> Ok for mainline?
>
> Thanks again,
> Roger
> --
>
> -----Original Message-----
> From: Richard Biener <richard.guenther@gmail.com>
> Sent: 14 July 2020 15:17
> To: Roger Sayle <roger@nextmovesoftware.com>
> Cc: GCC Patches <gcc-patches@gcc.gnu.org>
> Subject: Re: [PATCH] x86: Provide expanders for truncdisi2 and friends.
>
> On Mon, Jul 13, 2020 at 4:50 PM Roger Sayle <roger@nextmovesoftware.com> wrote:
> > > It seems to be improving TARGET_TRULY_NOOP_TRUNCATION documentation might be useful here.
> > This is an excellent suggestion. How about the following/attached...
> >
> > > The only user (after your patch) of this hook is in function.c for the function parameter setup btw.
> >
> > The targetm.truly_noop_truncation in assign_parm_setup_block is the
> > last place that calls this hook directly (with sizes), but the
> > majority of uses go via TRULY_NOOP_TRUNCATION_MODES_P as defined in machmode.h.
> >
> > I'll prepare a patch to switch function.c to use
> > TRULY_NOOP_TRUNCATION_MODE_P so that we are consistent throughout the
> > compiler. In theory, this hook could then be changed to take modes
> > instead of (poly_unit64) sizes, but that clean-up might be tricky without access to the affected platforms.
> >
> > Is the above documentation change Ok for mainline?
> OK.
>
> Thanks,
> Richard.
>
> > Thanks,
> > Roger
> > --
> >
next prev parent reply other threads:[~2020-07-17 7:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-11 23:28 Roger Sayle
2020-07-13 6:53 ` Richard Biener
2020-07-13 14:50 ` Roger Sayle
2020-07-14 14:16 ` Richard Biener
2020-07-16 11:07 ` Roger Sayle
2020-07-17 7:27 ` Richard Biener [this message]
2020-07-11 23:33 Roger Sayle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiYyc3=ECPz=cSiGBnVgGmEyJ3BjuM7CCdVCkffiqkLtXJJTg@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=roger@nextmovesoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).