From: Richard Biener <richard.guenther@gmail.com>
To: David Edelsohn <dje.gcc@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Jason Merrill <jason@redhat.com>,
Jakub Jelinek <jakub@redhat.com>,
Martin Sebor <msebor@gmail.com>
Subject: Re: [PATCH] Fix pt.c bootstrap breakage
Date: Wed, 28 Feb 2018 10:21:00 -0000 [thread overview]
Message-ID: <CAFiYyc3AunKL-wHPUL9J1KzFk8ozGz1QNafv7CdUhLPp4+dyxQ@mail.gmail.com> (raw)
In-Reply-To: <CAGWvnyky17rtN9iQCeJ=FF1kGb+WSHQL39R-pwbZNLnLExXn-w@mail.gmail.com>
On Wed, Feb 28, 2018 at 12:27 AM, David Edelsohn <dje.gcc@gmail.com> wrote:
> The recent change to pt.c broke bootstrap by including C++ header file
> <string> directly and including it first. This patch changes to the
> necessary method which includes the header file via system.h.
>
> Okay?
Ok. But in reality nobody should use std::string ...
> Thanks, David
>
> * pt.c: Don't include string. Define INCLUDE_STRING before system.h.
>
> Index: pt.c
> ===================================================================
> --- pt.c (revision 258045)
> +++ pt.c (working copy)
> @@ -24,8 +24,8 @@
> all methods must be provided in header files; can't use a source
> file that contains only the method templates and "just win". */
>
> -#include <string>
> #include "config.h"
> +#define INCLUDE_STRING
> #include "system.h"
> #include "coretypes.h"
> #include "cp-tree.h"
prev parent reply other threads:[~2018-02-28 10:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 23:27 David Edelsohn
2018-02-28 10:21 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc3AunKL-wHPUL9J1KzFk8ozGz1QNafv7CdUhLPp4+dyxQ@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jason@redhat.com \
--cc=msebor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).