From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-473998-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 130213 invoked by alias); 28 Feb 2018 10:21:06 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 130204 invoked by uid 89); 28 Feb 2018 10:21:06 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-11.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mail-lf0-f52.google.com
Received: from mail-lf0-f52.google.com (HELO mail-lf0-f52.google.com) (209.85.215.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 28 Feb 2018 10:21:04 +0000
Received: by mail-lf0-f52.google.com with SMTP id t204so2687570lff.9        for <gcc-patches@gcc.gnu.org>; Wed, 28 Feb 2018 02:21:04 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20161025;        h=x-gm-message-state:mime-version:in-reply-to:references:from:date         :message-id:subject:to:cc;        bh=/SFDowuw3GS1lA0xHC6/sCdJ6Hxh/F+B/a0Z2ijMBcc=;        b=cif29y2kpDsYAmjoVR39NbHhAEIxtTj3bqK/J4OFR0z7NAbosM7a8yRcvLGQ0zks+z         4kmfAuSYIYCk60x50bp6+wQoeFEtd/4+vKMGj3eIeWF1SgJ1myCvUrtxnXF42KvUhmZP         r5+jcGjlnKZ8cW3GVKKwHzBDMK86aktWc5+e4p6qinbcGuAf5qGyv+LbOdBi0oCelPF1         siZPrPrr0ZE/W0Y290k780q9kyILpJC14CSNjv54I7/mxB/5TtTrwvpoAD09Chw4pJAC         CHSRRsnl99m6GIhC6FMEqQCDiiH0Uh9bhAoG0gFkNAf7OFeo2iWaZ9qPqdoYWnxnTNtG         6REw==
X-Gm-Message-State: APf1xPAfLiqf1jxJbCUO2B0w2CGukEJ9OyoQ15khM2kzCKZyiQTn5ulv	XRwI7HCZVNVJlNNskQ3796RmQEZwCGFBAHbEm+g=
X-Google-Smtp-Source: AG47ELsJt1wtxrXU/TCDgKo4JJ8Asdfui+/3poRC4Lw8pMclc6f4FpyZWrYml/iKvoeUHG1QHvNS3AZFLTT+vCPTZ2o=
X-Received: by 10.46.82.16 with SMTP id g16mr12226217ljb.67.1519813262683; Wed, 28 Feb 2018 02:21:02 -0800 (PST)
MIME-Version: 1.0
Received: by 10.46.18.208 with HTTP; Wed, 28 Feb 2018 02:21:02 -0800 (PST)
In-Reply-To: <CAGWvnyky17rtN9iQCeJ=FF1kGb+WSHQL39R-pwbZNLnLExXn-w@mail.gmail.com>
References: <CAGWvnyky17rtN9iQCeJ=FF1kGb+WSHQL39R-pwbZNLnLExXn-w@mail.gmail.com>
From: Richard Biener <richard.guenther@gmail.com>
Date: Wed, 28 Feb 2018 10:21:00 -0000
Message-ID: <CAFiYyc3AunKL-wHPUL9J1KzFk8ozGz1QNafv7CdUhLPp4+dyxQ@mail.gmail.com>
Subject: Re: [PATCH] Fix pt.c bootstrap breakage
To: David Edelsohn <dje.gcc@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, Jason Merrill <jason@redhat.com>, 	Jakub Jelinek <jakub@redhat.com>, Martin Sebor <msebor@gmail.com>
Content-Type: text/plain; charset="UTF-8"
X-IsSubscribed: yes
X-SW-Source: 2018-02/txt/msg01566.txt.bz2

On Wed, Feb 28, 2018 at 12:27 AM, David Edelsohn <dje.gcc@gmail.com> wrote:
> The recent change to pt.c broke bootstrap by including C++ header file
> <string> directly and including it first.  This patch changes to the
> necessary method which includes the header file via system.h.
>
> Okay?

Ok.  But in reality nobody should use std::string ...

> Thanks, David
>
> * pt.c: Don't include string. Define INCLUDE_STRING before system.h.
>
> Index: pt.c
> ===================================================================
> --- pt.c        (revision 258045)
> +++ pt.c        (working copy)
> @@ -24,8 +24,8 @@
>       all methods must be provided in header files; can't use a source
>       file that contains only the method templates and "just win".  */
>
> -#include <string>
>  #include "config.h"
> +#define INCLUDE_STRING
>  #include "system.h"
>  #include "coretypes.h"
>  #include "cp-tree.h"