From: Richard Guenther <richard.guenther@gmail.com>
To: Simon Baldwin <simonb@google.com>
Cc: gcc-patches@gcc.gnu.org, dnovillo@google.com
Subject: Re: [google] Remove timestamped line from gengtype state file comment headers
Date: Tue, 23 Aug 2011 14:47:00 -0000 [thread overview]
Message-ID: <CAFiYyc3AxWnO9-G8rnEHe9X148PF54HfB=W1NgvvmfTkDpa84g@mail.gmail.com> (raw)
In-Reply-To: <20110823123633.DEAAF1DA1D3@topo.tor.corp.google.com>
On Tue, Aug 23, 2011 at 2:36 PM, Simon Baldwin <simonb@google.com> wrote:
> Remove the timestamped line from gengtype state file comment headers.
>
> Gcc builds after r177358 include a file .../plugin/gtype.state as part of
> their binary installation. The file contains a comment line that includes
> the current date and time. Variations in the file contents due to only
> changes in the timestamp can be an issue for build and packaging systems
> that prefer or insist on binary compatibility.
>
> This patch removes the comment line, to provide binary reproducibility for
> any generated gtype.state files.
>
> Tested for x86 and PowerPC, no bootstrap in both cases.
>
> OK for google/integration? Also, OK for trunk?
Ok for trunk.
Richard.
> libstdc++-v3/ChangeLog:
> 2011-05-20 Simon Baldwin <simonb@google.com>
>
> * scripts/extract_symvers.in: Handle processor/OS specific or
> unknown symbol binding strings from readelf.
>
>
> Index: gcc/gengtype-state.c
> ===================================================================
> --- gcc/gengtype-state.c (revision 177984)
> +++ gcc/gengtype-state.c (working copy)
> @@ -1194,8 +1194,6 @@ write_state (const char *state_path)
> fprintf (state_file,
> ";;; This file should be parsed by the same %s which wrote it.\n",
> progname);
> - fprintf (state_file, ";;; file %s generated on %s\n", state_path,
> - ctime (&now));
> /* The first non-comment significant line gives the version string. */
> write_state_version (version_string);
> write_state_srcdir ();
>
next prev parent reply other threads:[~2011-08-23 12:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-23 14:40 Simon Baldwin
2011-08-23 14:47 ` Richard Guenther [this message]
2011-08-23 14:50 ` Michael Matz
2011-08-23 15:17 ` Simon Baldwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiYyc3AxWnO9-G8rnEHe9X148PF54HfB=W1NgvvmfTkDpa84g@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=dnovillo@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=simonb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).