From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14323 invoked by alias); 23 Aug 2011 12:37:53 -0000 Received: (qmail 14314 invoked by uid 22791); 23 Aug 2011 12:37:52 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-yw0-f47.google.com (HELO mail-yw0-f47.google.com) (209.85.213.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 23 Aug 2011 12:37:36 +0000 Received: by ywa12 with SMTP id 12so39684ywa.20 for ; Tue, 23 Aug 2011 05:37:35 -0700 (PDT) MIME-Version: 1.0 Received: by 10.42.245.1 with SMTP id ls1mr3576236icb.292.1314103054607; Tue, 23 Aug 2011 05:37:34 -0700 (PDT) Received: by 10.231.50.195 with HTTP; Tue, 23 Aug 2011 05:37:34 -0700 (PDT) In-Reply-To: <20110823123633.DEAAF1DA1D3@topo.tor.corp.google.com> References: <20110823123633.DEAAF1DA1D3@topo.tor.corp.google.com> Date: Tue, 23 Aug 2011 14:47:00 -0000 Message-ID: Subject: Re: [google] Remove timestamped line from gengtype state file comment headers From: Richard Guenther To: Simon Baldwin Cc: gcc-patches@gcc.gnu.org, dnovillo@google.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-08/txt/msg01889.txt.bz2 On Tue, Aug 23, 2011 at 2:36 PM, Simon Baldwin wrote: > Remove the timestamped line from gengtype state file comment headers. > > Gcc builds after r177358 include a file .../plugin/gtype.state as part of > their binary installation. =A0The file contains a comment line that inclu= des > the current date and time. =A0Variations in the file contents due to only > changes in the timestamp can be an issue for build and packaging systems > that prefer or insist on binary compatibility. > > This patch removes the comment line, to provide binary reproducibility for > any generated gtype.state files. > > Tested for x86 and PowerPC, no bootstrap in both cases. > > OK for google/integration? =A0Also, OK for trunk? Ok for trunk. Richard. > libstdc++-v3/ChangeLog: > 2011-05-20 =A0Simon Baldwin =A0 > > =A0 =A0 =A0 =A0* scripts/extract_symvers.in: Handle processor/OS specific= or > =A0 =A0 =A0 =A0unknown symbol binding strings from readelf. > > > Index: gcc/gengtype-state.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- gcc/gengtype-state.c =A0 =A0 =A0 =A0(revision 177984) > +++ gcc/gengtype-state.c =A0 =A0 =A0 =A0(working copy) > @@ -1194,8 +1194,6 @@ write_state (const char *state_path) > =A0 fprintf (state_file, > =A0 =A0 =A0 =A0 =A0 ";;; This file should be parsed by the same %s which = wrote it.\n", > =A0 =A0 =A0 =A0 =A0 progname); > - =A0fprintf (state_file, ";;; file %s generated on %s\n", state_path, > - =A0 =A0 =A0 =A0 =A0ctime (&now)); > =A0 /* The first non-comment significant line gives the version string. = =A0*/ > =A0 write_state_version (version_string); > =A0 write_state_srcdir (); >