From: Richard Biener <richard.guenther@gmail.com>
To: "Hurugalawadi, Naveen" <Naveen.Hurugalawadi@caviumnetworks.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"marc.glisse@inria.fr" <marc.glisse@inria.fr>,
"Pinski, Andrew" <Andrew.Pinski@caviumnetworks.com>,
"ubizjak@gmail.com" <ubizjak@gmail.com>
Subject: Re: [Patch] PR67351 Implement << N & >> N optimizers
Date: Thu, 03 Sep 2015 09:58:00 -0000 [thread overview]
Message-ID: <CAFiYyc3BL_+jcjtZRJ9vXp19jpnrPKNxhfJFZ2HtaOs8+-hmFQ@mail.gmail.com> (raw)
In-Reply-To: <SN2PR0701MB102453B17A317D2880604A428E680@SN2PR0701MB1024.namprd07.prod.outlook.com>
On Thu, Sep 3, 2015 at 9:29 AM, Hurugalawadi, Naveen
<Naveen.Hurugalawadi@caviumnetworks.com> wrote:
> Hi,
>
> Thanks for all the review and comments.
>
>>> replace the precision test with wi::ltu_p (@1, TYPE_PRECISION (type)
>>> use element_precision instead of TYPE_PRECISION
>
> Please find attached the modified patch as per review comments.
>
> Please review the same and let me know if the patch is okay?
Ok with the tree_fits_uhwi_p checks removed (they are redundant)
and with
+/* { dg-final { scan-assembler-not "<<" } } */
+/* { dg-final { scan-assembler-not ">>" } } */
replaced with
/* { dg-final { scan-tree-dump-not "<<" "optimized" } } */
Thanks,
Richard.
> Regression Tested on AArch64 and X86_64.
>
> Thanks,
> Naveen
prev parent reply other threads:[~2015-09-03 9:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-01 8:58 Hurugalawadi, Naveen
2015-09-01 9:15 ` Richard Biener
2015-09-02 11:18 ` Marc Glisse
2015-09-03 8:05 ` Hurugalawadi, Naveen
2015-09-03 8:39 ` Uros Bizjak
2015-09-03 9:58 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc3BL_+jcjtZRJ9vXp19jpnrPKNxhfJFZ2HtaOs8+-hmFQ@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=Andrew.Pinski@caviumnetworks.com \
--cc=Naveen.Hurugalawadi@caviumnetworks.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=marc.glisse@inria.fr \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).