From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by sourceware.org (Postfix) with ESMTPS id 231F83858412 for ; Mon, 10 Oct 2022 08:49:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 231F83858412 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x52b.google.com with SMTP id s2so14972431edd.2 for ; Mon, 10 Oct 2022 01:49:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Mlj6LktxTNUBD+DnUmPU+Ads1cWD5qOnj8jHcUmbqVY=; b=JnjKpFtUGWbPd1m91G7hc4Sty0Jw6yho/NDHZpEFuKS/odkxCuNQsj/Smd/J0chooU mq+o7zaWioy3hiZs0hwGLKq+Yp6o6d3QBktHxhpWsV14MGBAC6ZENSaHNh+sQHbNzWHi sB2iTGMgKj88rY8e3fBsBPgyoPctUwdA6ClvA7BCcTJFEIak+QGtNAFBzMVn7xN54kch W4zAd1R881Xu4x34hMbKUS6XU+lNM9A0h4sQ77dmkEeuwxfuBKsYT5jrwzY/kTg90tJx GBqiorux2biFRb1t2nsJ+H1kU9M1TvyKE2CtpJDCpUZ1Q06/j7NaBGJfOh/1oTJdDVee Qtlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Mlj6LktxTNUBD+DnUmPU+Ads1cWD5qOnj8jHcUmbqVY=; b=YQ6wL/7YUubYashQQzUgKEvzC/lpUZBFaU4n2oEBNAO2b4xwrUaYSpymi0Tga3w2Tg wbsf8O1mqr0tcakRWC0iJj/j4F9rwrJg2FF96px+iAcqXufUZqPgJ5gw833QeZo+M9Z3 4tqD+Twqq8OWubNV9F+2W3sZeiTFBqviNAxtrIZm0OOPH5ho/7k3vYsAqe/7MRNYdRqw RZeoZ1wn3DMUIY2kIU0HXyVuhaBGG+wiGJPvt99wZSSNsmNDgjwBZ2ieCIs/2zkUNlZZ Z3i5PxN9rrBFdn/OHI7iOSXqC/g5xvHsmMT2Owktm3l6ws30Bon3KlWQbGk56B+8HQGk thpA== X-Gm-Message-State: ACrzQf3FPfr/NmL89cJTiPP/N2Kw0PJqfNTB61VcImzFz3Kh2EjlSv0P S3GAto2gjrNjtpK6GjXZH4Cr4Yl20PgVFvW2Ue8= X-Google-Smtp-Source: AMsMyM4kd5740YfhucLrS8hltWEhkaBNnhDzv7kXle+XeDdeA6U+n8nP2qmQO71T3auO/tCstYwlhfXR8juMA7y4FHw= X-Received: by 2002:aa7:df16:0:b0:45b:f51f:ab73 with SMTP id c22-20020aa7df16000000b0045bf51fab73mr6875186edy.366.1665391740787; Mon, 10 Oct 2022 01:49:00 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Richard Biener Date: Mon, 10 Oct 2022 10:48:48 +0200 Message-ID: Subject: Re: [PATCH v2 00/10] Introduce strub: machine-independent stack scrubbing To: Alexandre Oliva Cc: gcc-patches@gcc.gnu.org, Jeremy Bennett , Craig Blackmore , Graham Markall , Martin Jambor , Jan Hubicka , Jim Wilson Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Jul 29, 2022 at 8:36 AM Alexandre Oliva wrote: > > On Jul 29, 2022, Alexandre Oliva wrote: > > > This patch adds the strub attribute for function and variable types, > > command-line options, passes and adjustments to implement it, > > documentation, and tests. > > The entire patch, and the patchlets used for testing, are available from > the GCC git repo, branch refs/users/aoliva/heads/strub: As noted in the Cauldron Discussion I think you should do all instrumentation post-IPA only to simplify your life not needing to handle inlining of instrumentation and to get the full benefit of WPA analysis when used with LTO. That might even mean doing it as a regular IPA pass where clones are used for strubbing and original bodies are used for inlining. Richard. > e9d1e252e0bcd silence warnings > 4a93638ee91b1 enable strub for all viable functions by default, for testing > 29e98f10c5faa Introduce strub: machine-independent stack scrubbing > > -- > Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ > Free Software Activist GNU Toolchain Engineer > Disinformation flourishes because many people care deeply about injustice > but very few check the facts. Ask me about