From: Richard Biener <richard.guenther@gmail.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] [6 and trunk] Fix bootstrap with older host compilers
Date: Mon, 18 Apr 2016 08:44:00 -0000 [thread overview]
Message-ID: <CAFiYyc3BzihmWd_UegtuBy9nF60DkFhY9VzcZnEEWEawnQ6=ww@mail.gmail.com> (raw)
In-Reply-To: <b975f7e32aa16e85a47f9b3271b7788a3c774cce.1460744758.git.segher@kernel.crashing.org>
On Fri, Apr 15, 2016 at 8:31 PM, Segher Boessenkool
<segher@kernel.crashing.org> wrote:
> We didn't have __builtin_swap16 on all targets before GCC 4.8; hsa-brig
> tries to use it if the host GCC is 4.6 or up though, breaking bootstrap.
> This trivial patch fixes it.
>
> Noticed on gcc22.
>
> Is this okay for trunk and gcc-6?
Ok.
Thanks,
Richard.
>
> Segher
>
>
> 2016-04-15 Segher Boessenkool <segher@kernel.crashing.org>
>
> * has-brig.c (lendian16): Don't try to use __builtin_bswap16
> unless compiling with at least GCC-4.8.
>
> ---
> gcc/hsa-brig.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/hsa-brig.c b/gcc/hsa-brig.c
> index a943e37..9c74b9a 100644
> --- a/gcc/hsa-brig.c
> +++ b/gcc/hsa-brig.c
> @@ -51,7 +51,7 @@ along with GCC; see the file COPYING3. If not see
> static uint16_t
> lendian16 (uint16_t val)
> {
> -#if GCC_VERSION >= 4006
> +#if GCC_VERSION >= 4008
> #if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__
> return val;
> #elif __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__
> --
> 1.9.3
>
prev parent reply other threads:[~2016-04-18 8:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-15 18:32 Segher Boessenkool
2016-04-18 8:44 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiYyc3BzihmWd_UegtuBy9nF60DkFhY9VzcZnEEWEawnQ6=ww@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).