public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] [6 and trunk] Fix bootstrap with older host compilers
@ 2016-04-15 18:32 Segher Boessenkool
  2016-04-18  8:44 ` Richard Biener
  0 siblings, 1 reply; 2+ messages in thread
From: Segher Boessenkool @ 2016-04-15 18:32 UTC (permalink / raw)
  To: gcc-patches; +Cc: Segher Boessenkool

We didn't have __builtin_swap16 on all targets before GCC 4.8; hsa-brig
tries to use it if the host GCC is 4.6 or up though, breaking bootstrap.
This trivial patch fixes it.

Noticed on gcc22.

Is this okay for trunk and gcc-6?


Segher


2016-04-15  Segher Boessenkool  <segher@kernel.crashing.org>

	* has-brig.c (lendian16): Don't try to use __builtin_bswap16
	unless compiling with at least GCC-4.8.

---
 gcc/hsa-brig.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/hsa-brig.c b/gcc/hsa-brig.c
index a943e37..9c74b9a 100644
--- a/gcc/hsa-brig.c
+++ b/gcc/hsa-brig.c
@@ -51,7 +51,7 @@ along with GCC; see the file COPYING3.  If not see
 static uint16_t
 lendian16 (uint16_t val)
 {
-#if GCC_VERSION >= 4006
+#if GCC_VERSION >= 4008
 #if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__
   return val;
 #elif __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__
-- 
1.9.3

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] [6 and trunk] Fix bootstrap with older host compilers
  2016-04-15 18:32 [PATCH] [6 and trunk] Fix bootstrap with older host compilers Segher Boessenkool
@ 2016-04-18  8:44 ` Richard Biener
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Biener @ 2016-04-18  8:44 UTC (permalink / raw)
  To: Segher Boessenkool; +Cc: GCC Patches

On Fri, Apr 15, 2016 at 8:31 PM, Segher Boessenkool
<segher@kernel.crashing.org> wrote:
> We didn't have __builtin_swap16 on all targets before GCC 4.8; hsa-brig
> tries to use it if the host GCC is 4.6 or up though, breaking bootstrap.
> This trivial patch fixes it.
>
> Noticed on gcc22.
>
> Is this okay for trunk and gcc-6?

Ok.

Thanks,
Richard.

>
> Segher
>
>
> 2016-04-15  Segher Boessenkool  <segher@kernel.crashing.org>
>
>         * has-brig.c (lendian16): Don't try to use __builtin_bswap16
>         unless compiling with at least GCC-4.8.
>
> ---
>  gcc/hsa-brig.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/hsa-brig.c b/gcc/hsa-brig.c
> index a943e37..9c74b9a 100644
> --- a/gcc/hsa-brig.c
> +++ b/gcc/hsa-brig.c
> @@ -51,7 +51,7 @@ along with GCC; see the file COPYING3.  If not see
>  static uint16_t
>  lendian16 (uint16_t val)
>  {
> -#if GCC_VERSION >= 4006
> +#if GCC_VERSION >= 4008
>  #if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__
>    return val;
>  #elif __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__
> --
> 1.9.3
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-04-18  8:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-15 18:32 [PATCH] [6 and trunk] Fix bootstrap with older host compilers Segher Boessenkool
2016-04-18  8:44 ` Richard Biener

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).