From: Richard Biener <richard.guenther@gmail.com>
To: Andrew Pinski <apinski@marvell.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 3/4] Try inverted comparison for match_simplify in phiopt
Date: Mon, 28 Jun 2021 10:44:18 +0200 [thread overview]
Message-ID: <CAFiYyc3C+xqOsiT32Xg7+1ntf3-cASCC9QWeR1=uZsgcQkQuQA@mail.gmail.com> (raw)
In-Reply-To: <1624836300-23553-4-git-send-email-apinski@marvell.com>
On Mon, Jun 28, 2021 at 1:28 AM apinski--- via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> From: Andrew Pinski <apinski@marvell.com>
>
> Since match and simplify does not have all of the inverted
> comparison patterns, it make sense to just have
> phi-opt try to do the inversion and try match and simplify again.
>
> OK? Bootstrapped and tested on x86_64-linux-gnu.
OK with the comment fix suggested by Bernhard. I think
if the match fails you have to somewhere discard the
sequence, since it can still end up with partly pushed
stmts - otherwise you'll slowly leak SSA names. Theres
gimple_seq_discard () for this. It's probably best to do it
in gimple_simplify_phiopt after each failed try.
Richard.
> Thanks,
> Andrew Pinski
>
> gcc/ChangeLog:
>
> * tree-ssa-phiopt.c (gimple_simplify_phiopt):
> If "A ? B : C" fails to simplify, try "(!A) ? C : B".
> ---
> gcc/tree-ssa-phiopt.c | 27 ++++++++++++++++++++++++++-
> 1 file changed, 26 insertions(+), 1 deletion(-)
>
> diff --git a/gcc/tree-ssa-phiopt.c b/gcc/tree-ssa-phiopt.c
> index 17bc597851b..9bda1b2a397 100644
> --- a/gcc/tree-ssa-phiopt.c
> +++ b/gcc/tree-ssa-phiopt.c
> @@ -836,7 +836,8 @@ phiopt_early_allow (enum tree_code code)
> with parts pushed if EARLY_P was true. Also rejects non allowed tree code
> if EARLY_P is set.
> Takes the comparison from COMP_STMT and two args, ARG0 and ARG1 and tries
> - to simplify CMP ? ARG0 : ARG1. */
> + to simplify CMP ? ARG0 : ARG1.
> + Also try to simplify (!CMP) ? ARG0 : ARG1 if the non-inverse failed. */
> static tree
> gimple_simplify_phiopt (bool early_p, tree type, gimple *comp_stmt,
> tree arg0, tree arg1,
> @@ -869,6 +870,30 @@ gimple_simplify_phiopt (bool early_p, tree type, gimple *comp_stmt,
> return result;
> }
> }
> + /* Try the inverted comparison, that is !COMP ? ARG1 : ARG0. */
> + comp_code = invert_tree_comparison (comp_code, HONOR_NANS (cmp0));
> +
> + if (comp_code == ERROR_MARK)
> + return NULL;
> +
> + cond = build2_loc (loc,
> + comp_code, boolean_type_node,
> + cmp0, cmp1);
> + gimple_match_op op1 (gimple_match_cond::UNCOND,
> + COND_EXPR, type, cond, arg1, arg0);
> +
> + if (op1.resimplify (early_p ? NULL : seq, follow_all_ssa_edges))
> + {
> + /* Early we want only to allow some generated tree codes. */
> + if (!early_p
> + || op1.code.is_tree_code ()
> + || phiopt_early_allow ((tree_code)op1.code))
> + {
> + result = maybe_push_res_to_seq (&op1, seq);
> + if (result)
> + return result;
> + }
> + }
>
> return NULL;
> }
> --
> 2.27.0
>
next prev parent reply other threads:[~2021-06-28 8:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-27 23:24 [PATCH 0/4] v4 PHI-OPT move abs_replacement to match.pd apinski
2021-06-27 23:24 ` [PATCH 1/4] Duplicate the range information of the phi onto the new ssa_name apinski
2021-06-28 8:39 ` Richard Biener
2021-06-29 19:02 ` Martin Sebor
2021-06-27 23:24 ` [PATCH 2/4] Allow match-and-simplified phiopt to run in early phiopt apinski
2021-06-28 8:40 ` Richard Biener
2021-06-29 19:11 ` Martin Sebor
2021-06-29 19:54 ` Andrew Pinski
2021-06-27 23:24 ` [PATCH 3/4] Try inverted comparison for match_simplify in phiopt apinski
2021-06-28 5:28 ` Bernhard Reutner-Fischer
2021-06-28 8:44 ` Richard Biener [this message]
2021-06-27 23:25 ` [PATCH 4/4] Port most of the A CMP 0 ? A : -A to match apinski
2021-06-28 9:26 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiYyc3C+xqOsiT32Xg7+1ntf3-cASCC9QWeR1=uZsgcQkQuQA@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=apinski@marvell.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).