From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by sourceware.org (Postfix) with ESMTPS id 245A33858400 for ; Thu, 26 Aug 2021 06:35:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 245A33858400 Received: by mail-ej1-x62f.google.com with SMTP id bt14so3877193ejb.3 for ; Wed, 25 Aug 2021 23:35:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Xt5fbMD7xgwZ1I1EKH2hVBTKF3yielJS17quJYhNPmM=; b=Tdb87QDKzJkYv3vUOIuLpJ9HFKyx4h5WK55d5bwceISY3dKax9e0FcFE+eKeFyQdDz 2KGg4mk0+2tnvt23AOZ5ZmPBodz+W+zWLZhUrOzHNzwmLmSbgLiojQZKcfd/zSkte1YG 71Z768SH1rpJ6TP4RiSaHZzY+ITKtGv3pIwmHExnN78hDaM6exb45aAKtXOY7rLJjky/ 3M1EJV+9JGDz45po/jrNgmZyB8NXo6hGCzlbScP2SfM5sh48PIkUsd5TjS7iWYPB5VIU 0L++1ri6M5V8gHHW+guKCpiKsT6g8ls+5VfXO3yE8M85WVrjOU4hJgWuHvGpfptm0gm9 uvxg== X-Gm-Message-State: AOAM533JoBk5+cdLps6imV+t9/LtIRFKvtm8aqt6gfAedRuHd/I1ewyc vbokLgHmP5THyzqZC+tYJfc0qFQRr+jv1lQ7SV8= X-Google-Smtp-Source: ABdhPJx03Kqe9h5z/DX61cS9srBVJe8BKu+zLhJTNlKWsYZq71DuMtJtfsQ7OwOyxrcUTbLP8pdT6mT/heEqeJ4UDaM= X-Received: by 2002:a17:906:6808:: with SMTP id k8mr2669127ejr.138.1629959712148; Wed, 25 Aug 2021 23:35:12 -0700 (PDT) MIME-Version: 1.0 References: <20210813135103.46696-1-hjl.tools@gmail.com> In-Reply-To: From: Richard Biener Date: Thu, 26 Aug 2021 08:35:01 +0200 Message-ID: Subject: Re: [GCC-11] [PATCH 0/5] Finish and general-regs-only To: Uros Bizjak Cc: "H.J. Lu" , Jan Hubicka , GCC Patches , Jakub Jelinek Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Aug 2021 06:35:23 -0000 On Wed, Aug 25, 2021 at 9:34 AM Uros Bizjak wrote: > > On Tue, Aug 24, 2021 at 4:57 PM H.J. Lu wrote: > > > > On Sun, Aug 15, 2021 at 11:11 PM Richard Biener > > wrote: > > > > > > On Fri, Aug 13, 2021 at 3:51 PM H.J. Lu wrote: > > > > > > > > and target("general-regs-only") function attribute > > > > were added to GCC 11. But their implementations are incomplete. I'd > > > > like to backport the following patches to GCC 11 branch to finish them. > > > > > > Fine with me if x86 maintainers do not disagree (also see one comment I have > > > on the -mwait adding patch). > > > > Hi Uros, Honza, > > > > Do you have any comments? The updated -mwait patch with LTO_minor_version > > bump is at: > > > > https://gcc.gnu.org/pipermail/gcc-patches/2021-August/577471.html > > I don't have any comments, but IIRC, approved changes can be > backported from mainline to release branches without additional > approval. If they fix regressions, yes. I understood this wasn't such obvious case here (instead it's a new but buggy feature). Richard. > Uros. > > > Thanks. > > > > H.J. > > > > H.J. Lu (5): > > > > x86: Add -mmwait for -mgeneral-regs-only > > > > x86: Use crc32 target option for CRC32 intrinsics > > > > x86: Remove OPTION_MASK_ISA_SSE4_2 from CRC32 _builtin functions > > > > x86: Enable the GPR only instructions for -mgeneral-regs-only > > > > : Add pragma GCC target("general-regs-only") > > > > > > > > gcc/common/config/i386/i386-common.c | 45 ++- > > > > gcc/config.gcc | 6 +- > > > > gcc/config/i386/i386-builtin.def | 8 +- > > > > gcc/config/i386/i386-builtins.c | 4 +- > > > > gcc/config/i386/i386-c.c | 2 + > > > > gcc/config/i386/i386-options.c | 12 + > > > > gcc/config/i386/i386.c | 6 +- > > > > gcc/config/i386/i386.h | 2 + > > > > gcc/config/i386/i386.md | 4 +- > > > > gcc/config/i386/i386.opt | 4 + > > > > gcc/config/i386/ia32intrin.h | 42 ++- > > > > gcc/config/i386/mwaitintrin.h | 52 +++ > > > > gcc/config/i386/pmmintrin.h | 13 +- > > > > gcc/config/i386/serializeintrin.h | 7 +- > > > > gcc/config/i386/sse.md | 4 +- > > > > gcc/config/i386/x86gprintrin.h | 13 + > > > > gcc/doc/extend.texi | 5 + > > > > gcc/doc/invoke.texi | 8 +- > > > > gcc/testsuite/gcc.target/i386/crc32-6.c | 13 + > > > > gcc/testsuite/gcc.target/i386/monitor-2.c | 27 ++ > > > > gcc/testsuite/gcc.target/i386/pr101492-1.c | 10 + > > > > gcc/testsuite/gcc.target/i386/pr101492-2.c | 10 + > > > > gcc/testsuite/gcc.target/i386/pr101492-3.c | 10 + > > > > gcc/testsuite/gcc.target/i386/pr101492-4.c | 12 + > > > > gcc/testsuite/gcc.target/i386/pr99744-3.c | 13 + > > > > gcc/testsuite/gcc.target/i386/pr99744-4.c | 357 +++++++++++++++++++++ > > > > gcc/testsuite/gcc.target/i386/pr99744-5.c | 25 ++ > > > > gcc/testsuite/gcc.target/i386/pr99744-6.c | 23 ++ > > > > gcc/testsuite/gcc.target/i386/pr99744-7.c | 12 + > > > > gcc/testsuite/gcc.target/i386/pr99744-8.c | 13 + > > > > 30 files changed, 717 insertions(+), 45 deletions(-) > > > > create mode 100644 gcc/config/i386/mwaitintrin.h > > > > create mode 100644 gcc/testsuite/gcc.target/i386/crc32-6.c > > > > create mode 100644 gcc/testsuite/gcc.target/i386/monitor-2.c > > > > create mode 100644 gcc/testsuite/gcc.target/i386/pr101492-1.c > > > > create mode 100644 gcc/testsuite/gcc.target/i386/pr101492-2.c > > > > create mode 100644 gcc/testsuite/gcc.target/i386/pr101492-3.c > > > > create mode 100644 gcc/testsuite/gcc.target/i386/pr101492-4.c > > > > create mode 100644 gcc/testsuite/gcc.target/i386/pr99744-3.c > > > > create mode 100644 gcc/testsuite/gcc.target/i386/pr99744-4.c > > > > create mode 100644 gcc/testsuite/gcc.target/i386/pr99744-5.c > > > > create mode 100644 gcc/testsuite/gcc.target/i386/pr99744-6.c > > > > create mode 100644 gcc/testsuite/gcc.target/i386/pr99744-7.c > > > > create mode 100644 gcc/testsuite/gcc.target/i386/pr99744-8.c > > > > > > > > -- > > > > 2.31.1 > > > > > > > > > > > > -- > > H.J.