From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14858 invoked by alias); 5 Nov 2015 13:49:03 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 14845 invoked by uid 89); 5 Nov 2015 13:49:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-yk0-f172.google.com Received: from mail-yk0-f172.google.com (HELO mail-yk0-f172.google.com) (209.85.160.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 05 Nov 2015 13:49:01 +0000 Received: by ykdr3 with SMTP id r3so130823215ykd.1 for ; Thu, 05 Nov 2015 05:48:59 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.129.13.215 with SMTP id 206mr7080989ywn.280.1446731339467; Thu, 05 Nov 2015 05:48:59 -0800 (PST) Received: by 10.37.93.11 with HTTP; Thu, 5 Nov 2015 05:48:59 -0800 (PST) In-Reply-To: <20151104165009.GB63428@kam.mff.cuni.cz> References: <20151014162944.GE16672@kam.mff.cuni.cz> <1502746.PVjyRxddou@polaris> <20151104072302.GA15669@kam.mff.cuni.cz> <4208196.7D90TBgezR@polaris> <20151104165009.GB63428@kam.mff.cuni.cz> Date: Thu, 05 Nov 2015 13:49:00 -0000 Message-ID: Subject: Re: Add VIEW_CONVERT_EXPR to operand_equal_p From: Richard Biener To: Jan Hubicka Cc: Eric Botcazou , GCC Patches , Andreas Schwab Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg00463.txt.bz2 On Wed, Nov 4, 2015 at 5:50 PM, Jan Hubicka wrote: >> > Are these supposed to be fixed by Richard's change to not use >> > useless_type_conversion for VCE, or is it another issue? >> >> Richard's change not to use useless_type_conversion for VCE was causing >> additional GIMPLE verification failures so I didn't pursue; I can try again, >> but all the known regressions are now fixed thanks to Richard's latest change >> to useless_type_conversion_p itself. > > I see, you re-instantiated the TYPE_CANONICAL check for aggregates instead. I > guess it is most practical way to go right now even though it would be really nice > to separate this from TBAA machinery. > At the moment LTO doesn't do globbing where calling conventions should care. > One such case is the globing of array containing char and char which is required > by Fortran standard, but that IMO is a defect in standard - if types are passed > differently by target ABI one can't expect them to be fuly interoperable as Fortran > would like. Note that I can't see how non-register type defs/uses will ever "change" their type during optimization so I think using TYPE_CANONICAL for the aggregate type case is fine. Richard. > Thank you very much for looking into this! > Honza >> >> -- >> Eric Botcazou