From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by sourceware.org (Postfix) with ESMTPS id A2AD03858CD1 for ; Fri, 8 Dec 2023 06:46:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A2AD03858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A2AD03858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702017979; cv=none; b=SlY8CMatgDpZVAUBYBPzRE8/+1di/2IgD2V4vfEz7UXvhF95dVXmnvjB6Fkn7Dc469TiQJvJBHKht/nCBlMFF0eJXYyAwu5RDOfcciCwJ7nA2X7pb2z6J2+EOVBBzXx63kWmHJUIQolE9G+WnbfN207sJAjEFtGC1G8w3rmk9nU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702017979; c=relaxed/simple; bh=BN2qlfy569qCAn+LGLq5cscp8FA60IV+bYG+xPsyIvA=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=QCL2zAdd35IyeSmCfzO1Qu7PEYYrRweX9T+j1kpG88A3vl6Z2qn23nliFr3ML0MSOx5CZnu93AggzvWXt3P/Yrft3BcN5nhHF9k9dJIxLhKgIk+nl5Rhjrd8ta4/6cArfZ74IITIP0lvhpQcD2dzE0Ml35wXBrYEE9o/L0TviA8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-50be10acaf9so1621558e87.1 for ; Thu, 07 Dec 2023 22:46:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702017975; x=1702622775; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5vdUJj4Ad1/BCTQedArD287p9czJwhelom4saC5cWlw=; b=cbrf8tNXi7UgAHRD0L2hTKNBVJ+0jKH5nVkaXN+bSMO6MKxpw2B3wNIoLrYyAOxj3X HPs3zAnolLz6+zkOKaOwKxjbU5tjFRDfmWz6HRCMY/yO1NA+P2qK9EFJ8T9Pp92TTXrx CWoxwf7GMye6IKZbYQxBSi9bM0zFAqjokdu0u/7ysEEzYnwit9xBPpKlmcLAApeDUutg QN/yS5ktGwhtgAVmg9MwtFalmiqyZ85S05nX7qEpEnQ1g6w6T+GTs2oAGO1S1ggkL1eF YD6LPdm/sN3TVejSedcv79YiA0d655cvtjy/3/EBznii1I/JXv/KwWxepFQH9Du7KXWR aoPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702017975; x=1702622775; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5vdUJj4Ad1/BCTQedArD287p9czJwhelom4saC5cWlw=; b=ZFWlWNhWFPfqFuBeGnxJA7C2tyIqYKZ6fRYKC8TrptKUzL966x0K3yhDwFJ7mPBjPo LZqnt98CwkV0iGPKpfudqn3oweXmlQuY2Iy1slqPNYggI//WTT7lKuledaCmt9P1iqGq BzI4ensxHZoD1lG44heaNdf+EMtNJjIw4I4OvO/UXyqLrvj6iBrBMSy1O9jQkG62CIzf nWvp0jGNNbjXvpar097P2O7KiIlQs+cQ5aK7QHUBEkEEPiNAIYxkAQaN/cSxFzv5wdEx rPodJq1laZwpACDrApN0hDT+ZSJb+zpvXOiJQEeQ4sh93E9g8Alk3qDEpWXe8km3tPV3 b33A== X-Gm-Message-State: AOJu0YzuYtVvMGWqbezMi/dDMiXonEWeUPGFtOryPYiGtDPpPfaUkB6S dpg5eD/Fj/QhDtW6Gbnvf2ZUs6CX1Wrs2DOuiys= X-Google-Smtp-Source: AGHT+IE+0P56YxElgEZHzFyrAb7xYkL3YQAoUGUjxsGk8WGJvjYPWeF1upLCI1bvHjP1E8aYAhCfJNXFofsLQi45gV4= X-Received: by 2002:a05:6512:2821:b0:50b:c0f1:f532 with SMTP id cf33-20020a056512282100b0050bc0f1f532mr251736lfb.26.1702017974672; Thu, 07 Dec 2023 22:46:14 -0800 (PST) MIME-Version: 1.0 References: <87lea7sh0h.fsf@euler.schwinge.homeip.net> <8734wet11e.fsf@euler.schwinge.homeip.net> In-Reply-To: From: Richard Biener Date: Fri, 8 Dec 2023 07:46:02 +0100 Message-ID: Subject: Re: [PATCH] To: Alexandre Oliva Cc: Thomas Schwinge , FX Coudert , Tobias Burnus , gcc-patches@gcc.gnu.org, Jeremy Bennett , Craig Blackmore , Graham Markall , Martin Jambor , Jan Hubicka , Jim Wilson , Jeff Law , Jakub Jelinek , Tom de Vries Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,WEIRD_PORT,WEIRD_QUOTING autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Dec 7, 2023 at 6:52=E2=80=AFPM Alexandre Oliva = wrote: > > On Dec 7, 2023, Thomas Schwinge wrote: > > > Thank you for looking into this so promptly! > > You're welcome ;-) > > > > during IPA pass: emutls > > [...]/source-gcc/gcc/testsuite/c-c++-common/strub-unsupported-3.c:1= 8:1: internal compiler error: in verify_curr_properties, at passes.cc:2198 > > Aah, this smells a lot like the issue that Fran=C3=A7ois-Xavier reported, > that the following patch is expected to fix. I'm still regstrapping it > on x86_64-linux-gnu, after checking that it addressed the symptom on a > cross compiler to the target for which it had originally been reported. > Ok to install, once you confirm that it cures these ICEs? > > > strub: skip emutls after strubm errors > > The emutls pass requires PROP_ssa, but if the strubm pass (or any > other pre-SSA pass) issues errors, all of the build_ssa_passes are > skipped, so the property is not set, but emutls still attempts to run, > on targets that use it, despite earlier errors, so it hits the > unsatisfied requirement. > > Adjust emutls to be skipped in case of earlier errors. OK. > > for gcc/ChangeLog > > * tree-emutls.cc: Include diagnostic-core.h. > (pass_ipa_lower_emutls::gate): Skip if errors were seen. > --- > gcc/tree-emutls.cc | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/gcc/tree-emutls.cc b/gcc/tree-emutls.cc > index 5dca5a8291356..38de202717a1a 100644 > --- a/gcc/tree-emutls.cc > +++ b/gcc/tree-emutls.cc > @@ -35,6 +35,7 @@ along with GCC; see the file COPYING3. If not see > #include "langhooks.h" > #include "tree-iterator.h" > #include "gimplify.h" > +#include "diagnostic-core.h" /* for seen_error */ > > /* Whenever a target does not support thread-local storage (TLS) nativel= y, > we can emulate it with some run-time support in libgcc. This will in > @@ -841,7 +842,7 @@ public: > bool gate (function *) final override > { > /* If the target supports TLS natively, we need do nothing here. = */ > - return !targetm.have_tls; > + return !targetm.have_tls && !seen_error (); > } > > unsigned int execute (function *) final override > > > -- > Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ > Free Software Activist GNU Toolchain Engineer > More tolerance and less prejudice are key for inclusion and diversity > Excluding neuro-others for not behaving ""normal"" is *not* inclusive