From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by sourceware.org (Postfix) with ESMTPS id 5A49E3858C39 for ; Mon, 18 Oct 2021 07:00:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5A49E3858C39 Received: by mail-ed1-x52d.google.com with SMTP id 5so36581821edw.7 for ; Mon, 18 Oct 2021 00:00:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Tux9vN6HiEePN+U/wWXit7TJegWS1PKTsF3mCkY6v1I=; b=BvMRJCkbQFAqyLO8dV4z1ILzrTf8md1tZbXJQWpI5VhJGeVM3By7e83LYSkos1eBQQ KmwE1BdGpD+nXzzI7l+KWRb+/AA+NHeiSiqzxCd4xr3gAUIBzV4d3jDX3vTiWPs/0Pu5 cRQpMwbRsUu9j012k/qV/a1/KAbSA7yoWw92yTwH5DbI0iwEaxOwWEQoO/vVbSjkVQu5 Zrf6lQyS1s6oeIghxrPRiQ3L8dpASNnGgPDWqo7H5cBmb0578sXUrO+GmNchXFjFZCx/ T8JprVax9xeX7/Yc2h9ZiayElH4/WDmSegIWCSYW8a1u1inR0z2r1CCw4UJDi7zRSDl3 jFVA== X-Gm-Message-State: AOAM532NG6HkQzg9gecOjGjrIDMaP6FiBlBMc+10cIfj3jSEwJy2+9Yr ulgCR+sEcfWfcCSwB0e7XZef1D6037CwnXdMw44= X-Google-Smtp-Source: ABdhPJzCy7/02YGnD/SkMA6q7sGt+OvpMolnf+BinyD1NsXoWie1WOiXMvhnBF7BjYKvsu6kuSuiZQ/1yXychwmWtEE= X-Received: by 2002:a17:907:6d82:: with SMTP id sb2mr21338749ejc.201.1634540443831; Mon, 18 Oct 2021 00:00:43 -0700 (PDT) MIME-Version: 1.0 References: <20211016193418.372265-1-hjl.tools@gmail.com> In-Reply-To: <20211016193418.372265-1-hjl.tools@gmail.com> From: Richard Biener Date: Mon, 18 Oct 2021 09:00:32 +0200 Message-ID: Subject: Re: [PATCH] Change set_ptr_nonull to set_ptr_nonnull in comments To: "H.J. Lu" Cc: GCC Patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2021 07:00:49 -0000 On Sat, Oct 16, 2021 at 9:35 PM H.J. Lu via Gcc-patches wrote: > > * value-query.cc (get_ssa_name_ptr_info_nonnull): Change > set_ptr_nonull to set_ptr_nonnull in comments. OK (but it's also obvious) > --- > gcc/value-query.cc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/value-query.cc b/gcc/value-query.cc > index ab133aab114..17ebd86ce5f 100644 > --- a/gcc/value-query.cc > +++ b/gcc/value-query.cc > @@ -296,7 +296,7 @@ get_ssa_name_ptr_info_nonnull (const_tree name) > return false; > /* TODO Now pt->null is conservatively set to true in PTA > analysis. vrp is the only pass (including ipa-vrp) > - that clears pt.null via set_ptr_nonull when it knows > + that clears pt.null via set_ptr_nonnull when it knows > for sure. PTA will preserves the pt.null value set by VRP. > > When PTA analysis is improved, pt.anything, pt.nonlocal > -- > 2.32.0 >