From: Richard Biener <richard.guenther@gmail.com>
To: "Kewen.Lin" <linkw@linux.ibm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
"H.J. Lu" <hjl.tools@gmail.com>,
Bill Schmidt <wschmidt@linux.ibm.com>,
Segher Boessenkool <segher@kernel.crashing.org>
Subject: Re: [PATCH] Fix PR94443 with gsi_insert_seq_before
Date: Fri, 3 Apr 2020 09:01:58 +0200 [thread overview]
Message-ID: <CAFiYyc3Faeo+zQ-XNVUw-NyU1PWLxfQSpJcWxUSPpJMsgtFyMw@mail.gmail.com> (raw)
In-Reply-To: <e6227dc6-439c-d232-2897-1ece5dc05a6f@linux.ibm.com>
On Thu, Apr 2, 2020 at 12:43 PM Kewen.Lin <linkw@linux.ibm.com> wrote:
>
> on 2020/4/2 上午6:51, H.J. Lu wrote:
> >
> > This caused:
> >
> > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94449
> >
>
> Thanks for reporting this. The attached patch is to fix the stupid
> mistake by using gsi_insert_seq_before instead of gsi_insert_before.
>
> BTW, the regression testing on one x86_64 machine from CFarm is
> unable to reveal it (I guess due to native arch sandybridge?), so I
> specified additional option -march=znver2 and verified the coverage.
>
> Bootstrapped/regtested on powerpc64le-linux-gnu (P9) and
> x86_64-pc-linux-gnu, also verified the fail cases in related PRs.
OK.
Richard.
>
> BR,
> Kewen
> -----------
> gcc/ChangeLog
>
> 2020-04-02 Kewen Lin <linkw@gcc.gnu.org>
>
> PR tree-optimization/94443
> * tree-vect-loop.c (vectorizable_live_operation): Use
> gsi_insert_seq_before to replace gsi_insert_before.
>
> gcc/testsuite/ChangeLog
>
> 2020-04-02 Kewen Lin <linkw@gcc.gnu.org>
>
> PR tree-optimization/94443
> * gcc.dg/vect/pr94443.c: New test.
>
prev parent reply other threads:[~2020-04-03 7:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 10:24 [PATCH] Fix PR94043 by making vect_live_op generate lc-phi Kewen.Lin
2020-03-30 10:38 ` Richard Biener
2020-04-01 22:51 ` H.J. Lu
2020-04-02 10:43 ` [PATCH] Fix PR94443 with gsi_insert_seq_before Kewen.Lin
2020-04-02 18:55 ` H.J. Lu
2020-04-03 7:01 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc3Faeo+zQ-XNVUw-NyU1PWLxfQSpJcWxUSPpJMsgtFyMw@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=linkw@linux.ibm.com \
--cc=segher@kernel.crashing.org \
--cc=wschmidt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).