From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by sourceware.org (Postfix) with ESMTPS id 40B9F3948A81 for ; Fri, 3 Apr 2020 07:02:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 40B9F3948A81 Received: by mail-lj1-x241.google.com with SMTP id r24so5874616ljd.4 for ; Fri, 03 Apr 2020 00:02:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=XjBMYt3nu/FbdGHOycR0Sbws/69y0xF94NGC4NMRV6I=; b=kjBRFfeWHK5VH5lyKXhYTqyoRCVFQ0447I7rgcIuzSaX0qtM1D73DUuCxy+Qi95Jr+ 946KKLZ2aSqmLkKTwZyEF6x9R/EjCeK6BRiSA3sideOG9twq+G80g6AbVqz2VFQCimH/ 7ZiRZNQTr8zuUWdp01MBSufA3nTdSk47TJgWj18H6JRCEtdtSMrYSkTkYOVxqR92QwIz Mt4RTX3pFoRWT2CKxIwOwJ9JnBjDNjEH9qFhQKhl8ItiQNYup0UepZS4xxJrTGRfmRLh BW2yLhA0734gTQKdxKSq67DRlTd1yWIwg/AAq7OyZodenWk/W6me7okaxuS/o50SpUoX 6vvg== X-Gm-Message-State: AGi0PubWkPGhSpoColesCalVO8LS31yDLq0ieh9YrzaCtM3dnAy1luAK wRSfHPkj5RKDAIY85D9DJpo5dn775WSGj1lNBzA= X-Google-Smtp-Source: APiQypIlcsmEhRBv8nHAnwVa8+l7xiUuD6/IppIMdNTPNlMDFlrkQuKcQ2AxJxu3G+6MQEbUQngHC44oqUurOswkvb0= X-Received: by 2002:a2e:9193:: with SMTP id f19mr3998060ljg.61.1585897330764; Fri, 03 Apr 2020 00:02:10 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Richard Biener Date: Fri, 3 Apr 2020 09:01:58 +0200 Message-ID: Subject: Re: [PATCH] Fix PR94443 with gsi_insert_seq_before To: "Kewen.Lin" Cc: GCC Patches , "H.J. Lu" , Bill Schmidt , Segher Boessenkool Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_2, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Apr 2020 07:02:13 -0000 On Thu, Apr 2, 2020 at 12:43 PM Kewen.Lin wrote: > > on 2020/4/2 =E4=B8=8A=E5=8D=886:51, H.J. Lu wrote: > > > > This caused: > > > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D94449 > > > > Thanks for reporting this. The attached patch is to fix the stupid > mistake by using gsi_insert_seq_before instead of gsi_insert_before. > > BTW, the regression testing on one x86_64 machine from CFarm is > unable to reveal it (I guess due to native arch sandybridge?), so I > specified additional option -march=3Dznver2 and verified the coverage. > > Bootstrapped/regtested on powerpc64le-linux-gnu (P9) and > x86_64-pc-linux-gnu, also verified the fail cases in related PRs. OK. Richard. > > BR, > Kewen > ----------- > gcc/ChangeLog > > 2020-04-02 Kewen Lin > > PR tree-optimization/94443 > * tree-vect-loop.c (vectorizable_live_operation): Use > gsi_insert_seq_before to replace gsi_insert_before. > > gcc/testsuite/ChangeLog > > 2020-04-02 Kewen Lin > > PR tree-optimization/94443 > * gcc.dg/vect/pr94443.c: New test. >