From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by sourceware.org (Postfix) with ESMTPS id 74E043858C27 for ; Wed, 13 Oct 2021 11:49:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 74E043858C27 Received: by mail-ed1-x52a.google.com with SMTP id y12so9104537eda.4 for ; Wed, 13 Oct 2021 04:49:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=UvE2J5v1j+BylsijjPn+VEV0T4Qd/Ar+D6GLZlcDy68=; b=InQZhfigaDoRxZVLngLWaRd2sXOEEi/6UvF4TtsH9sjn13xdiygZJ9zuBGj6Si8qZA 4VQJ8qrG6d917831H9hUBK+k/v0ek2dLsMSJw6h5iiCtb0FlKgRz3uC+B+iUWgWchlFF dojDR9h1q0ofWWsmOuJHhceMtxjwGkKqQBl/TUvdY1W/MRWDzBTpYSYy3ccWk5kMEs4Y jG00AhpGilqL8TSNUqgoU/47HpnBEziZYmWDI+CsifegYrGvXijTJ3AXgvbWehz5pgoC VlUjjZhrozk6IwUdV58/QZUXonGa6bZB5RJvcD/cg2CLaEFkSFjfn4qJND4TYWOZFOu3 Ki5g== X-Gm-Message-State: AOAM5311CaR+zMqy8j6FCIJPY/eWMpTLwkDCJ1yPw3FDk/DH487FoVdc /5n88/FONX5n3gmarlY/HHftTRVN06/xPlfhJD0= X-Google-Smtp-Source: ABdhPJzkZj/Oc1SLD2GaFmKMEF76i6Nj8Xg8vFN55H+dY7HYIZREgpLlVdksnhkI4PbnotoBzZxOi88EqXliA5kZdL8= X-Received: by 2002:aa7:c78f:: with SMTP id n15mr9195871eds.338.1634125785452; Wed, 13 Oct 2021 04:49:45 -0700 (PDT) MIME-Version: 1.0 References: <12fd0c18-79e0-d20d-2973-92639071c050@suse.cz> In-Reply-To: From: Richard Biener Date: Wed, 13 Oct 2021 13:49:33 +0200 Message-ID: Subject: Re: [PATCH] Fix handling of flag_rename_registers. To: =?UTF-8?Q?Martin_Li=C5=A1ka?= Cc: "Joseph S. Myers" , GCC Patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Oct 2021 11:49:47 -0000 On Wed, Oct 13, 2021 at 12:02 PM Martin Li=C5=A1ka wrote: > > On 10/13/21 10:39, Richard Biener wrote: > > On Tue, Oct 12, 2021 at 5:11 PM Martin Li=C5=A1ka wrot= e: > >> > >> On 10/12/21 15:37, Richard Biener wrote: > >>> by adding EnabledBy(funroll-loops) to the respective options instead > >>> (and funroll-loops EnabledBy(funroll-all-loops)) > >> > >> All right, so the suggested approach works correctly. > >> > >> Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > >> > >> Ready to be installed? > > > > funroll-all-loops > > -Common Var(flag_unroll_all_loops) Optimization > > +Common Var(flag_unroll_all_loops) Optimization EnabledBy(funroll-all-l= oops) > > > > that should be on funroll-loops? > > Yeah, what a stupid error. > > > > > Can you verify that the two-step -funroll-all-loops -> -funroll-loops > > -> -frename-registers > > Yes, verified that in debugger, it's not dependent on an ordering. > > > works and that it is not somehow dependent on ordering? Otherwise we h= ave to > > use EnabledBy(funroll-loops,funroll-all-loops) on frename-registers. > > I guess the > > EnabledBy doesn't work if the target decides to set flag_unroll_loop in= one of > > its hooks rather than via its option table override? (as said, this > > is all a mess...) > > It's a complete mess. The only override happens in > rs6000_override_options_after_change. I think it can also utilize Enabled= By, but > I would like to do it in a different patch. > > > > > But grep should be your friend telling whether any target overrides > > any of the flags... > > > > I do hope we can eventually reduce the number of pre-/post-/lang/target= /common > > processing phases for options :/ Meh. > > Huh. > > May I install this fixed patch once it's tested? Yes please. Thanks, Richard. > Martin > > > > > Richard. > > > >> Thanks, > >> Martin >