From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by sourceware.org (Postfix) with ESMTPS id 46BFD3858D32 for ; Wed, 19 Jul 2023 08:15:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 46BFD3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2b701e1ca63so102325861fa.1 for ; Wed, 19 Jul 2023 01:15:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689754511; x=1692346511; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xzKQjlOy7OhxKYEtdqtseKmuOxjKfQ8w+3a6bvqCt3A=; b=Q3WzZfQonCkgksTi6MMpoDXfpC7HeiWNjLrYzMYnl4gpnPoeLg57dlytZtAh4InQxj Qf8D4Y0ZrSdAMqMTo8c57SPQmidKYjf40IQnVJds0fdHSVV1p5KNO2B9JivXCYLsXPS1 pd/uyV1ViqY5dyLs8DxXEMJs/M2jH+EARacC0ITG4uVAfAnGLBbSygYhdEB+PQNyItZQ HquWIbwsZ1kdCQU/Eo5cSwRWAT5ncyJV+OEnaRTGFD70ald3dENAw1t8W4MOUeEG+WTV bY3azVFIQIvyLi2HzXy94ETU6Km4pd2jkTwWErLkrEAC6GqWUyuHCZqpBgCg1IqENdRR S5Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689754511; x=1692346511; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xzKQjlOy7OhxKYEtdqtseKmuOxjKfQ8w+3a6bvqCt3A=; b=dBVD4RCsSFZY7b7cqkd1uA7+VUDGCWAHhqAtFZENKHlKAl61L8SqPvrM8z7rw9DFJX 6hwBZmjn5AEmjzpkMkm1GPlLcmO0rvon2i/eAIqdzLH/3rvYoejrMXliMy91lp6v2ChA qFkSJUnNt47dd1bBx9NHPFeNo7c7WGXMl2Znn1At977lLDq7Jd8GFLqFVm9PwB6+NpyC TOKHrhWWmJKeu7YR7PgV1FUKvhJbox96kCU+nRPJQf/tgPfrFx/aD8atuzr19RseyGBJ jbnh+tfPjuTxDXbEELvjmLddOJUp6WOCsCTN1NfTzuKvf9zh41MxODFrzwmkC7rO90Go Tr9g== X-Gm-Message-State: ABy/qLb7uWuvzxUV1j9n5EWM0TRtA76uPHcbVbvQKX0P5ug6D5FXZ/Ye z0YWBZOg8M4ujYpNjDvYjDZR73Z0GwZrqRaKBRg= X-Google-Smtp-Source: APBJJlERQ8BlpLNZ9maovqgFhntpx0IVeiBNwNyDAhrryUBlXzOMCyYJkZAwxyGYGsC31Rr6zAprXcivvmPpT3fanhk= X-Received: by 2002:a2e:97cb:0:b0:2b6:fca2:fc6e with SMTP id m11-20020a2e97cb000000b002b6fca2fc6emr1233395ljj.42.1689754511117; Wed, 19 Jul 2023 01:15:11 -0700 (PDT) MIME-Version: 1.0 References: <20230719015221.1383859-1-apinski@marvell.com> In-Reply-To: From: Richard Biener Date: Wed, 19 Jul 2023 10:14:38 +0200 Message-ID: Subject: Re: [PATCH] Fix PR110726: a | (a == b) can sometimes produce wrong code To: Andrew Pinski Cc: Andrew Pinski , gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Jul 19, 2023 at 9:32=E2=80=AFAM Andrew Pinski w= rote: > > On Wed, Jul 19, 2023 at 12:16=E2=80=AFAM Richard Biener via Gcc-patches > wrote: > > > > On Wed, Jul 19, 2023 at 3:53=E2=80=AFAM Andrew Pinski via Gcc-patches > > wrote: > > > > > > So I had missed/forgot that EQ_EXPR could have an non boolean > > > type for generic when I implemented r14-2556-g0407ae8a7732d9. > > > This patch adds check for one bit precision intergal type > > > which fixes the problem. > > > > > > OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions. > > > > > > PR tree-optimization/110726 > > > > > > gcc/ChangeLog: > > > > > > * match.pd ((a|b)&(a=3D=3Db),a|(a=3D=3Db),(a&b)|(a=3D=3Db)): > > > Add checks to make sure the type was one bit precision > > > intergal type. > > > > > > gcc/testsuite/ChangeLog: > > > > > > * gcc.c-torture/execute/bitops-1.c: New test. > > > --- > > > gcc/match.pd | 12 +++++-- > > > .../gcc.c-torture/execute/bitops-1.c | 33 +++++++++++++++++= ++ > > > 2 files changed, 42 insertions(+), 3 deletions(-) > > > create mode 100644 gcc/testsuite/gcc.c-torture/execute/bitops-1.c > > > > > > diff --git a/gcc/match.pd b/gcc/match.pd > > > index 054e6585876..4dfe92623f7 100644 > > > --- a/gcc/match.pd > > > +++ b/gcc/match.pd > > > @@ -1229,7 +1229,9 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) > > > /* (a | b) & (a =3D=3D b) --> a & b (boolean version of the above)= . */ > > > (simplify > > > (bit_and:c (bit_ior @0 @1) (nop_convert? (eq:c @0 @1))) > > > - (bit_and @0 @1)) > > > + (if (INTEGRAL_TYPE_P (TREE_TYPE (@0)) > > > > that's really a constraint on 'type', not sure if it would be clearer > > to test that. > > What's the nop_convert you've seen in practice here? With integer comp= arison > > result shouldn't those be convert? instead? > > The case were nop_convert happen would happen is: > ``` > struct f > { > signed a:1; > signed b:1; > signed c:1; > }; > > void f(struct f t, struct f *t1) > { > t.c =3D (t.a =3D=3D t.b); > t1->c =3D (t.a | t.b) & t.c; > } > ``` > I know the above does not show up much but it definitely can show up. > > In the testcase in the bug report the EQ_EXPR didn't have convert > around it but the type was just changed to be the long type and we > cannot treat the `a =3D=3D b` similar as `~(a^b)` which is only works for > 1 bit integers (unsigned or signed). I see, the patch is OK then. Thanks, Richard. > Thanks, > Andrew Pinski > > > > > > + && TYPE_PRECISION (TREE_TYPE (@0)) =3D=3D 1) > > > + (bit_and @0 @1))) > > > > > > /* a | ~(a ^ b) --> a | ~b */ > > > (simplify > > > @@ -1239,7 +1241,9 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) > > > /* a | (a =3D=3D b) --> a | (b^1) (boolean version of the above). = */ > > > (simplify > > > (bit_ior:c @0 (nop_convert? (eq:c @0 @1))) > > > - (bit_ior @0 (bit_xor @1 { build_one_cst (type); }))) > > > + (if (INTEGRAL_TYPE_P (TREE_TYPE (@0)) > > > + && TYPE_PRECISION (TREE_TYPE (@0)) =3D=3D 1) > > > + (bit_ior @0 (bit_xor @1 { build_one_cst (type); })))) > > > > > > /* (a | b) | (a &^ b) --> a | b */ > > > (for op (bit_and bit_xor) > > > @@ -1255,7 +1259,9 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) > > > /* (a & b) | (a =3D=3D b) --> a =3D=3D b */ > > > (simplify > > > (bit_ior:c (bit_and:c @0 @1) (nop_convert?@2 (eq @0 @1))) > > > - @2) > > > + (if (INTEGRAL_TYPE_P (TREE_TYPE (@0)) > > > + && TYPE_PRECISION (TREE_TYPE (@0)) =3D=3D 1) > > > + @2)) > > > > > > /* ~(~a & b) --> a | ~b */ > > > (simplify > > > diff --git a/gcc/testsuite/gcc.c-torture/execute/bitops-1.c b/gcc/tes= tsuite/gcc.c-torture/execute/bitops-1.c > > > new file mode 100644 > > > index 00000000000..cfaa6b9fd26 > > > --- /dev/null > > > +++ b/gcc/testsuite/gcc.c-torture/execute/bitops-1.c > > > @@ -0,0 +1,33 @@ > > > +/* PR tree-optimization/110726 */ > > > + > > > +#define DECLS(n,VOL) \ > > > +__attribute__((noinline,noclone)) \ > > > +int h##n(VOL int A, VOL int B){ \ > > > + return (A | B) & (A =3D=3D B); \ > > > +} \ > > > +__attribute__((noinline,noclone)) \ > > > +int i##n(VOL int A, VOL int B){ \ > > > + return A | (A =3D=3D B); \ > > > +} \ > > > +__attribute__((noinline,noclone)) \ > > > +int k##n(VOL int A, VOL int B){ \ > > > + return (A & B) | (A =3D=3D B); \ > > > +} \ > > > + > > > +DECLS(0,) > > > +DECLS(1,volatile) > > > + > > > +int values[] =3D { 0, 1, 2, 3, -1, -2, -3, 0x10080 }; > > > +int numvalues =3D sizeof(values)/sizeof(values[0]); > > > + > > > +int main(){ > > > + for(int A =3D 0; A < numvalues; A++) > > > + for(int B =3D 0; B < numvalues; B++) > > > + { > > > + int a =3D values[A]; > > > + int b =3D values[B]; > > > + if (h0 (a, b) !=3D h1 (a, b)) __builtin_abort(); > > > + if (i0 (a, b) !=3D i1 (a, b)) __builtin_abort(); > > > + if (k0 (a, b) !=3D k1 (a, b)) __builtin_abort(); > > > + } > > > +} > > > -- > > > 2.31.1 > > >