From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118723 invoked by alias); 25 Mar 2015 10:20:22 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 118708 invoked by uid 89); 25 Mar 2015 10:20:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KAM_FROM_URIBL_PCCC,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 X-HELO: mail-oi0-f50.google.com Received: from mail-oi0-f50.google.com (HELO mail-oi0-f50.google.com) (209.85.218.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 25 Mar 2015 10:20:21 +0000 Received: by oifl3 with SMTP id l3so17387350oif.0 for ; Wed, 25 Mar 2015 03:20:19 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.202.187.5 with SMTP id l5mr6353923oif.51.1427278819365; Wed, 25 Mar 2015 03:20:19 -0700 (PDT) Received: by 10.76.98.137 with HTTP; Wed, 25 Mar 2015 03:20:19 -0700 (PDT) In-Reply-To: <20150325101133.GM1746@tucnak.redhat.com> References: <20150312100931.GK27860@msticlxl57.ims.intel.com> <20150319082944.GC64546@msticlxl57.ims.intel.com> <20150324083325.GC1746@tucnak.redhat.com> <20150324140619.GE1746@tucnak.redhat.com> <20150325095041.GL1746@tucnak.redhat.com> <20150325101133.GM1746@tucnak.redhat.com> Date: Wed, 25 Mar 2015 10:20:00 -0000 Message-ID: Subject: Re: [CHKP, PATCH] Fix instrumented indirect calls with propagated pointers From: Richard Biener To: Jakub Jelinek Cc: Ilya Enkovich , gcc-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg01290.txt.bz2 On Wed, Mar 25, 2015 at 11:11 AM, Jakub Jelinek wrote: > On Wed, Mar 25, 2015 at 01:06:46PM +0300, Ilya Enkovich wrote: >> > There is still the wasteful pass_fixup_cfg at the start of: >> > PUSH_INSERT_PASSES_WITHIN (pass_local_optimization_passes) >> > NEXT_PASS (pass_fixup_cfg); >> > which wasn't there before chkp. Perhaps this should be a different >> > pass with the same execute method, but gate containing >> > flag_check_pointer_bounds? >> >> IIRC the reason for this pass was a different passes split, not >> instrumentation itself. Previously function processing always started >> with pass_fixup_cfg. Splitting processing into three stages we got >> three pass_fixup_cfg passes. > > Sure, but it would be really nice if for !flag_check_pointer_bounds > we really could have just one stage again, rather than 3. > When it is a global option, and for LTO ideally ored in from all the TUs, > that shouldn't be that hard... LTO doesn't even run all this stuff at it only runs before LTO streaming. I don't think we want to go back to not going into SSA for all functions before early-opts (esp. early inlining). Which unfortunately won't get the EH cleanup related benefits. Btw, execute_fixup_cfg can be optimized as well - edge purging only needs to be done for the last stmt of a BB. Richard. > Jakub