From: Richard Biener <richard.guenther@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Uros Bizjak <ubizjak@gmail.com>, Jan Hubicka <jh@suse.cz>,
Richard Biener <rguenther@suse.de>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] x86: Make stringop_algs::stringop_strategy ctor constexpr [PR100246]
Date: Fri, 5 Nov 2021 11:33:06 +0100 [thread overview]
Message-ID: <CAFiYyc3GyTWp7BC6aA25f7eUwXQJHYDkqouAKr3PiMqd-1BfMw@mail.gmail.com> (raw)
In-Reply-To: <20211105095831.GH304296@tucnak>
On Fri, Nov 5, 2021 at 10:59 AM Jakub Jelinek via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> On Thu, Nov 04, 2021 at 01:45:38PM +0100, Jakub Jelinek via Gcc-patches wrote:
> > On Thu, Nov 04, 2021 at 12:39:34PM +0000, Iain Sandoe wrote:
> > > Bootstrap succeeded with Apple clang-503.0.40 (Xcode 5.1.1) on macOS 10.8
> > > which is the earliest version I expect to work (previous xcode impl. have more
> > > C++11 incompatibilities). So OK from a Darwin PoV.
> > >
> > > The other reported toolchain with the issue was GCC-4.9.2 as discussed on
> > > IRC - this also seems OK.
> >
> > > > Especially because 11.x is not going to have the dyninit optimization for
> > > > sure, it would be nice to do this on the 11 branch too.
>
> Bootstrapped/regtested on x86_64-linux and i686-linux successfully too, with
> sligtly different formatting, as I think in our coding style constexpr
> should go on the previous line and the ctor didn't have space before (.
>
> Ok for trunk and 11.3?
OK.
> 2021-11-05 Jakub Jelinek <jakub@redhat.com>
>
> PR bootstrap/100246
> * config/i386/i386.h
> (stringop_algs::stringop_strategy::stringop_strategy): Make the ctor
> constexpr.
>
> --- gcc/config/i386/i386.h.jj 2021-09-28 23:18:35.282563395 +0200
> +++ gcc/config/i386/i386.h 2021-11-04 10:48:47.165086806 +0100
> @@ -78,8 +78,9 @@ struct stringop_algs
> this issue. Since this header is used by code compiled with the C
> compiler we must guard the addition. */
> #ifdef __cplusplus
> - stringop_strategy(int _max = -1, enum stringop_alg _alg = libcall,
> - int _noalign = false)
> + constexpr
> + stringop_strategy (int _max = -1, enum stringop_alg _alg = libcall,
> + int _noalign = false)
> : max (_max), alg (_alg), noalign (_noalign) {}
> #endif
> const int max;
>
>
> Jakub
>
prev parent reply other threads:[~2021-11-05 10:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-04 20:03 [PATCH] X86: Provide a CTOR for stringop_algs [PR100246] Iain Sandoe
2021-07-05 10:50 ` Richard Biener
2021-07-05 13:04 ` Iain Sandoe
2021-07-05 13:23 ` Richard Biener
2021-07-06 10:17 ` Iain Sandoe
2021-11-04 10:05 ` [PATCH] x86: Make stringop_algs::stringop_strategy ctor constexpr [PR100246] Jakub Jelinek
2021-11-04 12:39 ` Iain Sandoe
2021-11-04 12:45 ` Jakub Jelinek
2021-11-05 9:58 ` Jakub Jelinek
2021-11-05 10:33 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc3GyTWp7BC6aA25f7eUwXQJHYDkqouAKr3PiMqd-1BfMw@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jh@suse.cz \
--cc=rguenther@suse.de \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).