From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by sourceware.org (Postfix) with ESMTPS id CBA9C3858439 for ; Wed, 20 Dec 2023 07:40:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CBA9C3858439 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CBA9C3858439 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::235 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703058050; cv=none; b=efPe3SSLGdG0JJ2pCeI4k6WN5fP3cFb8MAgUpmnl0/CWsDLy8CTb7L+D7sXkbNuJQIGFC4zUy5T0SHpw8SffEuegm8V8Cp/9d00w1ktMv5wZ47KydE9D24/1RIeZXnOIr7ulfKPX074B3xeDPzSCLhw7xKwCSQ2YFyJPvHQELso= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703058050; c=relaxed/simple; bh=w0I4+BYE53yIVhAolr1giLGWJnlDWXOwtt1LWM/6494=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=aQHBFkRpDndpMiQcn3birg3700qiAuxCjHJcLncWqcP0mgrVDCdbBAudepnhXUgrVb+Q0R/1g9QETJKbi3sq8Pf6DjuPTGHqzXUPM49h68HZCdSBokZexFMjJCXLlkJE9elc/KLgp7XKBUxYKo2uLeLMlLPqaRv/SL4JHVUu/9g= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2cc843af59fso17221861fa.0 for ; Tue, 19 Dec 2023 23:40:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703058047; x=1703662847; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ecprwNzfmIVycbv4aYqOCWQe7c17MxGIF7O/gVrTvww=; b=CxRj0KDGBwhAROfwZp8Jj1s0npist8XO5W12maonHzYaDMzFJdfnr4pZxTsknWfRI0 uXkH2/A1TKtXISgAdlQ9zfhdEB/y4s7TAT1eiIO4A7FMeo9E6S7ZpFXH6k/sHbtwRhgw G4q/V7dY1HRVj6MuiglIYjHPU+OdubTzEttIsGBYdRoQy6GecHZbRbnrPvCE0dGtYaoZ yiz2tXY/KchM13Wn18o+tA4+bAr6tIKnx9fLdtUsLdCA4yKZf3kU1mWLHTDShsOdiyeo KaY389eFN0AV2t4mD2zWv3eDCqlu096gzzH5gwxMcP8m0mhizUZyN5rdcVxRiBiJi+GB YPgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703058047; x=1703662847; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ecprwNzfmIVycbv4aYqOCWQe7c17MxGIF7O/gVrTvww=; b=XXLKcG9WYBH2F1rrauQPsseR4ZPT1n7BaJj1XKmrGQETOYmZ7FnrwBr8s6rn8FxZms QXOKM0SgUGteqm6ihu1x0hYtJjXSEgcxlXU08ABVNLsSIH+J1YV8/PwBibwSyYSaaY6O BYgsvxtAmOokMAXBxz0OTM7RNnsV8Tz1GqQLk+OjE8AYQIfRu3gRTZ9BZNNnVJKTBP/4 zxYVZR8ELZLWRFWHoaBXTvjQk6lbGBqhpYv1C++UBDOdLADdBpfZWU29GxFAZ4NYXxmw Usj3v1/i7gV/oCzSA5uzD5guo1K6Q/u0vBocGNW3QWV/IRayxefygUaNlnBnajuuOJOl w6Dg== X-Gm-Message-State: AOJu0YyGv5j2ec+sTcCS90NryDFY18ltnMcqt+gM0ZD8vAA30ktJeU+5 3RjdfSrVhOYpVULzcFrTi8ivgNxXVj2pexAc4YI= X-Google-Smtp-Source: AGHT+IGlvG86KepHehI9aQmJdkk5YFQ1vIhaVoekDSmoZtLhsM9/8ojul0HClmQGWxeA5LYco3HYT+Q68tzkVLwzlKc= X-Received: by 2002:a2e:92d0:0:b0:2cc:7598:ef22 with SMTP id k16-20020a2e92d0000000b002cc7598ef22mr2076945ljh.61.1703058046935; Tue, 19 Dec 2023 23:40:46 -0800 (PST) MIME-Version: 1.0 References: <20231212030031.1023808-1-jason@redhat.com> <2bfeed48-e237-4dcb-802e-1acc111ff69b@redhat.com> In-Reply-To: <2bfeed48-e237-4dcb-802e-1acc111ff69b@redhat.com> From: Richard Biener Date: Wed, 20 Dec 2023 08:39:23 +0100 Message-ID: Subject: Re: Ping Re: [PATCH] contrib: add git gcc-style alias To: Jason Merrill Cc: gcc-patches@gcc.gnu.org, Alexandre Oliva Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Dec 19, 2023 at 6:41=E2=80=AFPM Jason Merrill wr= ote: > > On 12/11/23 22:00, Jason Merrill wrote: > > OK for trunk? > > Ping. CCing Alex because this could plausibly be considered build > machinery, and he's had useful feedback on my sh code before. OK in case Alex doesn't have any comments. Btw, is there a webpage where we document our git plumbing? Would be nice to update that with the new alias. Richard. > > -- 8< -- > > > > I thought it could be easier to use check_GNU_style.py. With this alia= s, > > 'git gcc-style' will take a git revision as argument instead of a file,= or > > check HEAD if no argument is given. > > > > contrib/ChangeLog: > > > > * gcc-git-customization.sh: Add git gcc-style alias. > > --- > > contrib/gcc-git-customization.sh | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/contrib/gcc-git-customization.sh b/contrib/gcc-git-customi= zation.sh > > index 2e173e859d7..54bd35ea1aa 100755 > > --- a/contrib/gcc-git-customization.sh > > +++ b/contrib/gcc-git-customization.sh > > @@ -30,6 +30,11 @@ git config alias.gcc-backport '!f() { "`git rev-pars= e --show-toplevel`/contrib/g > > git config alias.gcc-fix-changelog '!f() { "`git rev-parse --show-top= level`/contrib/git-fix-changelog.py" $@; } ; f' > > git config alias.gcc-mklog '!f() { "`git rev-parse --show-toplevel`/c= ontrib/mklog.py" $@; } ; f' > > git config alias.gcc-commit-mklog '!f() { "`git rev-parse --show-topl= evel`/contrib/git-commit-mklog.py" "$@"; }; f' > > +git config alias.gcc-style '!f() { > > + check=3D`git rev-parse --show-toplevel`/contrib/check_GNU_style.py= ; > > + arg=3D; if [ $# -ge 1 ] && [ "$1" !=3D "-f" ]; then arg=3D"$1"; sh= ift; > > + elif [ $# -eq 3 ]; then arg=3D"$3"; set -- "$1" "$2"; fi > > + git show $arg | $check "$@" -; }; f' > > > > # Make diff on MD files use "(define" as a function marker. > > # Use this in conjunction with a .gitattributes file containing > > > > base-commit: 074c6f15f7a28c620c756f18c2a310961de00539 >