From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16149 invoked by alias); 15 Sep 2014 09:32:34 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 16140 invoked by uid 89); 15 Sep 2014 09:32:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wg0-f52.google.com Received: from mail-wg0-f52.google.com (HELO mail-wg0-f52.google.com) (74.125.82.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 15 Sep 2014 09:32:30 +0000 Received: by mail-wg0-f52.google.com with SMTP id x13so3560033wgg.23 for ; Mon, 15 Sep 2014 02:32:20 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.194.186.178 with SMTP id fl18mr31696558wjc.8.1410773540009; Mon, 15 Sep 2014 02:32:20 -0700 (PDT) Received: by 10.194.20.69 with HTTP; Mon, 15 Sep 2014 02:32:19 -0700 (PDT) In-Reply-To: <5413291A.7050209@redhat.com> References: <53FD45A7.4000804@redhat.com> <53FF6840.9030505@redhat.com> <53FF6E61.6030507@redhat.com> <540755E5.7060602@redhat.com> <5409220E.6070100@redhat.com> <540E4337.70006@redhat.com> <5412438A.6030305@redhat.com> <54130E15.9030809@redhat.com> <5413291A.7050209@redhat.com> Date: Mon, 15 Sep 2014 09:32:00 -0000 Message-ID: Subject: Re: [debug-early] reuse variable DIEs and fix their context From: Richard Biener To: Aldy Hernandez Cc: Jason Merrill , gcc-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg01168.txt.bz2 On Fri, Sep 12, 2014 at 7:10 PM, Aldy Hernandez wrote: > On 09/12/14 08:15, Jason Merrill wrote: >> >> On 09/11/2014 08:51 PM, Aldy Hernandez wrote: >>> >>> - timevar_start (TV_PHASE_DEFERRED); >> >> >>> - timevar_stop (TV_PHASE_DEFERRED); >>> - timevar_start (TV_PHASE_OPT_GEN); >> >> >> Why? > > > TV_PHASE_OPT_GEN is now in compile_file(), where we call > finalize_compilation_unit directly. > > TV_PHASE_DEFERRED, on the other hand, is a bit problematic because it was > originally wrapping the code inside LANG_HOOKS_WRITE_GLOBALS, which will now > reside inside the parser (and is thus included in TV_PHASE_PARSING now). > Originally it was mutually exclusive with TV_PHASE_PARSING, but now resides > within the parser, so I decided to get rid of it since it's all technically > in the parser. > > There is code in timevar*.c that makes sure that TV_PHASE_* elapsed times > add up to the total time. So we either get rid of TV_PHASE_DEFERRED and > include its time in TV_PHASE_PARSING (avoiding double counting), or we > include a separate, non PHASE timer for it, with timevar_push(TV_blah) where > "blah" is NOT "PHASE". > > Up to you, but I'm highly in favor of getting rid of things ;-). > >> >>> /* Generate hidden aliases for Java. */ >>> - if (candidates) >>> + if (java_hidden_aliases) >>> { >>> - build_java_method_aliases (candidates); >>> - delete candidates; >>> + build_java_method_aliases (java_hidden_aliases); >>> + delete java_hidden_aliases; >>> } >> >> >> Didn't it work to move this before finalize? I think the VTV stuff is >> all that really needs to come after it, and that can move out of the >> front end if this hook is a problem (which I don't really think it is). > > > I was too chicken to try. I will do so as a follow up. Didn't work in the past btw - I've tried it once or twice. Btw, if the VTV stuff really needs to come afterwards how does VTV work with LTO then? Eventually the VTV stuff can be integrated with the cgraph instead. Richard. > I am committing the patch to the branch, and will address both issues you > speak of in followups. Let me know what you prefer for the timevar issue. > > Thanks. > Aldy >