From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by sourceware.org (Postfix) with ESMTPS id 36B1C3858D20 for ; Tue, 22 Nov 2022 11:23:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 36B1C3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-x134.google.com with SMTP id g7so23124019lfv.5 for ; Tue, 22 Nov 2022 03:23:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=KiVhId0Pf5FTEZfm+8QmBKehxHGM7M/GtMIBaV8EXlQ=; b=j4xuT/gPsxUqDhUlpjWzE1tpOzcIfZWVXmQsCQ8Fr30fGT99KmKd7HvCN1aiYV35Ow uQqkzcPK7T6/2PcvkmDsQfQOqJq7dioIu2JiMGuEphu/luCn4PcVyX0FBxJvB99v99d3 0dGn/9cq5LqchO69I9lOY6s8WzsVVWZtn+oJ3vKcgHaCwEgIhfy4BWlLZcYJmyaYmfZg 38ia1yh0JKXYpzjY6Ac32D5IBjQR2DfnKBhEuGpY90fg5apksZmqfgAgrFuEzMAwBona JREHCdIzx/CRZjR+NMMPIXnloICiswQ/jvDtQJ1AFWEEGi+EQfQIRWXMN0rHOVWFLvoN JUvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KiVhId0Pf5FTEZfm+8QmBKehxHGM7M/GtMIBaV8EXlQ=; b=PKexPs3gpNtu5qBwEbx+LDPc7toooGc2IwLr+tt83COfPjVPVyQpZIK7H+OjCHqn24 lIDaWvGDzyVY0AwkyEKEaDKz0axJ3m1RRMHoe9maEUIa/r5uywDU69xmRAd6q1xg+4r8 O8S5kzkpwpkmV+Jk+iR+mkTV5PIpEHHCaww6EQwIhDtlua2Een5PugcsuFrmhR0/Ws+6 S3awsv3dSGmFOh8Oog2BaJH4t5aLHQsXlqjp7z0J4M874sl4x0yRi9AC24+GK1J4ITim 2Z0bESDJcW0iQCUUt25wifwwayGoeTT34BPWCJZEiWsOgBeJuKIFh0GAhpnzUbAZ3l2y gpbw== X-Gm-Message-State: ANoB5pmLEwRSBxIedA/cof8Q4hJozyId5KLXzZXZocHyUxzOiskNcGh6 2G0Ac+jjX4nf+/dEOw9J9Hx8veKn79mLaFt1GCA= X-Google-Smtp-Source: AA0mqf5OicAwnzFz1IYD4J+2riJEpawGrXJ/ATSJu86I5f3beLj5hOKmKjSQ5ljzciKTkWiqk7SZ2vwVKE45suQj9Cc= X-Received: by 2002:a05:6512:3d10:b0:4b4:1177:a64c with SMTP id d16-20020a0565123d1000b004b41177a64cmr8700759lfv.647.1669116186599; Tue, 22 Nov 2022 03:23:06 -0800 (PST) MIME-Version: 1.0 References: <4442231.LvFx2qVVIh@fomalhaut> In-Reply-To: <4442231.LvFx2qVVIh@fomalhaut> From: Richard Biener Date: Tue, 22 Nov 2022 12:22:53 +0100 Message-ID: Subject: Re: [PATCH] Fix wrong array type conversion with different storage order To: Eric Botcazou Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Nov 22, 2022 at 12:06 PM Eric Botcazou via Gcc-patches wrote: > > Hi, > > when two arrays of scalars have a different storage order in Ada, the > front-end makes sure that the conversion is performed component-wise > so that each component can be reversed. So it's a little bit counter > productive that the ldist pass performs the opposite transformation > and synthesizes a memcpy/memmove in this case. > > Tested on x86-64/Linux, OK for the mainline? OK for trunk and branches. Richard. > > 2022-11-22 Eric Botcazou > > * tree-loop-distribution.cc (loop_distribution::classify_builtin_ldst): > Bail out if source and destination do not have the same storage order. > > > 2022-11-22 Eric Botcazou > > * gnat.dg/sso18.adb: New test. > > -- > Eric Botcazou