From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by sourceware.org (Postfix) with ESMTPS id 56B61385841A for ; Mon, 14 Nov 2022 14:54:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 56B61385841A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-x12a.google.com with SMTP id b3so19677690lfv.2 for ; Mon, 14 Nov 2022 06:54:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=z2kLQ1kfuuNSMr0HPGps7ihWxCuFOPYbk/y4sYUZhbg=; b=KKs3FlvvePT6zSng+ZqfIY9GeirszT+K5n8jrlZwp0zcGkeHBRYHo/EBdtScXbaeQh lZx8reO2fCxeE6z/NwUdKU5shrn7y/7Z63TnTd9yvyIi7cIU4MmM10Qi+lCVzSv1XS5r +QcHUE4bv4sn0OUMlDFDOwjeMqWNldPRQNhgy98Xya84PxCSlcCuBjn8kVXaVsADPyKW Pk7UtyzE/NZUo9YvwlYEywM38SFcpxozTdfR+Z41u236O9b/lNbBE4toinPBL17+avUw Lpejg6ldc8pNcGtnHMdiQBGh1Y2hCbccKEv4Tsh6umKH2PfhbCUlUrr4W7eXVcUwcsYl NDwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=z2kLQ1kfuuNSMr0HPGps7ihWxCuFOPYbk/y4sYUZhbg=; b=1wT1bwW0NnR+qAkiXAjjxdYa2LLa/KL6v0L8Tm9SfhJcSdJCW7RcnNBNYgwd6C40cZ 8AO87ljbuiViuSYQ6CIrRQ0mTD6pJ/+nVb4cv1cpmY7oeoUrXyICoLsqzNwJ+rmytcyv fAy3UHi2QaVNJ0J4coDypXTTC8IMv8d0caHkmIThA1tN4O9SpsQARQVSPz7iktuCZIil apwWgpen+0g5IMClAodXHejnKKyxhx1BAMxzAeG0xp/8AGe6aSOEcWmBDNvZpQLa4d02 f5LQxaIt8OxghangxOv84iP91AZvLk+KyQvoiCJQMZNjQOBLTDz91yqdosCYhbbmKOKO /2UA== X-Gm-Message-State: ANoB5plUdb2UfM8RFoV6+twfOuoKYUdq4Frn9pYhHnxOrbX144F+7wQh MklJo/qHYdITsFG8bta+QHJwgNhKuYxjozJoGnU= X-Google-Smtp-Source: AA0mqf6eV+1QWTvWtyRikt/+4Bfsi0Hj1MP+kMUcUQxZczVftBu/rkyrD5XTIBwI113xbQ4CqJFTlVyBTRHgPydjBl4= X-Received: by 2002:ac2:465c:0:b0:4a2:6e1d:f996 with SMTP id s28-20020ac2465c000000b004a26e1df996mr4143947lfo.114.1668437670876; Mon, 14 Nov 2022 06:54:30 -0800 (PST) MIME-Version: 1.0 References: <20221011210156.7710-1-palmer@rivosinc.com> <20221011210156.7710-2-palmer@rivosinc.com> In-Reply-To: <20221011210156.7710-2-palmer@rivosinc.com> From: Richard Biener Date: Mon, 14 Nov 2022 15:54:18 +0100 Message-ID: Subject: Re: [PATCH v2 1/3] doc: -falign-functions doesn't override the __attribute__((align(N))) To: Palmer Dabbelt Cc: hubicka@ucw.cz, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Oct 11, 2022 at 11:02 PM Palmer Dabbelt wrote: > > I found this when reading the documentation for Kito's recent patch. > From the discussion it sounds like this is the desired behavior, so > let's document it. OK. > gcc/doc/ChangeLog > > * invoke.texi (-falign-functions): Mention __align__ > --- > gcc/doc/invoke.texi | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi > index 2a9ea3455f6..8326a60dcf1 100644 > --- a/gcc/doc/invoke.texi > +++ b/gcc/doc/invoke.texi > @@ -13136,7 +13136,9 @@ effective only in combination with @option{-fstrict-aliasing}. > Align the start of functions to the next power-of-two greater than or > equal to @var{n}, skipping up to @var{m}-1 bytes. This ensures that at > least the first @var{m} bytes of the function can be fetched by the CPU > -without crossing an @var{n}-byte alignment boundary. > +without crossing an @var{n}-byte alignment boundary. This does not override > +functions that otherwise specify their own alignment constraints, such as via > +an alignment attribute. > > If @var{m} is not specified, it defaults to @var{n}. > > -- > 2.34.1 >