From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by sourceware.org (Postfix) with ESMTPS id BA64D3857C64 for ; Mon, 24 Aug 2020 07:26:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BA64D3857C64 Received: by mail-ed1-x543.google.com with SMTP id c10so7117782edk.6 for ; Mon, 24 Aug 2020 00:26:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=1K1EBDkGEpGOWCBLUDtpWR0sqv/AW2AMalSjkQ7fPZ0=; b=lsbx+5tpnniqw/El3rMagloozxFSXpCKligzvGz5C0BYAkgAy7zLyFIQla9cIgrb/8 Vbmp7l3v5XdrsMxCg7mrrdcoGUsc33oBx/vrDyZPWOz+4olmovOVksOnERk4gPyBjHf6 kFhPMWcOGvwdQLx0fa+AVACEtVQPPvk2/o1ZY+wI+SJrF+3Fb8Th2/yMD+Nm7Y/BTjLY /NFpWCEV5IPQ5d1x3+Hm5SyLW50LbdEywENSGpMIiiJwe5/o7Uc8tJuLiydM5cX4om1Q 3cFVRajVGVqi8K9BK2ZjhChqk3s2HOBpvrC4bUlcdoEKqoRF9MIX+MLF/d3r3kcBiSt7 PVIA== X-Gm-Message-State: AOAM533PDe1QQbanw8sIajqMBunKQzASkxqpR3i5BgF4HroAwFFHZzC9 iLH3c9rCTeKI0yCJwbE+V0fD8I0ewI5hXhxh7xc= X-Google-Smtp-Source: ABdhPJw/Hn4zyX/wMfNTlaEJiOCWWAXLKprZv/JwEEz8zSEUuo0aUng9eQ3Oq871EWrls1pSBh3i6+hnZbkjrp1T9Mo= X-Received: by 2002:a05:6402:1758:: with SMTP id v24mr4226918edx.274.1598253971887; Mon, 24 Aug 2020 00:26:11 -0700 (PDT) MIME-Version: 1.0 References: <3094032c-a4f6-e1f4-091d-d83cda4cb7d3@suse.cz> In-Reply-To: <3094032c-a4f6-e1f4-091d-d83cda4cb7d3@suse.cz> From: Richard Biener Date: Mon, 24 Aug 2020 09:26:00 +0200 Message-ID: Subject: Re: [PATCH] Add missing vn_reference_t::punned initialization To: =?UTF-8?Q?Martin_Li=C5=A1ka?= Cc: GCC Patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Aug 2020 07:26:14 -0000 On Thu, Aug 13, 2020 at 2:49 PM Martin Li=C5=A1ka wrote: > > As mentioned in the PR, we miss one initialization of ::punned > in vn_reference_lookup_call. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? OK. Thanks, Richard. > Thanks, > Martin > > gcc/ChangeLog: > > PR tree-optimization/96597 > * tree-ssa-sccvn.c (vn_reference_lookup_call): Add missing > initialization of ::punned. > (vn_reference_insert): Use consistently false instead of 0. > (vn_reference_insert_pieces): Likewise. > --- > gcc/tree-ssa-sccvn.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/gcc/tree-ssa-sccvn.c b/gcc/tree-ssa-sccvn.c > index 934ae40670d..789d3664db5 100644 > --- a/gcc/tree-ssa-sccvn.c > +++ b/gcc/tree-ssa-sccvn.c > @@ -3578,6 +3578,7 @@ vn_reference_lookup_call (gcall *call, vn_reference= _t *vnresult, > vr->vuse =3D vuse ? SSA_VAL (vuse) : NULL_TREE; > vr->operands =3D valueize_shared_reference_ops_from_call (call); > vr->type =3D gimple_expr_type (call); > + vr->punned =3D false; > vr->set =3D 0; > vr->base_set =3D 0; > vr->hashcode =3D vn_reference_compute_hash (vr); > @@ -3601,7 +3602,7 @@ vn_reference_insert (tree op, tree result, tree vus= e, tree vdef) > vr1->vuse =3D vuse_ssa_val (vuse); > vr1->operands =3D valueize_shared_reference_ops_from_ref (op, &tem).c= opy (); > vr1->type =3D TREE_TYPE (op); > - vr1->punned =3D 0; > + vr1->punned =3D false; > ao_ref op_ref; > ao_ref_init (&op_ref, op); > vr1->set =3D ao_ref_alias_set (&op_ref); > @@ -3661,7 +3662,7 @@ vn_reference_insert_pieces (tree vuse, alias_set_ty= pe set, > vr1->vuse =3D vuse_ssa_val (vuse); > vr1->operands =3D valueize_refs (operands); > vr1->type =3D type; > - vr1->punned =3D 0; > + vr1->punned =3D false; > vr1->set =3D set; > vr1->base_set =3D base_set; > vr1->hashcode =3D vn_reference_compute_hash (vr1); > -- > 2.28.0 >