From: Richard Guenther <richard.guenther@gmail.com>
To: Diego Novillo <dnovillo@google.com>
Cc: Steven Bosscher <stevenb.gcc@gmail.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch] Do not include output.h everywhere
Date: Fri, 01 Jun 2012 09:19:00 -0000 [thread overview]
Message-ID: <CAFiYyc3O+6_Ftds0wj=rvYEBL0NEik00F8bRJfPSB5HS0AOrMA@mail.gmail.com> (raw)
In-Reply-To: <4FC7C4D6.8010905@google.com>
On Thu, May 31, 2012 at 9:21 PM, Diego Novillo <dnovillo@google.com> wrote:
> On 12-05-31 14:57 , Steven Bosscher wrote:
>>
>> Hello,
>>
>> Almost all files include output.h because it defines dump_file. IMHO
>> output.h should only be included in files that actually output
>> something to asm_out_file. Therefore wanted to I move dump_file to
>> some other include file. I ended up with system.h because I couldn't
>> find a more suitable place. Another option is coretypes.h, but no
>> other file is included everywhere, and system.h also already defines
>> fancy_abort, which is also for dumping things - sort of... Anyway, the
>> point is that with dump_file moved out of output.h, ~120 files don't
>> have to include output.h anymore.
>
>
> What about toplev.h? dump_file is defined there, after all. I don't mind
> it in system.h, if that's not a good place for it now. The patch is OK
> either way.
I'd prefer toplev.h, too. system.h is supposed to be for system header
inclusion (and related workarounds).
>
>> While working on the above, I noticed we can also move all dbxout
>> prototypes from output.h to dbxout.h, and move some stabs-related
>> target hooks there also.
>
>
> Sounds good.
>
>
>> Big patch, but IMHO a nice cleanup too :-)
>
>
> Indeed.
Thus, ok with moving to toplev.h instead.
>>
>> * gcov-dump.c (dump_file): Rename to dump_gcov_file. Update
>> callers.
>>
>> * collect2.h (dump_file): Rename to dump_ld_file.
>
>
> Thanks. I've always hated tagging for dump_file and stopping here.
>
>
> Diego.
next prev parent reply other threads:[~2012-06-01 9:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-31 18:57 Steven Bosscher
2012-05-31 19:22 ` Diego Novillo
2012-06-01 9:19 ` Richard Guenther [this message]
2012-06-04 7:00 ` Steven Bosscher
2012-06-04 9:42 ` Richard Guenther
2012-06-04 10:58 ` Steven Bosscher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiYyc3O+6_Ftds0wj=rvYEBL0NEik00F8bRJfPSB5HS0AOrMA@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=dnovillo@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=stevenb.gcc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).