From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by sourceware.org (Postfix) with ESMTPS id 11DD73858D33 for ; Fri, 3 Mar 2023 11:10:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 11DD73858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-x133.google.com with SMTP id s22so3060679lfi.9 for ; Fri, 03 Mar 2023 03:10:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677841799; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=sjND8/fnI6ELHj3DuZjivLjPqDrZTa/LhWUm+y3O0H8=; b=ahJOnaUBa+v7dF0F7MFNItapxpmsFLAPsIXUb3BvkI/c+NN8dfh9GO0UpwlNEP0m8j rlDkpGE54835gJ9gS9skb+24Xikx0scy5n5hnvQKnoU89qmKY2k0w7y6PsLIw4ZETzss 4KLZm0pbpipwuEP4TNWgMnMedql7L+gY/W2W2u1+fsQnj3N5vZ25WLXoqhZJuXE5U6A0 QMKn9nP8LR+yNzS9SGY5rNvV9jNlgi8lVCKpOf1PNELXnOeJP7tRFLYCwSZSMTWnDbX8 zVo00YIC1ROCDl4H14fM2LrrVW9Wu1EbTR1LSAtSdnspgTL3LUyFk62Odni28v3PRl4p yxTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677841799; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sjND8/fnI6ELHj3DuZjivLjPqDrZTa/LhWUm+y3O0H8=; b=gnlWUbnu3nuCIi00FqtWIFkoJ7o5cEdGCpenQjfF1OkZwEBh/9tlV7MRh2/Pc9GmLs 1kTAXFaQySIsKOn+ZFnYLDLWJrI/l49Bnlu3W053N72yGNewuU862QDkklUgL/T8U9yy qimQtSy6VCWb+ZrREAyeatUHPdDKPeXyxQQ78fv6WBS/rLiPi6V8u2biX996RLc6srum Rl69jX/o8b6Ehn5vT5CS+Y3OSHWUXCLehquN0VbygkxHTf6JbRvLwgC15t7q2ye7Nmhx WRs8dL9aaF/TdlTd/TBwHSgJaHzjITvSfu5E3wuL9N+IaBNg8l48Knna+apbBvChjUA7 d0ww== X-Gm-Message-State: AO0yUKUQEc9quiJvJM0ocIAX5RrNHNRldGOOrf16PcchHwqWPdMkRAD9 nkdEkBPEguC3ov1b1k2JOFZG8wA9UUXGGk0vV9s= X-Google-Smtp-Source: AK7set8mqL9rLcJMuCBo3tfqokNxv+hHIDfpDdOZErJXn8oDQW/FRJlHVuItNrXAGBW9ly42whliP4SAaGEsQjT9jfA= X-Received: by 2002:ac2:5934:0:b0:4db:3873:fac1 with SMTP id v20-20020ac25934000000b004db3873fac1mr488862lfi.9.1677841799293; Fri, 03 Mar 2023 03:09:59 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Richard Biener Date: Fri, 3 Mar 2023 12:09:46 +0100 Message-ID: Subject: Re: [PATCH] testsuite: Do not expect partial vectorization for s390. To: Robin Dapp Cc: GCC Patches , Andreas Krebbel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Mar 2, 2023 at 7:24=E2=80=AFPM Robin Dapp via Gcc-patches wrote: > > Hi, > > this patch changes SLP test expectations. As we only vectorize when no > more than one rgroup is present, no vectorization is performed. > > I was also considering using a separate target selector (something like > vect_partial_vectors_bias_m1) but as the number of testcases is limited > that would probably not simplify things much for now. > > Is this OK? OK > Regards > Robin > > -- > > gcc/testsuite/ChangeLog: > > * gcc.dg/vect/slp-3.c: Adapt test expectation. > * gcc.dg/vect/slp-multitypes-11.c: Likewise. > * gcc.dg/vect/slp-perm-8.c: Likewise. > --- > gcc/testsuite/gcc.dg/vect/slp-3.c | 8 ++++---- > gcc/testsuite/gcc.dg/vect/slp-multitypes-11.c | 4 ++-- > gcc/testsuite/gcc.dg/vect/slp-perm-8.c | 4 ++-- > 3 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/gcc/testsuite/gcc.dg/vect/slp-3.c b/gcc/testsuite/gcc.dg/vec= t/slp-3.c > index 80ded1840ad2..4b9a58662305 100644 > --- a/gcc/testsuite/gcc.dg/vect/slp-3.c > +++ b/gcc/testsuite/gcc.dg/vect/slp-3.c > @@ -141,8 +141,8 @@ int main (void) > return 0; > } > > -/* { dg-final { scan-tree-dump-times "vectorized 3 loops" 1 "vect" { tar= get { ! { vect_partial_vectors || vect32 } } } } } */ > -/* { dg-final { scan-tree-dump-times "vectorized 4 loops" 1 "vect" { tar= get { vect_partial_vectors || vect32 } } } } */ > -/* { dg-final { scan-tree-dump-times "vectorizing stmts using SLP" 3 "ve= ct" { target { ! { vect_partial_vectors || vect32 } } } } }*/ > -/* { dg-final { scan-tree-dump-times "vectorizing stmts using SLP" 4 "ve= ct" { target { vect_partial_vectors || vect32 } } } } */ > +/* { dg-final { scan-tree-dump-times "vectorized 3 loops" 1 "vect" { tar= get { ! { vect_partial_vectors || vect32 } || s390_vx } } } } */ > +/* { dg-final { scan-tree-dump-times "vectorized 4 loops" 1 "vect" { tar= get { vect_partial_vectors || vect32 } && { ! s390_vx } } } } */ > +/* { dg-final { scan-tree-dump-times "vectorizing stmts using SLP" 3 "ve= ct" { target { ! { vect_partial_vectors || vect32 } || s390_vx } } } }*/ > +/* { dg-final { scan-tree-dump-times "vectorizing stmts using SLP" 4 "ve= ct" { target { vect_partial_vectors || vect32 } && { ! s390_vx } } } } */ > > diff --git a/gcc/testsuite/gcc.dg/vect/slp-multitypes-11.c b/gcc/testsuit= e/gcc.dg/vect/slp-multitypes-11.c > index 96218861cd61..dbf93ee6bb37 100644 > --- a/gcc/testsuite/gcc.dg/vect/slp-multitypes-11.c > +++ b/gcc/testsuite/gcc.dg/vect/slp-multitypes-11.c > @@ -50,6 +50,6 @@ int main (void) > > /* { dg-final { scan-tree-dump-times "vectorized 1 loops" 1 "vect" { ta= rget vect_unpack } } } */ > /* The epilogues are vectorized using partial vectors. */ > -/* { dg-final { scan-tree-dump-times "vectorizing stmts using SLP" 1 "ve= ct" { target { vect_unpack && {! vect_partial_vectors_usage_1 } } xfail { = vect_variable_length && vect_load_lanes } } } } */ > -/* { dg-final { scan-tree-dump-times "vectorizing stmts using SLP" 2 "ve= ct" { target { vect_unpack && vect_partial_vectors_usage_1 } xfail { vect_= variable_length && vect_load_lanes } } } } */ > +/* { dg-final { scan-tree-dump-times "vectorizing stmts using SLP" 1 "ve= ct" { target { vect_unpack && { {! vect_partial_vectors_usage_1 } || s390_= vx } } xfail { vect_variable_length && vect_load_lanes } } } } */ > +/* { dg-final { scan-tree-dump-times "vectorizing stmts using SLP" 2 "ve= ct" { target { vect_unpack && vect_partial_vectors_usage_1 && { ! s390_vx = } } xfail { vect_variable_length && vect_load_lanes } } } } */ > > diff --git a/gcc/testsuite/gcc.dg/vect/slp-perm-8.c b/gcc/testsuite/gcc.d= g/vect/slp-perm-8.c > index 9e59832fb8b7..4023670d4459 100644 > --- a/gcc/testsuite/gcc.dg/vect/slp-perm-8.c > +++ b/gcc/testsuite/gcc.dg/vect/slp-perm-8.c > @@ -60,9 +60,9 @@ int main (int argc, const char* argv[]) > } > > /* { dg-final { scan-tree-dump-times "vectorized 1 loops" 1 "vect" { tar= get { vect_perm_byte } } } } */ > -/* { dg-final { scan-tree-dump-times "vectorizing stmts using SLP" 1 "ve= ct" { target { vect_perm3_byte && { { ! vect_load_lanes } && {! vect_partia= l_vectors_usage_1 } } } } } } */ > +/* { dg-final { scan-tree-dump-times "vectorizing stmts using SLP" 1 "ve= ct" { target { vect_perm3_byte && { { ! vect_load_lanes } && { {! vect_part= ial_vectors_usage_1 } || s390_vx } } } } } } */ > /* The epilogues are vectorized using partial vectors. */ > -/* { dg-final { scan-tree-dump-times "vectorizing stmts using SLP" 2 "ve= ct" { target { vect_perm3_byte && { { ! vect_load_lanes } && vect_partial_v= ectors_usage_1 } } } } } */ > +/* { dg-final { scan-tree-dump-times "vectorizing stmts using SLP" 2 "ve= ct" { target { vect_perm3_byte && { { ! vect_load_lanes } && vect_partial_v= ectors_usage_1 && { ! s390_vx } } } } } } */ > /* { dg-final { scan-tree-dump-times "vectorizing stmts using SLP" 0 "ve= ct" { target vect_load_lanes } } } */ > /* { dg-final { scan-tree-dump "Built SLP cancelled: can use load/store-= lanes" "vect" { target { vect_perm3_byte && vect_load_lanes } } } } */ > /* { dg-final { scan-tree-dump "LOAD_LANES" "vect" { target vect_load_la= nes } } } */ > -- > 2.39.1