From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by sourceware.org (Postfix) with ESMTPS id 5524338582A5 for ; Fri, 1 Dec 2023 06:56:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5524338582A5 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5524338582A5 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::133 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701413788; cv=none; b=Yp1cxnb6O3DBqZ0MGSjCotesa2E0VO642UEIpW39Cz062G/iGCDlchiZ57d3JgdYpvqOnI4YIy5AS00iA0DzrE1qBS0PML3wiQs+t5oKfu3NZoSZFeTW2os8DbfX3zcEOAr2puKGgnvJvvLiTPZwxCFxZ2vbJQvhOavNv3XyynQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701413788; c=relaxed/simple; bh=FO28FmAgAd0wzNG1qmAvIQv940dC77ua/veZl9MX69g=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=eqrxoyDdZqg08WZyfF8Xla4jaeeU3yJkyXcLmQ+9v3iZX9raVFHod22OPmUMqOnTndocvhEgrbhQtHBeohTbRo76SKPhkKFjYZwI71iAkaTOKupzLue5t+swewrSbvJj9da8k6NLu+IL9Rcs2MI1dEvZSN2DOX+WYezMi4ubHBA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-50bba1dd05fso2512568e87.0 for ; Thu, 30 Nov 2023 22:56:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701413786; x=1702018586; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VSZo5o3TuBXafJonrezO6d7w+RKemWBL1oyHtPAMY7Q=; b=nn+BXOYULInOkmUOWRD0kUGfx8Dalgj4caSdipzSn29oJQjnx4hy8M1gUi52ufXgxo nnvu5qMqWe/n4vUO4FZWJVhJO+6+S8RG5BEQlCl5vBjgVhmyZUUjLYk6Kq1ARoJoV/dn 9pdkIDeCvS6qipSt6JMZY0NnVzEzUFtL01jRILpq8Vvvn2SvmuLDfvKEJBbvfykLRC+0 Usmgkozh7i+MlSvIYlIIQvZS1ShYjuWfFSDCp7iopNt84OrVAKZkH7zDCbl7840bmOWy n9jIp6l9mTltZx7k7whyH41WKEYumVHOo/H00jQcSxJz4HL4OfTb8yXeR79TpI2fl6BS bGHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701413786; x=1702018586; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VSZo5o3TuBXafJonrezO6d7w+RKemWBL1oyHtPAMY7Q=; b=ChVGjhzs5zEN8NSviyXZ9krVH8lgvrzhJdiylpHMMB47Z3NXjqOVQUg9En93OlULFZ KWwGNQ/sMeLu6jZpwKlawg9Z0duyAJbRabxa/tVstaWA2YLR2uepyxPykeyXL9owI1pc 6bZiDMIAB/5zfy5tiQ+3k43BjqgT/2W5xHLcVt9em4ro8UsN8A5kmtsEe3o9mZ+Ymc6q 58gHpoGqUAqkYW9kiB6CXNMIjj1F4PJiNpo6SPMfi6k3I1PH5qnFof97U6i3jGc2E+ht t1VGXhlWekPHSgfc67jJ+j1FO2kxd6WV9b6F7Z95FbbNnNzwHp6it05DIFTXcTy0QnU0 axrA== X-Gm-Message-State: AOJu0YywZ99BOrhzFG5oOi4YPOSdKaLAuqDAoN2P6En5PnSDlvqQNw02 oVmgQx9SicJP8GscKD9e6/xlvsUxf2MjSrMPNlE= X-Google-Smtp-Source: AGHT+IGSAzflzTeuJI2y9Kk2oQ+Dmhg/idjBDoxzin0ssa6d0UjqluDNRSKaAmm8kwWXb5Wk28pnC41oO64vEzQWlVE= X-Received: by 2002:a05:6512:1385:b0:50b:d764:8800 with SMTP id fc5-20020a056512138500b0050bd7648800mr572951lfb.76.1701413785485; Thu, 30 Nov 2023 22:56:25 -0800 (PST) MIME-Version: 1.0 References: <20231130162054.89738-1-sebastian.huber@embedded-brains.de> In-Reply-To: <20231130162054.89738-1-sebastian.huber@embedded-brains.de> From: Richard Biener Date: Fri, 1 Dec 2023 07:56:13 +0100 Message-ID: Subject: Re: [PATCH] gcov: Fix __LIBGCC_HAVE_LIBATOMIC definition To: Sebastian Huber Cc: gcc-patches@gcc.gnu.org, Matthias Klose Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Nov 30, 2023 at 5:21=E2=80=AFPM Sebastian Huber wrote: > > In libgcov we use defined (__LIBGCC_HAVE_LIBATOMIC), so we must define it= only > if needed (vs. #if __LIBGCC_HAVE_LIBATOMIC). For consistency wouldn't it be better to change the user side in libgcc? > gcc/c-family/ChangeLog: > > PR target/112777 > > * c-cppbuiltin.cc (c_cpp_builtins): Define __LIBGCC_HAVE_LIBATOM= IC > only if targetm.have_libatomic is true. > --- > gcc/c-family/c-cppbuiltin.cc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gcc/c-family/c-cppbuiltin.cc b/gcc/c-family/c-cppbuiltin.cc > index e536429fa4c..f8ec6f1747c 100644 > --- a/gcc/c-family/c-cppbuiltin.cc > +++ b/gcc/c-family/c-cppbuiltin.cc > @@ -1570,8 +1570,8 @@ c_cpp_builtins (cpp_reader *pfile) > /* For libgcov. */ > builtin_define_with_int_value ("__LIBGCC_VTABLE_USES_DESCRIPTORS__= ", > TARGET_VTABLE_USES_DESCRIPTORS); > - builtin_define_with_int_value ("__LIBGCC_HAVE_LIBATOMIC", > - targetm.have_libatomic); > + if (targetm.have_libatomic) > + cpp_define (pfile, "__LIBGCC_HAVE_LIBATOMIC"); > } > > /* For use in assembly language. */ > -- > 2.35.3 >