From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-410017-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 103942 invoked by alias); 13 Oct 2015 12:53:48 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 103926 invoked by uid 89); 13 Oct 2015 12:53:48 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-yk0-f178.google.com
Received: from mail-yk0-f178.google.com (HELO mail-yk0-f178.google.com) (209.85.160.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 13 Oct 2015 12:53:47 +0000
Received: by ykoo7 with SMTP id o7so15056784yko.0        for <gcc-patches@gcc.gnu.org>; Tue, 13 Oct 2015 05:53:45 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.13.198.194 with SMTP id i185mr24204790ywd.68.1444740825058; Tue, 13 Oct 2015 05:53:45 -0700 (PDT)
Received: by 10.37.93.136 with HTTP; Tue, 13 Oct 2015 05:53:44 -0700 (PDT)
In-Reply-To: <CAEoMCqTTRPXkoBBfONnA-GQEiqzZttQ9EOEc1y=2b0WjsJPhVg@mail.gmail.com>
References: <CAEoMCqR-LXyr8xbbH6=CT0rJNSmpKTG+za257RO6Gc13RWcHyg@mail.gmail.com>	<CAMe9rOoH=_0h6FokqeDoCPb2zL_uVGuM2sUX6nyWQCJ=_HhObQ@mail.gmail.com>	<CAEoMCqTTRPXkoBBfONnA-GQEiqzZttQ9EOEc1y=2b0WjsJPhVg@mail.gmail.com>
Date: Tue, 13 Oct 2015 12:53:00 -0000
Message-ID: <CAFiYyc3UHKoRPFUtXjBioMg4GUT+aorf18CmfVOJKADSGF_JPg@mail.gmail.com>
Subject: Re: [PATCH PR67909 PR67947]
From: Richard Biener <richard.guenther@gmail.com>
To: Yuri Rumyantsev <ysrumyan@gmail.com>
Cc: "H.J. Lu" <hjl.tools@gmail.com>, gcc-patches <gcc-patches@gcc.gnu.org>, 	Igor Zamyatin <izamyatin@gmail.com>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2015-10/txt/msg01238.txt.bz2

On Tue, Oct 13, 2015 at 2:49 PM, Yuri Rumyantsev <ysrumyan@gmail.com> wrote:
> Here is updated patch with splitting long line.
> The patch is attached.

Ok with aligning the guard_edge == ... line properly

Thanks,
Richard.

> Yuri.
>
> 2015-10-13 15:38 GMT+03:00 H.J. Lu <hjl.tools@gmail.com>:
>> On Tue, Oct 13, 2015 at 4:57 AM, Yuri Rumyantsev <ysrumyan@gmail.com> wrote:
>>> Hi All,
>>>
>>> Here is a simple patch for unswitching outer loop through guard-edge
>>> hoisting. The check that guard-edge is around the inner loop was
>>> missed.
>>>
>>> Bootstrapping and regression testing did not show new failures.
>>>
>>> Is it OK for trunk?
>>>
>>> ChangeLog:
>>> 2014-10-13  Yuri Rumyantsev  <ysrumyan@gmail.com>
>>>
>>> PR tree-optimization/67909, 67947
>>> * tree-ssa-loop-unswitch.c (find_loop_guard): Add check that GUARD_EDGE
>>> really skip the inner loop.
>>>
>>> gcc/testsuite/ChangeLog
>>> * gcc.dg/torture/pr67947.c: New test.
>>
>> +  /* Guard edge must skip inner loop.  */
>> +  if (!dominated_by_p (CDI_DOMINATORS, loop->inner->header,
>> +      guard_edge == fe ? te->dest : fe->dest))
>>         ^^^^  It should line up with "CDI_DOMINATORS".
>>
>> + fprintf (dump_file, "Guard edge %d --> %d is not around the
>> loop!\n",guard_edge->src->index,guard_edge->dest->index);
>>
>> Please break lone line.
>>
>> --
>> H.J.