From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by sourceware.org (Postfix) with ESMTPS id 964473858417 for ; Tue, 22 Nov 2022 09:00:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 964473858417 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-x133.google.com with SMTP id g7so22623241lfv.5 for ; Tue, 22 Nov 2022 01:00:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=TMzsdIJdifD3ZT9aIEjWThZ4nhzzwRmsAnlI9jKmgcM=; b=k7FP3ud0dzGwr2ViPtVwKdNreOg5npH/1ldb7CCeyxm4Dj/nj6IuaZuj1OhmPrsQlx L6yNAylcHDAu8upMmKN4wYxAkpk+Y+YcA52xDPS+6EQSHiFSU1HuTkbzXfKsJ8HVn9/U 6WhrHOfnqCZEqVCmtRSLM5TmiZrdPqSVwamG4qjEhBiQ8mmlsPaISbW5TECXtFWPIbg/ B/2VeQthxueFAlXoNl4csoEBqWt0Yf16bx476GUI4yvZCQSwlm20yAFvCqwJVQGdME/c gvNqrCp4ej8lUKCHgwIeM05yoig+aRP+Ej8Je1KguHUKmRxXJ0fogWZhnp8T7T2jHP1W iyXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TMzsdIJdifD3ZT9aIEjWThZ4nhzzwRmsAnlI9jKmgcM=; b=WqkaEXFPeVVMn0dKwStdLE5nlkBfu0C5HSEkeJ9kONVX7YiEg6k5f7SWU+QJ+AkIpv hmEL1wwB6vryvIq7Ir1dabaaVrbXlMaX4frZtyR/b7jvflEGg7ejCTi+ZkTm9ySyEy/I ODJoSqjjKYuIikb/9bnaU5x0LM8N0njsLxYk4kojv84IAc1O3H+nhHVZVq0m2s6ls2JL 26KzwJ6rXsA4dPRm4ZzzIUAmKGT9EPp7mO4o01FaIjfA2gjRqd3pRTDIDaBu8W1YWLrG +5amhYCLXMFsAkUW+4G/vco1JoomZ2tD9MY7wjhdr6n7VSeA3o7Y0aAVyeCYhGWUF61C axXA== X-Gm-Message-State: ANoB5pnF28j3Zk1e6m68MrJBZx5zOPl+WcY7xUE12gxz2p6b9S8kq1gf Dw+j2S6d/En2Cxu2sbv83NMFmn+Rm06SQlNe4/4= X-Google-Smtp-Source: AA0mqf4ERdK+7hhObx6pJ2bS51u2NNhSJ+cJ9gHCKT50Cb0sVJ6aFgMiu93Vyuo6RfFJIyQ9hx1fslqiVMCQD5TXjU0= X-Received: by 2002:a05:6512:e86:b0:4b4:70d9:5c02 with SMTP id bi6-20020a0565120e8600b004b470d95c02mr7276977lfb.27.1669107641026; Tue, 22 Nov 2022 01:00:41 -0800 (PST) MIME-Version: 1.0 References: <20221116235429.25268-1-hongyu.wang@intel.com> <20221118144600.GZ25951@gate.crashing.org> In-Reply-To: <20221118144600.GZ25951@gate.crashing.org> From: Richard Biener Date: Tue, 22 Nov 2022 10:00:28 +0100 Message-ID: Subject: Re: [PATCH] rs6000: Adjust loop_unroll_adjust to match middle-end change [PR 107692] To: Segher Boessenkool Cc: Hongyu Wang , gcc-patches@gcc.gnu.org, dje.gcc@gmail.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Nov 18, 2022 at 3:47 PM Segher Boessenkool wrote: > > [ Please cc: me and Ke Wen on rs6000 patches ] > > On Thu, Nov 17, 2022 at 07:54:29AM +0800, Hongyu Wang wrote: > > r13-3950-g071e428c24ee8c enables O2 small loop unrolling, but it breaks > > -fno-unroll-loops for rs6000 with loop_unroll_adjust hook. Adjust the > > option handling and target hook accordingly. > > NAK. > > This is wrong. -munroll-only-small-loops does not enable loop > unrolling; doing that with a machine flag is completely unmaintainable, > also for people using different targets. I suggested that because doing it fully in the backend by twiddling -funroll-loops is unmaintainable as well. > Something in your patch was wrong, please fix that (or revert the > patch). You should not have to touch config/rs6000/ at all. Sure something is wrong, but I think there's the opportunity to simplify rs6000/ and s390x/, the only other two implementors of the hook used. Richard. > > Segher