From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by sourceware.org (Postfix) with ESMTPS id D9CEB3858C52 for ; Mon, 13 May 2024 07:53:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D9CEB3858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D9CEB3858C52 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::22f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715586823; cv=none; b=WoRFb2qNAk4Nod2m5hLFGMXBr/uN7P8OJk5PY3pwEokLUD/4lcG2yTS3SN6m5UzsAg6oT1/K3VpfSCzamM5btmm3nQir+lkC8JRS3VkMSXczTl3pWNxJ9ewBpbBk25rE3PGzvg/qgOwQ3QMtK4R/AEASuJ+OOQGdJ+XUfjnfvTo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715586823; c=relaxed/simple; bh=GPujHGLVscf9kzDnvfyN5dRJU/FPBrNI72QiDCQNchA=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=L03zn/cPSwESnemuokSPcbCT6TLOLjj5XeqsHuQPOMIXa/gbfVsQ80vw4iwkUTins6nPKjQc0wOOymbTkVzxWpAW5hiT79YPYH/2eBUpGTDYT1ADzlISaiWq0dAzOX85nQW90XmkqssBgXLbMzHe25pjuSt0FumV1DPA2N3eKjo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2e564cad1f1so27689621fa.0 for ; Mon, 13 May 2024 00:53:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715586820; x=1716191620; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WP2R2CGPh6d51DjydKdCNoA087z1kvafiwDcIAlgpOc=; b=BKlAmZCxK54rbrCgRw79HUtWHG7h4zsoomo5Zb5sPKImcR77ede3+Vmi8JrFKfByyE 6YQo0wzNa+i0ZpB9kSYUQfXpJihqitUUCUKy3ZDmhF9Y8J9CsqGsse7mhYF6Nutr0Ndw n7cteFTGJoAefvDAGWGjMhtQ3yowZacmgtgeTKLAGWle7foBG0acZoNGebCAoPTQnmqg Frtg0cjYIXrIUBDmbv3V1Izufm0+/cZRvv+SDJ1Kbj2VfkCqEvZxU5lnzU8ro9vrgHY7 TzMDq4Pdx84Ib+f5ZFFVeOsWULxoHR//Xzr2ClviFByozCt8flCq+I/y15Rzi5HN5sLD G40Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715586820; x=1716191620; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WP2R2CGPh6d51DjydKdCNoA087z1kvafiwDcIAlgpOc=; b=p1W4+0D9olyaLL+jUpEc/brkvt62K6R4qSX24oElLcS05MAO7qTx5eUBAVxMk1va5N vZz4wuYKKmODRV1Jsoc5MM/w1zM6R+XlQxbLLrMglqrQA4NArR0EkRHknrleL/wTANbC g1POJhqIIfPUM2uP6jvupivxv67f3phvVuipsHGCTPrap3+ME65V+G5sRUa8Cf4w1Jws t4xYVXD3N0PIgT5pQ4rkJQElXnYMZ4qlVwY6N5BeKFsohswUAHHkyy2bbnX1wOP5M/P9 zyxMydvNDJ5qGjvRGZsU0zTLd82Z3r27wXb3s2WLopfZicM6A5c7mf0VYtIqLoa+g408 6vpA== X-Gm-Message-State: AOJu0YwZ0tRRG5fWZXzXQj0803blGCIszyWKh3RL/H7YGDTFtNivYsx5 AuOl3URO5mnUfdHcMqVidGTrSHKtdRpWW7x0CR/1sGVSxDWxPAtEnurzde9d2F1eVdeX7n+X3dW rdNpIDv6Dox3sErG/8BMejWW8VVQ= X-Google-Smtp-Source: AGHT+IEOYpLZ767KQ3LzyvL02dDTZLCAJrRaxiN2azGntp6X2b6+IsMtSkHoxn+Qln3bSBrmMULkNdfvcu1clyzyNyA= X-Received: by 2002:a05:651c:54a:b0:2e1:e33d:67f6 with SMTP id 38308e7fff4ca-2e51fe589demr66082251fa.28.1715586819987; Mon, 13 May 2024 00:53:39 -0700 (PDT) MIME-Version: 1.0 References: <4ee89471-d998-4734-a7d3-1f947d0d9f22@gmail.com> <3ff9db2b-012f-4311-afa7-314d0b50f976@gmail.com> In-Reply-To: <3ff9db2b-012f-4311-afa7-314d0b50f976@gmail.com> From: Richard Biener Date: Mon, 13 May 2024 09:53:29 +0200 Message-ID: Subject: Re: [PATCH] internal-fn: Do not force vcond operand to reg. To: Robin Dapp Cc: gcc-patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, May 13, 2024 at 8:18=E2=80=AFAM Robin Dapp wr= ote: > > > How does this make a difference in the end? I'd expect say forwprop to > > fix things? > > In general we try to only add the masking "boilerplate" of our > instructions at split time so fwprop, combine et al. can do their > work uninhibited of it (and we don't need numerous > (if_then_else ... (if_then_else) ...) combinations in our patterns). > A vec constant we expand directly to a masked representation, though > which makes further simplification difficult. I can experiment with > changing that if preferred. > > My thinking was, however, that for other operations like binops we > directly emit the right variant via expand_operands without > forcing to a reg and don't even need to fwprop so I wanted to > imitate that. Ah, so yeah, it probably makes sense for constants. Btw, there's prepare_operand which I think might be better for its CONST_INT handling? I can also see we usually do not bother with force_reg, the force_reg was added with the initial r6-4696-ga414c77f2a30bb already. What happens if we simply remove all of the force_reg here? Thanks, Richard. > Regards > Robin >