From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by sourceware.org (Postfix) with ESMTPS id 5C5D038582A8 for ; Mon, 24 Oct 2022 07:12:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5C5D038582A8 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x531.google.com with SMTP id m15so27703054edb.13 for ; Mon, 24 Oct 2022 00:12:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=sNf/ENPgmM+MPTrmams8FfTFbsL+Ls0/xpX2DkGthUY=; b=XTrr+Mya2AwRXWr6jpNR7mKW1YhOrRFi3mir3xAig6B8Yawu2j+Q4LSp/kkchEdQvK PTBhSx5Mdai8VBdBhcJ7x8HzXWpckdtyjpCP8fuvCsEDI85y5DuAlKo0KOxbNieuO8HM eUDbpxbCxt1+YXlZNBKwlNY4G/bMocbaM7QJSkWlP7GWdda2VUyobExz9S9s//rP4f6x 4UGrq3ACH3u8ow9osK6JJvRK+0Nre5nmH48VXD9XVJTXMB6tYeeGIPypb+x6NpM2fpKj BXdwXSqz9ZgVQVlaHvuJh0PRJKYxiZcGmYxdbsRfkV41VOOFvL5TqqUIqMITp/luAWG0 rkeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sNf/ENPgmM+MPTrmams8FfTFbsL+Ls0/xpX2DkGthUY=; b=NHBi/bfwni9eOkaepDPzlyZWIaNscZhpIoo3Iq1e1VsTXepP05M4rzCbw9oLqsLgyF VuMUtDfi6kaogo84eECTSTepaNkFbJy3HGeYCXDQt/xZqEiWhHgOHS3+DTo2VnOjF06t 81wUbKk+w3zTK7kQ/6K2+MlqbLMTNLe51QZDuUfoZ1zvanKeGCNRGAGhRKre9rwRPiHD 0jqi2lZQV8qsasixZ3elVz1g6yfheDDQSKkUEqJK1sFenmmLBSsUbUjmGX5MpAapzcj5 cbMxozNbLqbAdxvVNSA7loqy7htAZrK7YWzDM7ZICqZLZgKgpp+XNCWveipmc3ObBruI Ztqg== X-Gm-Message-State: ACrzQf3ftxRbCklkA5lMS3LFhcDHkE6jLg3boF6vzPYzX9AcnjbBC2QO WoU7v2lqXKmRfsvn2VJSKCUQlNU3NX+03qh/cvc= X-Google-Smtp-Source: AMsMyM6AbSixQpGI89PxC3lv7bHNobGc4ks6xDcDNO9ZU7+VwxYmd7mOs76+Dk0neruXn5UNmeLKOD3Mkn35Nc9dqzc= X-Received: by 2002:a17:906:d54d:b0:78e:2fbf:ca2a with SMTP id cr13-20020a170906d54d00b0078e2fbfca2amr26874012ejc.488.1666595539810; Mon, 24 Oct 2022 00:12:19 -0700 (PDT) MIME-Version: 1.0 References: <20221020165734.1113688-1-hjl.tools@gmail.com> In-Reply-To: From: Richard Biener Date: Mon, 24 Oct 2022 09:12:07 +0200 Message-ID: Subject: Re: [PATCH] Always use TYPE_MODE instead of DECL_MODE for vector field To: "H.J. Lu" Cc: Jakub Jelinek , gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Oct 21, 2022 at 6:18 PM H.J. Lu wrote: > > On Fri, Oct 21, 2022 at 2:33 AM Richard Biener > wrote: > > > > On Thu, Oct 20, 2022 at 6:58 PM H.J. Lu via Gcc-patches > > wrote: > > > > > > commit e034c5c895722e0092d2239cd8c2991db77d6d39 > > > Author: Jakub Jelinek > > > Date: Sat Dec 2 08:54:47 2017 +0100 > > > > > > PR target/78643 > > > PR target/80583 > > > * expr.c (get_inner_reference): If DECL_MODE of a non-bitfield > > > is BLKmode for vector field with vector raw mode, use TYPE_MODE > > > instead of DECL_MODE. > > > > > > fixed the case where DECL_MODE of a vector field is BLKmode and its > > > TYPE_MODE is a vector mode because of target attribute. Remove the > > > BLKmode check for the case where DECL_MODE of a vector field is a vector > > > mode and its TYPE_MODE is BLKmode because of target attribute. > > > > > > gcc/ > > > > > > PR target/107304 > > > * expr.c (get_inner_reference): Always use TYPE_MODE for vector > > > field with vector raw mode. > > > > > > gcc/testsuite/ > > > > > > PR target/107304 > > > * gcc.target/i386/pr107304.c: New test. > > > --- > > > gcc/expr.cc | 3 +- > > > gcc/testsuite/gcc.target/i386/pr107304.c | 39 ++++++++++++++++++++++++ > > > 2 files changed, 40 insertions(+), 2 deletions(-) > > > create mode 100644 gcc/testsuite/gcc.target/i386/pr107304.c > > > > > > diff --git a/gcc/expr.cc b/gcc/expr.cc > > > index efe387e6173..9145193c2c1 100644 > > > --- a/gcc/expr.cc > > > +++ b/gcc/expr.cc > > > @@ -7905,8 +7905,7 @@ get_inner_reference (tree exp, poly_int64_pod *pbitsize, > > > /* For vector fields re-check the target flags, as DECL_MODE > > > could have been set with different target flags than > > > the current function has. */ > > > - if (mode == BLKmode > > > - && VECTOR_TYPE_P (TREE_TYPE (field)) > > > + if (VECTOR_TYPE_P (TREE_TYPE (field)) > > > && VECTOR_MODE_P (TYPE_MODE_RAW (TREE_TYPE (field)))) > > > > Isn't the check on TYPE_MODE_RAW also wrong then? Btw, the mode could > > TYPE_MODE_RAW is always set to a vector mode for a vector type: > > /* Find an appropriate mode for the vector type. */ > if (TYPE_MODE (type) == VOIDmode) > SET_TYPE_MODE (type, > mode_for_vector (SCALAR_TYPE_MODE (innertype), > nunits).else_blk ()); But mode_for_vector can return a MODE_INT! /* For integers, try mapping it to a same-sized scalar mode. */ if (GET_MODE_CLASS (innermode) == MODE_INT) { poly_uint64 nbits = nunits * GET_MODE_BITSIZE (innermode); if (int_mode_for_size (nbits, 0).exists (&mode) && have_regs_of_mode[mode]) return mode; > But TYPE_MODE returns BLKmode if the vector mode is unsupported. > > > also be an integer mode. > > For a vector field, mode is either BLK mode or the vector mode. Jakub, > can you comment on it? I think that for typedef int v2si __attribute__((vector_size(8))); struct X { int i; v2si j; }; v2si should get DImode with -mno-sse? > > > > > mode = TYPE_MODE (TREE_TYPE (field)); > > > } > > > diff --git a/gcc/testsuite/gcc.target/i386/pr107304.c b/gcc/testsuite/gcc.target/i386/pr107304.c > > > new file mode 100644 > > > index 00000000000..24d68795e7f > > > --- /dev/null > > > +++ b/gcc/testsuite/gcc.target/i386/pr107304.c > > > @@ -0,0 +1,39 @@ > > > +/* { dg-do compile } */ > > > +/* { dg-options "-O0 -march=tigerlake" } */ > > > + > > > +#include > > > + > > > +typedef union { > > > + uint8_t v __attribute__((aligned(256))) __attribute__ ((vector_size(64 * sizeof(uint8_t)))); > > > + uint8_t i[64] __attribute__((aligned(256))); > > > +} stress_vec_u8_64_t; > > > + > > > +typedef struct { > > > + struct { > > > + stress_vec_u8_64_t s; > > > + stress_vec_u8_64_t o; > > > + stress_vec_u8_64_t mask1; > > > + stress_vec_u8_64_t mask2; > > > + } u8_64; > > > +} stress_vec_data_t; > > > + > > > +__attribute__((target_clones("arch=alderlake", "default"))) > > > +void > > > +stress_vecshuf_u8_64(stress_vec_data_t *data) > > > +{ > > > + stress_vec_u8_64_t *__restrict s; > > > + stress_vec_u8_64_t *__restrict mask1; > > > + stress_vec_u8_64_t *__restrict mask2; > > > + register int i; > > > + > > > + s = &data->u8_64.s; > > > + mask1 = &data->u8_64.mask1; > > > + mask2 = &data->u8_64.mask2; > > > + > > > + for (i = 0; i < 256; i++) { /* was i < 65536 */ > > > + stress_vec_u8_64_t tmp; > > > + > > > + tmp.v = __builtin_shuffle(s->v, mask1->v); > > > + s->v = __builtin_shuffle(tmp.v, mask2->v); > > > + } > > > +} > > > -- > > > 2.37.3 > > > > > > > -- > H.J.