From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28676 invoked by alias); 10 Nov 2011 11:23:19 -0000 Received: (qmail 28667 invoked by uid 22791); 10 Nov 2011 11:23:18 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-vx0-f175.google.com (HELO mail-vx0-f175.google.com) (209.85.220.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 10 Nov 2011 11:22:57 +0000 Received: by vcbfl11 with SMTP id fl11so326002vcb.20 for ; Thu, 10 Nov 2011 03:22:56 -0800 (PST) MIME-Version: 1.0 Received: by 10.182.114.42 with SMTP id jd10mr1760028obb.42.1320924176537; Thu, 10 Nov 2011 03:22:56 -0800 (PST) Received: by 10.182.17.232 with HTTP; Thu, 10 Nov 2011 03:22:56 -0800 (PST) In-Reply-To: <201111101038.pAAAcJIT006280@ignucius.se.axis.com> References: <201111090855.pA98txkZ003552@ignucius.se.axis.com> <201111101038.pAAAcJIT006280@ignucius.se.axis.com> Date: Thu, 10 Nov 2011 12:10:00 -0000 Message-ID: Subject: Re: Revert "PowerPC shrink-wrap support 3 of 3" From: Richard Guenther To: Hans-Peter Nilsson Cc: amodra@gmail.com, gcc-patches@gcc.gnu.org, bernds@codesourcery.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-11/txt/msg01407.txt.bz2 On Thu, Nov 10, 2011 at 11:38 AM, Hans-Peter Nilsson wrote: >> From: Hans-Peter Nilsson >> Date: Wed, 9 Nov 2011 09:55:59 +0100 > >> > From: Alan Modra >> > Date: Tue, 1 Nov 2011 16:33:40 +0100 >> >> > On Tue, Nov 01, 2011 at 12:57:22AM +1030, Alan Modra wrote: >> >> > =A0 =A0 =A0 =A0 * function.c (bb_active_p): Delete. >> > =A0 =A0 =A0 =A0 (dup_block_and_redirect, active_insn_between): New fun= ctions. >> > =A0 =A0 =A0 =A0 (convert_jumps_to_returns, emit_return_for_exit): New = functions, >> > =A0 =A0 =A0 =A0 split out from.. >> > =A0 =A0 =A0 =A0 (thread_prologue_and_epilogue_insns): ..here. =A0Delete >> > =A0 =A0 =A0 =A0 shadowing variables. =A0Don't do prologue register clo= bber tests >> > =A0 =A0 =A0 =A0 when shrink wrapping already failed. =A0Delete all las= t_bb_active >> > =A0 =A0 =A0 =A0 code. =A0Instead compute tail block candidates for dup= licating >> > =A0 =A0 =A0 =A0 exit path. =A0Remove these from antic set. =A0Duplicat= e tails when >> > =A0 =A0 =A0 =A0 reached from both blocks needing a prologue/epilogue a= nd >> > =A0 =A0 =A0 =A0 blocks not needing such. >> > =A0 =A0 =A0 =A0 * ifcvt.c (dead_or_predicable): Test both flag_shrink_= wrap and >> > =A0 =A0 =A0 =A0 HAVE_simple_return. >> > =A0 =A0 =A0 =A0 * bb-reorder.c (get_uncond_jump_length): Make global. >> > =A0 =A0 =A0 =A0 * bb-reorder.h (get_uncond_jump_length): Declare. >> > =A0 =A0 =A0 =A0 * cfgrtl.c (rtl_create_basic_block): Comment typo fix. >> > =A0 =A0 =A0 =A0 (rtl_split_edge): Likewise. =A0Warning fix. >> > =A0 =A0 =A0 =A0 (rtl_duplicate_bb): New function. >> > =A0 =A0 =A0 =A0 (rtl_cfg_hooks): Enable can_duplicate_block_p and dupl= icate_block. >> >> This (a revision in the range 181187:181189) broke build for >> cris-elf like so: >> See PR51051. > > Given that this also broke arm-linux-gnueabi, a primary > platform, and Alan being absent until the 15th according to a > message on IRC, I move to revert r181188. Is there a PR for the arm issue? > I think I need someone with appropriate write privileges to > agree with that, and to also give 48h for someone to fix the > problem. =A0Sorry for not forthcoming on the second point. Did you or somebody else try to look into the problem? To decide whether it's the "best course of action" it would be nice to know if it's a simple error in the patch that is easy to fix. > brgds, H-P > PS. where is the policy written down, besides the mailing list archives? http://gcc.gnu.org/develop.html