From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by sourceware.org (Postfix) with ESMTPS id 72A773858C50 for ; Thu, 9 Feb 2023 14:13:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 72A773858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-x233.google.com with SMTP id b16so2158581ljr.11 for ; Thu, 09 Feb 2023 06:13:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=oXt9P3NcUGJfPqayg3ryQW0u8RRY9bfE1X0Or0vHdZQ=; b=PL6j45lsXtXsqRFOXEn+EXgoGbqwys0UevOgomHk5CXT1+6eeY5sKm1WxORZDMofrl //NQxtmAPSNGdo9sEYaDAcyzmGNTDUXDtYXKCqoK2Lo44ElxKPpLfbq0ry1wK1oQ9j+Q dYhqX4mwY8CxgVR6UFQouvDNCbnvVSl24Hn+414Yky0qCarlVgfxA6giyEcbGnosOLsi fTu+8x33ubko+CzxLXH+LGrCn4SJdnDl6ZuigA2ssLw770w2/y0a8+P6rONuLGbBl/DM +KUSQ8FbOnLRYM4cxPwqAs3kQISkAhifZCpedWJE+iiiHtGFHBK2iyNj8H9WXaumc1vA jE1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oXt9P3NcUGJfPqayg3ryQW0u8RRY9bfE1X0Or0vHdZQ=; b=oMc7mvqj1e7xzMSycTCaJ6WkXqu5u7OZFiJ2CBMXcy4XUGzxhiqJXCnHUf2TOH7x2t EXG0i787NhS6hBvQa3nFWI1lbntP8RqH9d0dTZCzbGdnMRLv6KCuRM/RhWc/XII7IFYP ZMzQxtoA90asC86uhKjYSWG5YMKQp64smy597tSfRl3/RaKKjTdUA3Vw9s5SjlUOcppV 14r6BDk+2BvsFh9pn2O5MRFF/IKi6e92U2A3cjFv74h6UXjolrHMuNf0FMoLEg5jdbn5 rvQbnbx0VNs8N/UQIYP3syovF2hXR5gRLaDGyo2etNOpsEIy23t+pTzQx0Nj61B1xTrb pm7g== X-Gm-Message-State: AO0yUKXANLrYZYSDTLvDgvimp6BZFaA6l6N7JBddRzNOU99sHdmNL0An LsJTH8eFj+yzvCCQSeddedKPcu/6r+e3diBj05Q= X-Google-Smtp-Source: AK7set+uwFOxcLUKiAX4Vqj9Bam1nAcWQuPGVTMxMFXg6T4RhipaxBoX111EoEAstnlZWRnx+xIVL9scXU1rpFYNTNo= X-Received: by 2002:a2e:84c7:0:b0:290:4fce:f881 with SMTP id q7-20020a2e84c7000000b002904fcef881mr1874784ljh.126.1675951990620; Thu, 09 Feb 2023 06:13:10 -0800 (PST) MIME-Version: 1.0 References: <20230208211419.1583473-1-apinski@marvell.com> In-Reply-To: From: Richard Biener Date: Thu, 9 Feb 2023 15:12:58 +0100 Message-ID: Subject: Re: [PATCH] When simplifing BFR of an insert, require a mode precision integral type (PR108688) To: Jakub Jelinek Cc: Andrew Pinski , gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,WEIRD_PORT autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Feb 9, 2023 at 10:57 AM Jakub Jelinek wrote: > > On Thu, Feb 09, 2023 at 09:16:17AM +0100, Richard Biener via Gcc-patches wrote: > > On Wed, Feb 8, 2023 at 10:15 PM Andrew Pinski via Gcc-patches > > wrote: > > > > > > The same problem as PR 88739 has crept in but > > > this time in match.pd when simplifying bit_field_ref of > > > an bit_insert. That is we are generating a BIT_FIELD_REF > > > of a non-mode-precision integral type. > > > > > > OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions. > > > > Hmm. Can we handle the case of the extraction exactly covering the > > insertion separately then and simplify to plain @1? > > I was suggesting that in the PR. Here it is as an incremental patch > on top of Andrew's patch. Ok for trunk if it passes bootstrap/regtest? Yes. Thanks, Richard. > On the newly added testcase the ifcvt-folding difference without/with the > incremental patch is: > --- pr108688.c.171t.ifcvt_ 2023-02-09 10:47:30.169916845 +0100 > +++ pr108688.c.171t.ifcvt 2023-02-09 10:48:44.942793453 +0100 > @@ -25,6 +25,8 @@ Number of blocks in CFG: 11 > Number of blocks to update: 5 ( 45%) > > > +Applying pattern match.pd:7487, gimple-match.cc:243200 > +Applying pattern match.pd:3987, gimple-match.cc:75423 > Matching expression match.pd:1677, gimple-match.cc:209 > Applying pattern match.pd:1733, gimple-match.cc:109481 > Matching expression match.pd:2393, gimple-match.cc:852 > @@ -70,7 +72,6 @@ void foo () > signed char _29; > _30; > unsigned int ivtmp_33; > - _ifc__35; > unsigned char _ifc__37; > unsigned char _ifc__38; > unsigned char _ifc__39; > @@ -91,8 +92,7 @@ void foo () > _2 = () a.0_1; > _ifc__38 = u.D.2741; > _ifc__39 = BIT_INSERT_EXPR <_ifc__38, _2, 0 (7 bits)>; > - _ifc__35 = BIT_FIELD_REF <_ifc__39, 7, 0>; > - _4 = (signed char) _ifc__35; > + _4 = (signed char) _2; > b.1_5 = b; > _6 = (signed char) b.1_5; > _7 = _4 ^ _6; > > 2023-02-09 Jakub Jelinek > > PR tree-optimization/108688 > * match.pd (bit_field_ref [bit_insert]): Simplify BIT_FIELD_REF > of BIT_INSERT_EXPR extracting exactly all inserted bits even > when without mode precision. Formatting fixes. > > * gcc.c-torture/compile/pr108688-1.c: Add PR number as comment. > * gcc.dg/pr108688.c: New test. > > --- gcc/match.pd.jj 2023-02-09 09:42:53.782418805 +0100 > +++ gcc/match.pd 2023-02-09 10:48:06.859365613 +0100 > @@ -7475,13 +7475,16 @@ (define_operator_list SYNC_FETCH_AND_AND > } > (switch > (if ((!INTEGRAL_TYPE_P (TREE_TYPE (@1)) > - || type_has_mode_precision_p (TREE_TYPE (@1))) > - && wi::leu_p (wi::to_wide (@ipos), wi::to_wide (@rpos)) > + || type_has_mode_precision_p (TREE_TYPE (@1))) > + && wi::leu_p (wi::to_wide (@ipos), wi::to_wide (@rpos)) > && wi::leu_p (wi::to_wide (@rpos) + wi::to_wide (@rsize), > wi::to_wide (@ipos) + isize)) > (BIT_FIELD_REF @1 @rsize { wide_int_to_tree (bitsizetype, > - wi::to_wide (@rpos) > + wi::to_wide (@rpos) > - wi::to_wide (@ipos)); })) > + (if (wi::eq_p (wi::to_wide (@ipos), wi::to_wide (@rpos)) > + && compare_tree_int (@rsize, isize) == 0) > + (convert @1)) > (if (wi::geu_p (wi::to_wide (@ipos), > wi::to_wide (@rpos) + wi::to_wide (@rsize)) > || wi::geu_p (wi::to_wide (@rpos), > --- gcc/testsuite/gcc.c-torture/compile/pr108688-1.c.jj 2023-02-09 09:42:53.782418805 +0100 > +++ gcc/testsuite/gcc.c-torture/compile/pr108688-1.c 2023-02-09 10:34:18.339817796 +0100 > @@ -1,4 +1,4 @@ > - > +/* PR tree-optimization/108688 */ > > union U { signed int d : 7; signed int e : 2; } u; > int a, b; > @@ -12,4 +12,3 @@ foo (void) > u.e ^= b; > } > } > - > --- gcc/testsuite/gcc.dg/pr108688.c.jj 2023-02-09 10:50:27.468253110 +0100 > +++ gcc/testsuite/gcc.dg/pr108688.c 2023-02-09 10:50:16.383419646 +0100 > @@ -0,0 +1,16 @@ > +/* PR tree-optimization/108688 */ > +/* { dg-do compile } */ > +/* { dg-options "-O2 -fno-tree-pre -fno-tree-fre -fno-tree-dominator-opts -fno-tree-loop-im -fno-code-hoisting" } */ > + > +union U { signed int d : 7; signed int e : 2; } u; > +int a, b; > + > +void > +foo (void) > +{ > + for (int i = 0; i < 64; i++) > + { > + u.d = a; > + u.d ^= b; > + } > +} > > > Jakub >