From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-456071-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 67615 invoked by alias); 16 Jun 2017 07:53:37 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 67234 invoked by uid 89); 16 Jun 2017 07:53:37 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Full
X-HELO: mail-oi0-f41.google.com
Received: from mail-oi0-f41.google.com (HELO mail-oi0-f41.google.com) (209.85.218.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 16 Jun 2017 07:53:35 +0000
Received: by mail-oi0-f41.google.com with SMTP id e11so20221015oia.2        for <gcc-patches@gcc.gnu.org>; Fri, 16 Jun 2017 00:53:40 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20161025;        h=x-gm-message-state:mime-version:in-reply-to:references:from:date         :message-id:subject:to:cc;        bh=Q7Lke3NTGIM86VJwOKgOAo7RbSwVNbnQBqJxto5GmG4=;        b=fJG3iF4ITcf0Lbp1n/3qs3/WsWdZxCHiQLvIQDDIjH9nPTef5ckYk6VMIhwE9ItkIj         dckn8NTxH+4zUnCwgyMiImZV91jHpKPetQ39ozwdQ84mn/COva5QTwFuuAdqh9XZ76hI         vqmW5v9V2yE1VJMMfkA/o0Nu3ygyeHMzUg9sCN77Yym69WE9nelMxaA+TaDNW+38P1iv         0pYJBPEkj6f6yy/s8aN8Trz40j+dSWuTu1ZIQd76Qu/lJ3HRdNwm0oA3bzcvumOnVsGm         kfVKLeTq6X0BgMuyq72JxIX/icX7Y6IgseVUkyitq9AigON1eQj5fKuVBkE2SxbRa+Bp         n5YA==
X-Gm-Message-State: AKS2vOwo7fq2irkKz7xcFcJyCJyfkpHCpkGI+TNXjq+WRRMD0TwOuxKR	C7U38cElsKnxBQyx4vhkwz12t8FdaA==
X-Received: by 10.202.239.131 with SMTP id n125mr4510163oih.19.1497599618848; Fri, 16 Jun 2017 00:53:38 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.157.37.66 with HTTP; Fri, 16 Jun 2017 00:53:38 -0700 (PDT)
In-Reply-To: <20170615175335.GG16550@gate.crashing.org>
References: <1497383085.24125.155.camel@brimstone.rchland.ibm.com> <20170615175335.GG16550@gate.crashing.org>
From: Richard Biener <richard.guenther@gmail.com>
Date: Fri, 16 Jun 2017 07:53:00 -0000
Message-ID: <CAFiYyc3ZPnEjcAwJp-dKHwWKJ5Q5VTbS1tKuNgbf+fryQ7gofw@mail.gmail.com>
Subject: Re: [PATCH, rs6000] (v3) Fold vector shifts in GIMPLE
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: Will Schmidt <will_schmidt@vnet.ibm.com>, GCC Patches <gcc-patches@gcc.gnu.org>, 	Bill Schmidt <wschmidt@linux.vnet.ibm.com>, David Edelsohn <dje.gcc@gmail.com>, 	Jakub Jelinek <jakub@redhat.com>
Content-Type: text/plain; charset="UTF-8"
X-IsSubscribed: yes
X-SW-Source: 2017-06/txt/msg01166.txt.bz2

On Thu, Jun 15, 2017 at 7:53 PM, Segher Boessenkool
<segher@kernel.crashing.org> wrote:
> Hi Will,
>
> On Tue, Jun 13, 2017 at 02:44:45PM -0500, Will Schmidt wrote:
>> I sniff-tested the latest changes on Power8, with good results.  Full
>> regtest running.  OK for trunk?
>
> This looks good to me, if Richard is happy with it now.  Some very minor
> things and it is good to go:

Yes, looks good to me.

Richard.

>>       2017-06-13  Will Schmidt  <will_schmidt@vnet.ibm.com>
>>
>>       * config/rs6000/rs6000.c: Add include of ssa-propagate.h for
>>       update_call_from_tree().
>>       (rs6000_gimple_fold_builtin): Add handling
>>       for early expansion of vector shifts (sl,sr,sra,rl).
>
> Funny line break there.
>
>> +  /* Flavors of vector shift right algebraic.
>> +   * vec_sra{b,h,w} -> vsra{b,h,w}.  */
>
> No leading * in comments please (more of those below).
>
>> +     /* convert arg0 to unsigned.  */
>
> Full sentences are capitalized.
>
>
> Segher