From: Richard Biener <richard.guenther@gmail.com>
To: Jeff Law <law@redhat.com>
Cc: Alan Lawrence <alan.lawrence@arm.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Richard Biener <rguenther@suse.de>
Subject: Re: [PATCH 2/5] completely_scalarize arrays as well as records
Date: Wed, 26 Aug 2015 07:11:00 -0000 [thread overview]
Message-ID: <CAFiYyc3ZxgswHtbhn+sqx0xDyDvoiHJ1jeSfSzuARMhk-idmkw@mail.gmail.com> (raw)
In-Reply-To: <55DCE1A2.7050501@redhat.com>
On Tue, Aug 25, 2015 at 11:44 PM, Jeff Law <law@redhat.com> wrote:
> On 08/25/2015 03:42 PM, Martin Jambor wrote:
>>
>> Hi,
>>
>> On Tue, Aug 25, 2015 at 12:06:14PM +0100, Alan Lawrence wrote:
>>>
>>> This changes the completely_scalarize_record path to also work on arrays
>>> (thus
>>> allowing records containing arrays, etc.). This just required extending
>>> the
>>> existing type_consists_of_records_p and completely_scalarize_record
>>> methods
>>> to handle things of ARRAY_TYPE as well as RECORD_TYPE. Hence, I renamed
>>> both
>>> methods so as not to mention 'record'.
>>
>>
>> thanks for working on this. I see Jeff has already approved the
>> patch, but I have two comments nevertheless. First, I would be much
>> happier if you added a proper comment to scalarize_elem function which
>> you forgot completely. The name is not very descriptive and it has
>> quite few parameters too.
>
> Right. I mentioned that I missed the lack of function comments when looking
> at #3 and asked Alan to go back and fix them in #1 and #2.
>
>>
>> Second, this patch should also fix PR 67283. It would be great if you
>> could verify that and add it to the changelog when committing if that
>> is indeed the case.
>
> Excellent. Yes, definitely mention the BZ.
One extra question is does the way we limit total scalarization work well
for arrays? I suppose we have either sth like the maximum size of an
aggregate we scalarize or the maximum number of component accesses
we create?
Thanks,
Richard.
> jeff
>
next prev parent reply other threads:[~2015-08-26 7:07 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-25 11:06 [PATCH 0/5][tree-sra.c] PR/63679 Make SRA replace constant pool loads Alan Lawrence
2015-08-25 11:06 ` [RFC 4/5] Handle constant-pool entries Alan Lawrence
2015-08-25 20:19 ` Jeff Law
2015-08-26 7:24 ` Richard Biener
2015-08-26 15:51 ` Alan Lawrence
2015-08-26 14:08 ` Martin Jambor
2015-08-25 11:06 ` [RFC 5/5] Always completely replace constant pool entries Alan Lawrence
2015-08-25 20:09 ` Jeff Law
2015-08-26 7:29 ` Richard Biener
2015-08-25 11:21 ` [PATCH 2/5] completely_scalarize arrays as well as records Alan Lawrence
2015-08-25 19:40 ` Jeff Law
2015-08-27 16:54 ` Fixing sra-12.c (was: Re: [PATCH 2/5] completely_scalarize arrays as well as records) Alan Lawrence
2015-08-27 20:58 ` Fixing sra-12.c Jeff Law
2015-08-25 21:44 ` [PATCH 2/5] completely_scalarize arrays as well as records Martin Jambor
2015-08-25 21:55 ` Jeff Law
2015-08-26 7:11 ` Richard Biener [this message]
2015-08-26 9:39 ` Martin Jambor
2015-08-26 10:12 ` Richard Biener
2015-08-26 16:30 ` Alan Lawrence
2015-08-26 19:18 ` Richard Biener
2015-08-27 16:00 ` Alan Lawrence
2015-08-28 7:19 ` Christophe Lyon
2015-08-28 8:06 ` Richard Biener
2015-08-28 8:16 ` Christophe Lyon
2015-08-28 8:31 ` Richard Biener
2015-08-28 10:09 ` Alan Lawrence
2015-08-28 13:35 ` Richard Biener
2015-08-28 14:05 ` Alan Lawrence
2015-08-28 15:17 ` Alan Lawrence
2015-09-07 13:20 ` Alan Lawrence
2015-09-08 12:47 ` Martin Jambor
2015-09-14 17:41 ` Alan Lawrence
2015-09-15 7:49 ` Richard Biener
2015-09-17 17:12 ` Alan Lawrence
2015-09-18 8:36 ` Richard Biener
2015-08-25 11:30 ` [PATCH 1/5] Refactor completely_scalarize_var Alan Lawrence
2015-08-25 19:36 ` Jeff Law
2015-08-25 21:42 ` Martin Jambor
2015-08-25 12:30 ` [PATCH 3/5] Build ARRAY_REFs when the base is of ARRAY_TYPE Alan Lawrence
2015-08-25 19:54 ` Jeff Law
2015-08-26 6:34 ` Bin.Cheng
2015-08-26 7:40 ` Richard Biener
2015-08-26 7:41 ` Bin.Cheng
2015-08-26 7:20 ` Richard Biener
2015-08-25 22:51 ` Martin Jambor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc3ZxgswHtbhn+sqx0xDyDvoiHJ1jeSfSzuARMhk-idmkw@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=alan.lawrence@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).