From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25095 invoked by alias); 26 Aug 2015 07:07:38 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 25079 invoked by uid 89); 26 Aug 2015 07:07:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-yk0-f182.google.com Received: from mail-yk0-f182.google.com (HELO mail-yk0-f182.google.com) (209.85.160.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 26 Aug 2015 07:07:36 +0000 Received: by ykfw73 with SMTP id w73so178147737ykf.3 for ; Wed, 26 Aug 2015 00:07:34 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.170.134.214 with SMTP id a205mr42472255ykc.89.1440572854041; Wed, 26 Aug 2015 00:07:34 -0700 (PDT) Received: by 10.37.85.213 with HTTP; Wed, 26 Aug 2015 00:07:33 -0700 (PDT) In-Reply-To: <55DCE1A2.7050501@redhat.com> References: <1440500777-25966-1-git-send-email-alan.lawrence@arm.com> <1440500777-25966-3-git-send-email-alan.lawrence@arm.com> <20150825214232.GB12831@virgil.suse.cz> <55DCE1A2.7050501@redhat.com> Date: Wed, 26 Aug 2015 07:11:00 -0000 Message-ID: Subject: Re: [PATCH 2/5] completely_scalarize arrays as well as records From: Richard Biener To: Jeff Law Cc: Alan Lawrence , GCC Patches , Richard Biener Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg01575.txt.bz2 On Tue, Aug 25, 2015 at 11:44 PM, Jeff Law wrote: > On 08/25/2015 03:42 PM, Martin Jambor wrote: >> >> Hi, >> >> On Tue, Aug 25, 2015 at 12:06:14PM +0100, Alan Lawrence wrote: >>> >>> This changes the completely_scalarize_record path to also work on arrays >>> (thus >>> allowing records containing arrays, etc.). This just required extending >>> the >>> existing type_consists_of_records_p and completely_scalarize_record >>> methods >>> to handle things of ARRAY_TYPE as well as RECORD_TYPE. Hence, I renamed >>> both >>> methods so as not to mention 'record'. >> >> >> thanks for working on this. I see Jeff has already approved the >> patch, but I have two comments nevertheless. First, I would be much >> happier if you added a proper comment to scalarize_elem function which >> you forgot completely. The name is not very descriptive and it has >> quite few parameters too. > > Right. I mentioned that I missed the lack of function comments when looking > at #3 and asked Alan to go back and fix them in #1 and #2. > >> >> Second, this patch should also fix PR 67283. It would be great if you >> could verify that and add it to the changelog when committing if that >> is indeed the case. > > Excellent. Yes, definitely mention the BZ. One extra question is does the way we limit total scalarization work well for arrays? I suppose we have either sth like the maximum size of an aggregate we scalarize or the maximum number of component accesses we create? Thanks, Richard. > jeff >