From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-513065-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 58186 invoked by alias); 12 Nov 2019 09:44:00 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 58159 invoked by uid 89); 12 Nov 2019 09:43:59 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=
X-HELO: mail-lf1-f65.google.com
Received: from mail-lf1-f65.google.com (HELO mail-lf1-f65.google.com) (209.85.167.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Nov 2019 09:43:58 +0000
Received: by mail-lf1-f65.google.com with SMTP id z188so5081045lfa.11        for <gcc-patches@gcc.gnu.org>; Tue, 12 Nov 2019 01:43:58 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=gmail.com; s=20161025;        h=mime-version:references:in-reply-to:from:date:message-id:subject:to         :cc:content-transfer-encoding;        bh=8jLAWRJpmf+//TeoCu78WRWQS+7qugAtJQZtM62Pn5o=;        b=a8zAWpldQsr8LA302eFPpy6uRJs6A0JD+9XMsIoWR3Wuh9i3YUcdaKJ2O/dXxrddMc         XRpmuQvSNSQCq/veggoTStbtsWu2v1KZ6/eC9vACibO2iX/UXCql38vpbtaFc1ZqFBun         SFpMTsYv44OhRHbIt5pV5XwecBpZ17dI5eu84GBbMnXrGWcyocL4dnI04mKSiw1A/DK8         ndcbIl2jwEqiGsNIcHJaw/dGAZmfdQ2STlI0s66T5l6SlcpzZ7qCop3oP3iyt6rFzF+T         2ACtMtv8m6u6Hmn68iGvFZOiskSGcTqqfJgB41j5eceDdQRm9QY6HkBCs+Q82jUbXUbf         GYoA==
MIME-Version: 1.0
References: <cover.1573125296.git.mliska@suse.cz> <90868706a74cb5641c5d15430200e50bbd3785e7.1573125297.git.mliska@suse.cz> <CAFiYyc0GQGb4Tq6Zs3pzO+urz0nSpRw+V1YGdoz76qAMamgFzA@mail.gmail.com> <f412c64e-b609-e07f-ec77-1e2167b31d30@suse.cz>
In-Reply-To: <f412c64e-b609-e07f-ec77-1e2167b31d30@suse.cz>
From: Richard Biener <richard.guenther@gmail.com>
Date: Tue, 12 Nov 2019 09:44:00 -0000
Message-ID: <CAFiYyc3_7HAeQrOnMEZ7nnzt+C==OcVuKwm8OUDyXZ3zYVkLXw@mail.gmail.com>
Subject: Re: [PATCH 8/9] Remove option_default_params and option_validate_param hooks.
To: =?UTF-8?Q?Martin_Li=C5=A1ka?= <mliska@suse.cz>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
X-SW-Source: 2019-11/txt/msg00858.txt.bz2

On Tue, Nov 12, 2019 at 10:21 AM Martin Li=C5=A1ka <mliska@suse.cz> wrote:
>
> On 11/11/19 3:36 PM, Richard Biener wrote:
> > as a followup I notice that the targets *_default_params () functions s=
hould
> > be merged into the default-options structs they have (did you check the
> > defaults are still applied and user-overridable?)
>
> Apparently, the *_default_params target hook is not called right now. So =
that
> I decided to directly transform all usages of that to default-options str=
ucts.
> I built all the affected cross compilers and checked --help=3Dparam -Q, w=
here
> I can see the overwritten default. Moreover, a param value can be properly
> adjusted with a user option.
>
> I'm running tests on x86_64-linux-gnu and ppc64-linux-gnu right now to ch=
eck
> affect of the attached patch.

OK.

Thanks,
Richard.

>
> Martin