public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Biener <richard.guenther@gmail.com>
To: Eric Botcazou <ebotcazou@adacore.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, Jeff Law <law@redhat.com>,
		Joseph Myers <joseph@codesourcery.com>
Subject: Re: [patch] Fix failure of ACATS c45503c at -O2
Date: Wed, 21 Oct 2015 13:18:00 -0000	[thread overview]
Message-ID: <CAFiYyc3_L1pKidVqJxqsMPSTbQqrmoOVZHfbaostLDLS_6=_Fg@mail.gmail.com> (raw)
In-Reply-To: <2100616.AKovr9yibX@polaris>

On Wed, Oct 21, 2015 at 3:06 PM, Eric Botcazou <ebotcazou@adacore.com> wrote:
>> Maybe add the comments to tree.def instead.
>
> Good idea, revised patch attached.

Ok.

Thanks,
Richard.

>
>         * tree.def (CEIL_DIV_EXPR, FLOOR_DIV_EXPR, ROUND_DIV_EXPR): Tweak
>         comments.
>         (TRUNC_MOD_EXPR, CEIL_MOD_EXPR, FLOOR_MOD_EXPR, ROUND_MOD_EXPR):
>         Add comments on sign of the result.
>         * fold-const.c (tree_binary_nonnegative_warnv_p) <FLOOR_MOD_EXPR>:
>         Recurse on operand #1 instead of operand #0.
>         <CEIL_MOD_EXPR>: Do not recurse.
>         <ROUND_MOD_EXPR>: Likewise.
>
> --
> Eric Botcazou

  reply	other threads:[~2015-10-21 13:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-20 16:38 Eric Botcazou
2015-10-20 19:04 ` Jeff Law
2015-10-20 22:10   ` Joseph Myers
2015-10-21  5:57     ` Jeff Law
2015-10-21  7:50       ` Eric Botcazou
2015-10-21  9:56         ` Richard Biener
2015-10-21 13:15           ` Eric Botcazou
2015-10-21 13:18             ` Richard Biener [this message]
2015-10-21 21:11             ` Richard Sandiford
2015-10-20 22:30   ` Eric Botcazou
2015-10-20 22:55     ` Joseph Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFiYyc3_L1pKidVqJxqsMPSTbQqrmoOVZHfbaostLDLS_6=_Fg@mail.gmail.com' \
    --to=richard.guenther@gmail.com \
    --cc=ebotcazou@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=joseph@codesourcery.com \
    --cc=law@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).