From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75627 invoked by alias); 27 Nov 2017 12:45:27 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 75557 invoked by uid 89); 27 Nov 2017 12:45:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KB_WAM_FROM_NAME_SINGLEWORD,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=HTo:U*markus, Hx-languages-length:765 X-HELO: mail-wm0-f52.google.com Received: from mail-wm0-f52.google.com (HELO mail-wm0-f52.google.com) (74.125.82.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 27 Nov 2017 12:45:14 +0000 Received: by mail-wm0-f52.google.com with SMTP id u83so34032109wmb.5 for ; Mon, 27 Nov 2017 04:45:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=5zGO7SFHOMGiUdEXRcpLinOZowWY7JXeh1xAz8fBMAY=; b=CCKuwk3z1MV3KPnWM+TLuW4uXEORQei0eEIwA8Qgl/7PP8VGfAoN1Kgh/mrpyF+G0e 7WyFOZrttw07OktYw6urhJbz/c8+C0p1AOeW9bqiggC26hdrmgO66q6YMeXOvfjQUWrY DiCigfaFzOqMLfaSMofmCSyt7kTa3JkaeTTQyfYR4kt6ulVRyDDfNJUuPM28Nc2W+qjP A5t+AUi9mGlxmWhL6KirrsxNcOvW+LT5ZxHd3e+dCsXAGC1pIYNG0cp94Tyfo0girc++ fPFo92QN3l/Sv2dxEteMXLRrEjxX9fMHfrbxa4tjY/qUpJe/Lb7ivWd0dbdL5kZ6P1Hf KL1w== X-Gm-Message-State: AJaThX5v7gvhFZc1/LM1NY9XEe6Vx2S8Q7vAYvkcRsOQ7GkWnmFKmIfh 7qXCikbipDmEl8nRCG2FDmZdzEMeSOWu3uRvbCHwyQ== X-Google-Smtp-Source: AGs4zMZLk40tLRYcLE2oVOMGcIL5uah9lrChj2M3tY3SX/DM9qjP8lsrrVljF4qS6hL2weUf5tgWKOPXphd7OQVA3sg= X-Received: by 10.80.144.168 with SMTP id c37mr53437275eda.182.1511786711150; Mon, 27 Nov 2017 04:45:11 -0800 (PST) MIME-Version: 1.0 Received: by 10.80.143.34 with HTTP; Mon, 27 Nov 2017 04:45:10 -0800 (PST) In-Reply-To: <20171126090520.GA367@x4> References: <20171125194217.GA367@x4> <20171126090520.GA367@x4> From: Richard Biener Date: Mon, 27 Nov 2017 13:01:00 -0000 Message-ID: Subject: Re: [PATCH] Fix UB in hash-map.h To: Markus Trippelsdorf Cc: Jason Merrill , gcc-patches List Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg02296.txt.bz2 On Sun, Nov 26, 2017 at 10:05 AM, Markus Trippelsdorf wrote: > bootstrap-ubsan shows: > gcc/hash-map.h:277:19: runtime error: member access within null pointer of type 'struct hash_map' > > Fix the issue by returning early. > bootstrap-ubsan on X86_64 and ppc64le. Tested on ppc64le. > > OK for trunk? Ok. > gcc/ > * hash-map.h (gt_cleare_cache): Avoid UB. > > diff --git a/gcc/hash-map.h b/gcc/hash-map.h > index 6b8365a9d0a6..e5630338491a 100644 > --- a/gcc/hash-map.h > +++ b/gcc/hash-map.h > @@ -274,6 +274,8 @@ template > static inline void > gt_cleare_cache (hash_map *h) > { > + if (!h) > + return; > gt_cleare_cache (&h->m_table); > } > > -- > Markus